September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Replace version attributes with elements
by juan.hernandez＠redhat.com 22 Sep '15

22 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Replace version attributes with elements ...................................................................... restapi: Replace version attributes with elements Currently the "version" element uses attributes for its properties: <version major="3" minor="5" ../> This is contrary to the common practice in the RESTAPI. This patch replaces them with inner elements: <version> <major>3</minor> <minor>5</minor> ... </version> Change-Id: I5da39cbdcb409e2bb0ece733cdd95c28594ccd1b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd 2 files changed, 22 insertions(+), 35 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5da39cbdcb409e2bb0ece733cdd95c28594ccd1b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Replace VCPU pin attributes with elements
by juan.hernandez＠redhat.com 22 Sep '15

22 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Replace VCPU pin attributes with elements ...................................................................... restapi: Replace VCPU pin attributes with elements Currently the VCPU pin element uses attributes for its properties: <cpu_tune> <vcpu_pin vcpu="0" cpu_set="0"/> </cpu_tune> This is contrary to the common practice in the RESTAPI. This patch replaces them with inner elements: <cpu_tune> <vcpu_pin> <vcpu>0</vcpu> <cpu_set>0</cpu_set> </vcpu_pin> </cpu_tune> Change-Id: I4f147166ed76c9d8875cbdb411b2953d6eee30df Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd 2 files changed, 22 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46000 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f147166ed76c9d8875cbdb411b2953d6eee30df Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core:remove customProperties from nic
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: core:remove customProperties from nic ...................................................................... core:remove customProperties from nic Change-Id: I7f1fa4d03d10dda7209232d294c032eee5cf640e Bug-Url: https://bugzilla.redhat.com/1246060 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageLabeledNetworksParametersBuilderImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToClusterInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UserConfiguredNetworkData.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersisterTest.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/03_06_1850_remove_custom_properties_from_vds_interface.sql 20 files changed, 236 insertions(+), 150 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Martin Mucha: Verified Alona Kaplan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f1fa4d03d10dda7209232d294c032eee5cf640e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: remove customProperties from nic
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: remove customProperties from nic ...................................................................... restapi: remove customProperties from nic Change-Id: I8effb67c2137e8f6732ba8b4e00365e539864f61 Bug-Url: https://bugzilla.redhat.com/1246060 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CustomPropertiesForVdsNetworkInterface.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostNicMapperTest.java 5 files changed, 93 insertions(+), 27 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Juan Hernandez: Looks good to me, but someone else must approve Martin Mucha: Verified Alona Kaplan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8effb67c2137e8f6732ba8b4e00365e539864f61 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: REVERT&FIX of: core: Remove deprecated and unused VdcO...
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: REVERT&FIX of: core: Remove deprecated and unused VdcOptions from db ...................................................................... core: REVERT&FIX of: core: Remove deprecated and unused VdcOptions from db reverted-Change-Id: I51d7ce9359a9ad38a034d656fb4ac1c5bab2ff43 in given patch there's problem with applying upgrade scripts. In one of upgrade scripts, values is read from vdc_options table and stored elsewhere, rendering this vdc_options row useless. However, if we remove this value from vdc_options table in 0000_config.sql, upgrade script won't find it and won't persist it elsewhere. Therefore we need to remove these values only after it's useless, ie. in upgrade script. Bug-Url: https://bugzilla.redhat.com/1265136 Change-Id: Ic7f4593c55cfb65084d94a96e92f93ec6adcf010 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1840_remove_deprecated_vdc_options.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Martin Peřina: Looks good to me, but someone else must approve Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7f4593c55cfb65084d94a96e92f93ec6adcf010 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: migrating-to is a running state as well
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: migrating-to is a running state as well ...................................................................... core: migrating-to is a running state as well mirgatingTo was a status that wasn't in use. we started to use the migratingTo status during the migration process. and many places checking for running() not taking into consideration the migratingTo, although it should, just as migratingFrom. in a specific scenario, user was able to remove the vm while it was migrating to, and caused the vm to become external. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1121089 Change-Id: I39403915fa17439224176fc4e5c065311142485a Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> (cherry picked from commit 9b7f8309f7d4446fcf2f83fb87bd158244bf2a5f) --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46518 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39403915fa17439224176fc4e5c065311142485a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: vmconsole: major cleanups
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: vmconsole: major cleanups ...................................................................... packaging: vmconsole: major cleanups triggered by the attempt to use the helper in devenv without entire sequence. found that implementation is way too complex, especially devenv handling which should be minimized, as it just add cost to production maintenance. reduced all devenv specific activities to one plugin. generalized the file creations, so same logic applies both to production and devenv. removed the proprietary "Artifact" pattern as it inconsistent with rest of packaging code, along with some other unneeded helper code. import os register constants module so postinstall will actually work. move conf file out of libexec into share/conf. enable build time customization of vmconsole locations. add ovirt-vmconsole-proxy dependencies, testing if package is available based on user/group is invalid as when package is removed user is kept. if such test is required it should be done using package specific files. the actual test is removed now. update/install vmconsole-proxy package as preparation for future. do not regenerate proxy keys if available so users' known_hosts will not be invalidated when upgrading. also do not regenerate helper and proxy certificates to avoid bloating CA database every upgrade. in future we will need to take care of renew as well, not at this cleanup scope. helper now reads the defaults before the sysconf configuration. improve uninstall text for human. remove port prompt. consistent variable names. remove of unused constants. simplify implementation. probably more. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1223671 Change-Id: I2c7aef7e1be1efc6015528e8d2ff97596a522d09 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile M ovirt-engine.spec.in R packaging/conf/ovirt-vmconsole-proxy-helper.conf.in M packaging/conf/ovirt-vmconsole-proxy.conf.in M packaging/etc/ovirt-vmconsole-proxy-helper.conf.d/README.in M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt_vmconsole_conf.py.in M packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/config.py.in M packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/constants.py A packaging/setup/plugins/ovirt-engine-common/vmconsole_proxy_helper/__init__.py A packaging/setup/plugins/ovirt-engine-common/vmconsole_proxy_helper/core.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/__init__.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/pki.py A packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/system.py 16 files changed, 434 insertions(+), 592 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46514 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c7aef7e1be1efc6015528e8d2ff97596a522d09 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: vmconsole: helper: exit with non zero if not http success
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: vmconsole: helper: exit with non zero if not http success ...................................................................... vmconsole: helper: exit with non zero if not http success Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1223671 Change-Id: I1e3be061695afcae389a92b8e953743577438331 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46495 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e3be061695afcae389a92b8e953743577438331 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: disable snapshot creation when preview snapshot
by ahadas＠redhat.com 22 Sep '15

22 Sep '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: disable snapshot creation when preview snapshot ...................................................................... webadmin: disable snapshot creation when preview snapshot Disable the 'create snapshot' button in the VMs grid and in the context menu of a VM, in case the VM is set to preview a snapshot. Change-Id: I8c71b56ead43d0a7d7378ccdaa21d59e3a1c5381 Bug-Url: https://bugzilla.redhat.com/994403 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/45782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c71b56ead43d0a7d7378ccdaa21d59e3a1c5381 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Replace CPU topology attributes with elements
by juan.hernandez＠redhat.com 22 Sep '15

22 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Replace CPU topology attributes with elements ...................................................................... restapi: Replace CPU topology attributes with elements Currently the CPU topology element used attributes for its properties: <cpu> <topology sockets="1" cores="1" threads="1"/> ... </cpu> This is contrary to the common practice in the RESTAPI. This patch replaces them with inner elements: <cpu> <topology> <sockets>1<sockets> <cores>1<cores> <threads>1<threads> </topology> ... </cpu> Change-Id: I90ee5a59d12a07aa98bb6db9c56b486e7edfc9a4 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd 2 files changed, 24 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45997 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90ee5a59d12a07aa98bb6db9c56b486e7edfc9a4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0