Change in ovirt-engine[master]: core: indication for snapshot preview in vm
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: indication for snapshot preview in vm
......................................................................
core: indication for snapshot preview in vm
Add a field in VM object that indicates whether the VM
is set to preview a snapshot or not. This is useful for
clients to disable operations that cannot be executed
on VM that is previewing a snapshot.
Change-Id: I4b87ffcc768417b75b0e1a192a1332e23d035474
Bug-Url: https://bugzilla.redhat.com/994403
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDaoImpl.java
M packaging/dbscripts/create_views.sql
3 files changed, 20 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/45780
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b87ffcc768417b75b0e1a192a1332e23d035474
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in otopi[master]: java: fix java-8 warnings
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: java: fix java-8 warnings
......................................................................
java: fix java-8 warnings
Change-Id: I29445ba52319b5c87c5f024dfd2206d305479c14
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/java/MachineDialogParser.java
M src/java/MachineDialogParserTest.java
M src/java/SoftError.java
3 files changed, 14 insertions(+), 9 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46523
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29445ba52319b5c87c5f024dfd2206d305479c14
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core: bugfix:when adding role_groups script must be reentrant
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: core: bugfix:when adding role_groups script must be reentrant
......................................................................
core: bugfix:when adding role_groups script must be reentrant
and must guarantee, that new role is added just once
fixes: I8461bb5e04c06dbcbe433ca37d3482b8b52ce742
Change-Id: Id8acb29b72483945e76b7c4c0dd204052dd52e23
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M packaging/dbscripts/upgrade/03_06_1840_add_configure_mac_pool_role_to_data_center_admin.sql
1 file changed, 1 insertion(+), 23 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46519
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8acb29b72483945e76b7c4c0dd204052dd52e23
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in otopi[master]: core: packager: reimplement the installUpdate
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: packager: reimplement the installUpdate
......................................................................
core: packager: reimplement the installUpdate
legacy note, this should not have been implemented
however, offline packages expect it to be implemented.
logic is incorrect, and packagers should reimplement it
properly.
Change-Id: Ia7939fe6d9628c3647e776c78b09b8f98669b312
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/otopi/packager.py
1 file changed, 14 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46521
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7939fe6d9628c3647e776c78b09b8f98669b312
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core: migrating-to is a running state as well
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: migrating-to is a running state as well
......................................................................
core: migrating-to is a running state as well
mirgatingTo was a status that wasn't in use.
we started to use the migratingTo status during the migration process.
and many places checking for running() not taking into consideration the
migratingTo, although it should, just as migratingFrom.
in a specific scenario, user was able to remove the vm while it was
migrating to, and caused the vm to become external.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1121089
Change-Id: I39403915fa17439224176fc4e5c065311142485a
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/31204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I39403915fa17439224176fc4e5c065311142485a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core: minor fix in creating memory dummy disks
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: minor fix in creating memory dummy disks
......................................................................
core: minor fix in creating memory dummy disks
The name of meta-data dummy disk was not initialized due
to what seems to be a copy-past mistake.
Change-Id: I14330098563e8bd8bbe2a4c7008f617ab459b77c
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/46509
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14330098563e8bd8bbe2a4c7008f617ab459b77c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: restapi: Replace CPU "id" attribute with "type" element
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Replace CPU "id" attribute with "type" element
......................................................................
restapi: Replace CPU "id" attribute with "type" element
Current the "cpu" element has an "id" attribute that indicates the type
of CPU:
<cpu id="Intel Conroe Family">
<architecture>X86_64</architecture>
...
</cpu>
This is in contradiction with the rest of the elements of the RESTAPI
model, where the "id" attribute is used for opaque identifiers. This
patch replaces the "id" attribute with a new "type" element:
<cpu>
<type>Intel Conroe Family</type>
<architecture>X86_64</architecture>
...
</cpu>
Change-Id: I54d7f270832370b324e92521ca8b659e84a593c6
Bug-Url: https://bugzilla.redhat.com/1259620
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/README.md
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilityResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClustersResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterClustersResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/ClusterMapperTest.java
10 files changed, 34 insertions(+), 14 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45996
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54d7f270832370b324e92521ca8b659e84a593c6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: engine: Fix NETWORK_ATTACHMENTS_NOT_EXISTS message
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: Fix NETWORK_ATTACHMENTS_NOT_EXISTS message
......................................................................
engine: Fix NETWORK_ATTACHMENTS_NOT_EXISTS message
Fix NETWORK_ATTACHMENTS_NOT_EXISTS message:
* Fix the network attachment IDs replacement
* Fix typo
Change-Id: Id3266920ecabe8120a1224487c861020f8b6008d
Bug-Url: https://bugzilla.redhat.com/1264959
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/46494
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3266920ecabe8120a1224487c861020f8b6008d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Add hints to affinity group dialog
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: Add hints to affinity group dialog
......................................................................
webadmin: Add hints to affinity group dialog
Added hints for positive and enforcing checkboxes.
Change-Id: I348dfa1351477d3d894d53b83b76d17d0f872949
Bug-Url: https://bugzilla.redhat.com/1057480
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
(cherry picked from commit cdb36dbf6bde04b7d47ab1ddc6412b12f3b10600)
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/AffinityGroupPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/AffinityGroupPopupView.ui.xml
3 files changed, 39 insertions(+), 12 deletions(-)
Approvals:
Piotr Kliczewski: Passed CI tests
Tomas Jelinek: Looks good to me, approved
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/46453
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I348dfa1351477d3d894d53b83b76d17d0f872949
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: packaging: vmconsole: major cleanups
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: vmconsole: major cleanups
......................................................................
packaging: vmconsole: major cleanups
triggered by the attempt to use the helper in devenv without entire
sequence.
found that implementation is way too complex, especially devenv handling
which should be minimized, as it just add cost to production
maintenance.
reduced all devenv specific activities to one plugin.
generalized the file creations, so same logic applies both to production
and devenv.
removed the proprietary "Artifact" pattern as it inconsistent with rest
of packaging code, along with some other unneeded helper code.
import os
register constants module so postinstall will actually work.
move conf file out of libexec into share/conf.
enable build time customization of vmconsole locations.
add ovirt-vmconsole-proxy dependencies, testing if package is available
based on user/group is invalid as when package is removed user is kept.
if such test is required it should be done using package specific files.
the actual test is removed now.
update/install vmconsole-proxy package as preparation for future.
do not regenerate proxy keys if available so users' known_hosts will not
be invalidated when upgrading. also do not regenerate helper and proxy
certificates to avoid bloating CA database every upgrade. in future we
will need to take care of renew as well, not at this cleanup scope.
helper now reads the defaults before the sysconf configuration.
improve uninstall text for human.
remove port prompt.
consistent variable names.
remove of unused constants.
simplify implementation.
probably more.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1223671
Change-Id: I2c7aef7e1be1efc6015528e8d2ff97596a522d09
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M .gitignore
M Makefile
M ovirt-engine.spec.in
R packaging/conf/ovirt-vmconsole-proxy-helper.conf.in
M packaging/conf/ovirt-vmconsole-proxy.conf.in
M packaging/etc/ovirt-vmconsole-proxy-helper.conf.d/README.in
M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py
M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt_vmconsole_conf.py.in
M packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/config.py.in
M packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/constants.py
A packaging/setup/plugins/ovirt-engine-common/vmconsole_proxy_helper/__init__.py
A packaging/setup/plugins/ovirt-engine-common/vmconsole_proxy_helper/core.py
M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py
M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/pki.py
A packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/system.py
16 files changed, 435 insertions(+), 597 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46378
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c7aef7e1be1efc6015528e8d2ff97596a522d09
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month