September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: engine: add ip configuration out of sync indication
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: add ip configuration out of sync indication ...................................................................... engine: add ip configuration out of sync indication Change-Id: I320ba000124dfbfd4379a3f95988e788194eb361 Bug-Url: https://bugzilla.redhat.com/1242235 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/ReportedConfigurationsFiller.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ReportedConfigurations.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterface.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterfaceTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/NetworkImplementationDetailsUtils.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java 6 files changed, 245 insertions(+), 44 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Alona Kaplan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46460 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I320ba000124dfbfd4379a3f95988e788194eb361 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: check box header
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: check box header ...................................................................... webadmin: check box header - The ResizeableCheckboxHeader was not propagating the 'change' event handling causing some header check boxes to not react to changes. This patch fixes the issue. Unfortunately I have to 'polute' the ResizableHeader to handle change as constructor is the only place that allows one to pass in the checkbox that handles the event. This means that the method that creates the checkbox has to be static, and you can't override a static method. Change-Id: Ib302582c57055705c7348112d99b49f5ec6a8841 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1257168 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/ResizableHeader.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/ResizeableCheckboxHeader.java 2 files changed, 1 insertion(+), 18 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46462 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib302582c57055705c7348112d99b49f5ec6a8841 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: column checkboxes
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: column checkboxes ...................................................................... webadmin: column checkboxes - Column check boxes were not working as they would never update the underlying model due to not handling the 'change' event. This patch fixes the issue. Change-Id: I4b38428b8fe7cda349f0c2f420ff35e243930523 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1264041 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/CheckboxCell.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46472 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b38428b8fe7cda349f0c2f420ff35e243930523 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Bold usages and MTU in HostSetupNetwork tooltip
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Bold usages and MTU in HostSetupNetwork tooltip ...................................................................... webadmin: Bold usages and MTU in HostSetupNetwork tooltip Change-Id: Ib6516586e869af91333c5fe615d0ab6abb10462c Bug-Url: https://bugzilla.redhat.com/1258788 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java 4 files changed, 40 insertions(+), 13 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Alona Kaplan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6516586e869af91333c5fe615d0ab6abb10462c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: Added check-merged.sh script with ovirt_build_quick option
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: Added check-merged.sh script with ovirt_build_quick option ...................................................................... Added check-merged.sh script with ovirt_build_quick option Copied check-patch script to check-merged.sh script. Change-Id: I1f7a998ffcec06f2a6621a138505a5dfd327b85a Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- A automation/check-merged.packages A automation/check-merged.repos A automation/check-merged.sh 3 files changed, 95 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46468 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f7a998ffcec06f2a6621a138505a5dfd327b85a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Change color of setup networks tooltip separetion ...
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Change color of setup networks tooltip separetion lines ...................................................................... webadmin: Change color of setup networks tooltip separetion lines Change-Id: Ibce487607e93d9f7fa13e0a5368d32db20275109 Bug-Url: https://bugzilla.redhat.com/1258787 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java 2 files changed, 5 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Alona Kaplan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46458 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibce487607e93d9f7fa13e0a5368d32db20275109 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: host install current version
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: host install current version ...................................................................... webadmin: host install current version - The curren version was too narrow to contain all the text. Made the dialog a little wider and also made the field take up more space in the dialog. - Updated the layout to be patternfly based. Change-Id: Ie6cf8f0dbd7b7be7e80c9dc8ad9bb795433c6cb6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1191158 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseEntityModelCheckboxEditor.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.ui.xml 4 files changed, 88 insertions(+), 42 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6cf8f0dbd7b7be7e80c9dc8ad9bb795433c6cb6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: insert seperation lines in out of sync info
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: insert seperation lines in out of sync info ...................................................................... webadmin: insert seperation lines in out of sync info - add seperation line between the different sections of the item info popup - changing the color of 'out-of-sync' image border to be white Change-Id: I95d16e0e1734f3dad0ee7f1206a931a6db53bdd6 Bug-Url: https://bugzilla.redhat.com/1248677 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkOutOfSyncPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java 6 files changed, 47 insertions(+), 6 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Alona Kaplan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46457 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95d16e0e1734f3dad0ee7f1206a931a6db53bdd6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: modifying network_not_sync.png
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: modifying network_not_sync.png ...................................................................... webadmin: modifying network_not_sync.png Bug-Url: https://bugzilla.redhat.com/1248647 Change-Id: If67893e6aa3d2437a31631ccc0573c2756b853d7 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/network_not_sync.png 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Alona Kaplan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If67893e6aa3d2437a31631ccc0573c2756b853d7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: modifying out of sync icon position
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: modifying out of sync icon position ...................................................................... webadmin: modifying out of sync icon position Host setup network popup, moving the out of sync icon from roles area to statuses area Bug-Url: https://bugzilla.redhat.com/1248647 Change-Id: I412187575ca16503b460351259ff1935f3af27cb Signed-off-by: Eliraz Levi <elevi(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java 3 files changed, 12 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Alona Kaplan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46455 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I412187575ca16503b460351259ff1935f3af27cb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0