January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: AddVmTemplateCommand streaming API
by amureini＠redhat.com 19 Jan '16

19 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmTemplateCommand streaming API ...................................................................... core: AddVmTemplateCommand streaming API Used Java 8 streaming API when creating new collections instead of cumbersome for-loops. Change-Id: I0b605de90c893c83b82191de578806019705d9ba Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 11 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52246 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b605de90c893c83b82191de578806019705d9ba Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetVmTemplatesWithPermittedActionQueryTest copy-pastes
by amureini＠redhat.com 19 Jan '16

19 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetVmTemplatesWithPermittedActionQueryTest copy-pastes ...................................................................... core: GetVmTemplatesWithPermittedActionQueryTest copy-pastes Fixed wrong references to storage pools and data centers in GetVmTemplatesWithPermittedActionQueryTest which were probably introduced when this entire class was copy-pasted from a different test. Change-Id: I56d200e550c06a27d476edf2334a9f2dcb8b581b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmTemplatesWithPermittedActionQueryTest.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52283 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56d200e550c06a27d476edf2334a9f2dcb8b581b Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Ignore expected exception during connection attempts
by tnisan＠redhat.com 19 Jan '16

19 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Ignore expected exception during connection attempts ...................................................................... core: Ignore expected exception during connection attempts when an expected exception is thrown during attempt to connect to the host, it can be ignored. Any other exception should be logged. Change-Id: I68835aeadeb64d9cbd46239547efddb0653b794d Bug-Url: https://bugzilla.redhat.com/1299232 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Tal Nisan: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52411 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68835aeadeb64d9cbd46239547efddb0653b794d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Ignore expected exception during connection attempts
by masayag＠redhat.com 19 Jan '16

19 Jan '16

Moti Asayag has submitted this change and it was merged. Change subject: core: Ignore expected exception during connection attempts ...................................................................... core: Ignore expected exception during connection attempts when an expected exception is thrown during attempt to connect to the host, it can be ignored. Any other exception should be logged. Change-Id: I68835aeadeb64d9cbd46239547efddb0653b794d Bug-Url: https://bugzilla.redhat.com/1299232 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68835aeadeb64d9cbd46239547efddb0653b794d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: Stop monitoring domain during maintenance / shutdown
by msivak＠redhat.com 19 Jan '16

19 Jan '16

Martin Sivák has submitted this change and it was merged. Change subject: Stop monitoring domain during maintenance / shutdown ...................................................................... Stop monitoring domain during maintenance / shutdown The vdsm's domain monitor has to be stopped when owned by the HA agent. The stop is important for upgrade reasons as it releases sanlock leases that would otherwise prevent sanlock from upgrading. Increasing killproc timeout from default (3 seconds) to 90 seconds (systemd defaults) to have all the time to properly remove the lease and stop monitoring before being killed with -9. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1298461 Change-Id: I7761fe7e40cb4df6a942b70d2f3307c098828293 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M initscripts/ovirt-ha-agent.init.in M ovirt_hosted_engine_ha/agent/hosted_engine.py 2 files changed, 55 insertions(+), 3 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51792 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7761fe7e40cb4df6a942b70d2f3307c098828293 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: Revert "build: post ovirt-hosted-engine-setup-1.3.2.3"
by sbonazzo＠redhat.com 19 Jan '16

19 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Revert "build: post ovirt-hosted-engine-setup-1.3.2.3" ...................................................................... Revert "build: post ovirt-hosted-engine-setup-1.3.2.3" This reverts commit 347555f7acfe5c7ac474fe9d71e1fdd1610f227f. Change-Id: Iacac030c060f6929ec34779e60b25bb8031cbe30 Signed-Off-By: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 6 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacac030c060f6929ec34779e60b25bb8031cbe30 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: clarify message
by sbonazzo＠redhat.com 19 Jan '16

19 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: clarify message ...................................................................... packaging: clarify message s/the management console/the engine/ We use "the engine" in many other places and never use "management console". Change-Id: I71d8914e64ea2dab655a4ef9b904d9c9a80dcfb7 Bug-Url: https://bugzilla.redhat.com/1241430 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit af064e8bed950313a3e99140a85b8b3176d1922b) --- M src/plugins/ovirt-hosted-engine-setup/core/misc.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52427 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71d8914e64ea2dab655a4ef9b904d9c9a80dcfb7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: clarify message
by sbonazzo＠redhat.com 19 Jan '16

19 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: clarify message ...................................................................... packaging: clarify message s/the management console/the engine/ We use "the engine" in many other places and never use "management console". Change-Id: I71d8914e64ea2dab655a4ef9b904d9c9a80dcfb7 Bug-Url: https://bugzilla.redhat.com/1241430 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/core/misc.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71d8914e64ea2dab655a4ef9b904d9c9a80dcfb7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: build: post ovirt-hosted-engine-setup-1.3.2.3
by sbonazzo＠redhat.com 19 Jan '16

19 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-1.3.2.3 ...................................................................... build: post ovirt-hosted-engine-setup-1.3.2.3 Change-Id: I21c8ae8a06425f3eb2e37eb711f699e2fa993ae1 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52400 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21c8ae8a06425f3eb2e37eb711f699e2fa993ae1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: build: ovirt-hosted-engine-setup-1.3.2.3
by sbonazzo＠redhat.com 19 Jan '16

19 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-1.3.2.3 ...................................................................... build: ovirt-hosted-engine-setup-1.3.2.3 Change-Id: If72ee86940d1ba9b1de10cf63013e3a6e2429d71 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 13 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52399 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If72ee86940d1ba9b1de10cf63013e3a6e2429d71 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0