Change in ovirt-engine[master]: core: Allow GetVmTemplatesByStoragePoolIdQuery in UserPortal
by mperina@redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: core: Allow GetVmTemplatesByStoragePoolIdQuery in UserPortal
......................................................................
core: Allow GetVmTemplatesByStoragePoolIdQuery in UserPortal
The query was being used from userportal which failed because it was not
specified as "user" query.
Change-Id: If9359ac6b306ba80e920dc04588c34df7859dc2a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1265278
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Verified
Shmuel Leib Melamud: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/52449
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9359ac6b306ba80e920dc04588c34df7859dc2a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine-sdk-ruby[master]: Release 4.0.0.alpha4
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Release 4.0.0.alpha4
......................................................................
Release 4.0.0.alpha4
Change-Id: Id38b5b101913784b81fd47a2b8c424cb5eca044b
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52489
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id38b5b101913784b81fd47a2b8c424cb5eca044b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: engine: Do not assign creator as owner to VMs from pool
by mperina@redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: engine: Do not assign creator as owner to VMs from pool
......................................................................
engine: Do not assign creator as owner to VMs from pool
If VM is created to attach it to a VM pool, do not assign its creator as
owner in any case. Assignment of a user to the VM in this case will
designate this VM as occupied and prevent other users from taking it.
This assignment happens currently when pool creator doesn't have
MANIPULATE_PERMISSIONS role on the pool VMs.
Change-Id: I6af18a2b7caa8181523a277f4d63cc688e69a59e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1298094
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51875
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6af18a2b7caa8181523a277f4d63cc688e69a59e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine-sdk-ruby[master]: Update README.md
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Update README.md
......................................................................
Update README.md
This patch updates the README.md, as it wasn't updated when the
"_service" suffix was added to locator methods.
Change-Id: I79d3cb04a9fd6c7893200594178624899eff6b25
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/README.md
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52488
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79d3cb04a9fd6c7893200594178624899eff6b25
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine-sdk-ruby[master]: Add version header
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Add version header
......................................................................
Add version header
This patch changes the "Connection" class so that it will always send
the header that indicates the requested version of the API, which for
this version of the SDK will always be "4". The header looks like this:
Version: 4
Change-Id: I65fd750d28bd279dd6c153c2f440ea5e929260f0
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/lib/ovirt/sdk/v4/connection.rb
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52487
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65fd750d28bd279dd6c153c2f440ea5e929260f0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine-sdk-ruby[master]: Custom user agent
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Custom user agent
......................................................................
Custom user agent
This patch changes the SDK "Connection" class so that it will always
send the "User-Agent" header containing the version number of the SDK,
something like this:
User-Agent: RubySDK/4.0.0.alpha3
Change-Id: I983b1c131723f93aa6f53902ca79bc617df82dc1
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/lib/ovirt/sdk/v4/connection.rb
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52486
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I983b1c131723f93aa6f53902ca79bc617df82dc1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine-sdk-ruby[master]: Add "_service" to all locator methods
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Add "_service" to all locator methods
......................................................................
Add "_service" to all locator methods
Currently the locator methods are named like in the specification of the
API. For example, the method used to find the virtual machines service
is named "vms". This patch changes those methods so that they will have
a "_service" suffix, making it clearer that they return references to
services, not objects.
Change-Id: If3dacbd895fda86b9672643bb045fd23cf2203a0
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java
M sdk/examples/add_cluster.rb
M sdk/examples/add_data_center.rb
M sdk/examples/add_host.rb
M sdk/examples/add_nfs_data_storage_domain.rb
M sdk/examples/add_nfs_iso_storage_domain.rb
M sdk/examples/add_vm.rb
M sdk/examples/add_vm_disk.rb
M sdk/examples/add_vm_nic.rb
M sdk/examples/attach_nfs_data_storage_domain.rb
M sdk/examples/attach_nfs_iso_storage_domain.rb
M sdk/examples/follow_vm_links.rb
M sdk/examples/list_vms.rb
M sdk/examples/remove_host.rb
M sdk/examples/remove_vm.rb
M sdk/examples/search_vms.rb
M sdk/examples/start_vm.rb
M sdk/examples/stop_vm.rb
M sdk/examples/update_data_center.rb
M sdk/lib/ovirt/sdk/v4/connection.rb
M sdk/spec/clusters_service_spec.rb
M sdk/spec/data_centers_service_spec.rb
M sdk/spec/storage_domains_service_spec.rb
M sdk/spec/vms_service_spec.rb
24 files changed, 68 insertions(+), 68 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52485
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3dacbd895fda86b9672643bb045fd23cf2203a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine-sdk-ruby[master]: Fix link following
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Fix link following
......................................................................
Fix link following
This patch fixes the "Connection.url" method. It needs to return a URI
object, not a string. Without this fix the link following capability
doesn't work correctly.
In addition the patch also adds an example that shows how to use the
link following capability.
Change-Id: I9bd82acb0ae6de5f6f2110eb3fdcf6a89dfada61
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
A sdk/examples/follow_vm_links.rb
M sdk/lib/ovirt/sdk/v4/connection.rb
2 files changed, 69 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52479
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9bd82acb0ae6de5f6f2110eb3fdcf6a89dfada61
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6.2]: packaging: moving the ovirt extentions api dependencies to h...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: moving the ovirt extentions api dependencies to his own line
......................................................................
packaging: moving the ovirt extentions api dependencies to his own line
- since the ovirt extentions api is the only depenency that
has -SNAPSHOT, it makes sense to emphasis it in a seperate
section to reduce risk on missing it for official releases
and also reduce possibility of rebase conflicts
with downstream code when one dependency changes
Change-Id: I66d1ec3cd7ed71a507f56c86bd55d2d82231f9a0
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M pom.xml
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Eyal Edri: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/52447
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66d1ec3cd7ed71a507f56c86bd55d2d82231f9a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.2
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: packaging: moving the ovirt extentions api dependencies to h...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: moving the ovirt extentions api dependencies to his own line
......................................................................
packaging: moving the ovirt extentions api dependencies to his own line
- since the ovirt extentions api is the only depenency that
has -SNAPSHOT, it makes sense to emphasis it in a seperate
section to reduce risk on missing it for official releases
and also reduce possibility of rebase conflicts
with downstream code when one dependency changes
Change-Id: I66d1ec3cd7ed71a507f56c86bd55d2d82231f9a0
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M pom.xml
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Eyal Edri: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/52446
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66d1ec3cd7ed71a507f56c86bd55d2d82231f9a0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 11 months