January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webmadin: AbstractCheckboxColumn#handleEvent
by amureini＠redhat.com 19 Jan '16

19 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: webmadin: AbstractCheckboxColumn#handleEvent ...................................................................... webmadin: AbstractCheckboxColumn#handleEvent Removed unused method AbstractCheckboxColumn#handleEvent(CellPreviewEvent<EntityModel>). Change-Id: Iac19f3a85c5870081648a34a7696890c247edcdd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractCheckboxColumn.java 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52238 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac19f3a85c5870081648a34a7696890c247edcdd Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: engine, userportal, webadmin: log uncaught UI exceptions
by tnisan＠redhat.com 19 Jan '16

19 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: engine,userportal,webadmin: log uncaught UI exceptions ...................................................................... engine,userportal,webadmin: log uncaught UI exceptions - Add the ability to log unobfuscated uncaught UI exceptions in a seperate log on the engine. - Add a check for symbol maps on the engine. Change-Id: Icadfd28f55c10c77c3ad7cc17cf9a14370ab2edd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1179897 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingFilter.java M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/stylesheets.tag M backend/manager/modules/branding/src/test/java/org/ovirt/engine/core/branding/BrandingFilterTest.java M backend/manager/modules/docs/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/OvirtRemoteLoggingService.java M frontend/webadmin/modules/frontend/src/main/resources/META-INF/web-fragment.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AlertManager.java M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml M packaging/services/ovirt-engine/ovirt-engine.xml.in M packaging/sys-etc/logrotate.d/ovirt-engine.in 14 files changed, 153 insertions(+), 12 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52389 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icadfd28f55c10c77c3ad7cc17cf9a14370ab2edd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine, userportal, webadmin: log uncaught UI exceptions
by tnisan＠redhat.com 19 Jan '16

19 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: engine,userportal,webadmin: log uncaught UI exceptions ...................................................................... engine,userportal,webadmin: log uncaught UI exceptions - Add the ability to log unobfuscated uncaught UI exceptions in a seperate log on the engine. - Add a check for symbol maps on the engine. Change-Id: Icadfd28f55c10c77c3ad7cc17cf9a14370ab2edd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1179897 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingFilter.java M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/stylesheets.tag M backend/manager/modules/branding/src/test/java/org/ovirt/engine/core/branding/BrandingFilterTest.java M backend/manager/modules/docs/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/OvirtRemoteLoggingService.java M frontend/webadmin/modules/frontend/src/main/resources/META-INF/web-fragment.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AlertManager.java M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml M packaging/services/ovirt-engine/ovirt-engine.xml.in M packaging/sys-etc/logrotate.d/ovirt-engine.in 14 files changed, 153 insertions(+), 12 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icadfd28f55c10c77c3ad7cc17cf9a14370ab2edd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine, userportal, webadmin: log uncaught UI exceptions
by awels＠redhat.com 18 Jan '16

18 Jan '16

Alexander Wels has submitted this change and it was merged. Change subject: engine,userportal,webadmin: log uncaught UI exceptions ...................................................................... engine,userportal,webadmin: log uncaught UI exceptions - Add the ability to log unobfuscated uncaught UI exceptions in a seperate log on the engine. - Add a check for symbol maps on the engine. Change-Id: Icadfd28f55c10c77c3ad7cc17cf9a14370ab2edd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1179897 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingFilter.java M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/stylesheets.tag M backend/manager/modules/branding/src/test/java/org/ovirt/engine/core/branding/BrandingFilterTest.java M backend/manager/modules/docs/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/OvirtRemoteLoggingService.java M frontend/webadmin/modules/frontend/src/main/resources/META-INF/web-fragment.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AlertManager.java M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml M packaging/services/ovirt-engine/ovirt-engine.xml.in M packaging/sys-etc/logrotate.d/ovirt-engine.in 15 files changed, 154 insertions(+), 13 deletions(-) Approvals: Alexander Wels: Verified; Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icadfd28f55c10c77c3ad7cc17cf9a14370ab2edd Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add "is_link" attribute
by juan.hernandez＠redhat.com 18 Jan '16

18 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add "is_link" attribute ...................................................................... Add "is_link" attribute This patch adds a new "is_link" attribute to struct and list types. This attribute indicates if the object is used as a link or as a normal object. When an object is used as a link the server will only populate the identifier and "href" attributes. For example, in the specification of the virtual machine type the "cluster" attribute is defined as a link: @Type interface VmBase extends Identified { ... @Link Cluster cluster(); ... } This means that the server won't return the complete entity, but just the identifier and the "href" attributes: <vm ...> ... <cluster id="123" href=".../clusters/123"/> ... </vm> The Ruby SDK will mark these uses of the objects, using the "is_link" flag, so that the users of the SDK can decide, based on the value of this flag, if furhter loading is needed: # Get the VM: vm = ... # Check if the cluster is a link, in which case we need to # load its complete representation explicitly: if vm.cluster.is_link? vm.cluster = clusters_service.get({:id => vm.cluster.id}) end Change-Id: Ifac0d857942e8ca32a2fa5fb24d845a79c4380a7 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java M sdk/lib/ovirt/sdk/v4/types/list.rb M sdk/lib/ovirt/sdk/v4/types/struct.rb M sdk/spec/vm_reader_spec.rb 4 files changed, 93 insertions(+), 9 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52350 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifac0d857942e8ca32a2fa5fb24d845a79c4380a7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add path locator methods
by juan.hernandez＠redhat.com 18 Jan '16

18 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add path locator methods ...................................................................... Add path locator methods This patch adds a "service" method to the connection and to all the service implementations. This method receives a string parameter containing the path to a service, for example "vms/123/disks" and returns a reference to the corresponding service implementation. The new method is intended to be part of the implementation of link following that will be added by later patches. Change-Id: Id16f8b320b27ea1ad347dc116d0f2653b3f72d57 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M sdk/lib/ovirt/sdk/v4/connection.rb M sdk/spec/connection_spec.rb 3 files changed, 146 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id16f8b320b27ea1ad347dc116d0f2653b3f72d57 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: core: delete Cinder snapshot failover.
by tnisan＠redhat.com 18 Jan '16

18 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: delete Cinder snapshot failover. ...................................................................... core: delete Cinder snapshot failover. When deleting a Cinder snapshot there is no need to update the active flag on failure, Cinder snapshot works differently than images so the active volume with Cinder disk will always be the active one. Change-Id: If15d65c6db19446aaf50e1fdd846ec6fc57f3361 Bug-Url: https://bugzilla.redhat.com/1297842 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveCinderSnapshotDiskCommand.java 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If15d65c6db19446aaf50e1fdd846ec6fc57f3361 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: core: Add TODO once fix will be backported
by tnisan＠redhat.com 18 Jan '16

18 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Add TODO once fix will be backported ...................................................................... core: Add TODO once fix will be backported Change-Id: Ic6ac83f1df6d149d52870e933de403a7e2f579e5 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1297312 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommand.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6ac83f1df6d149d52870e933de403a7e2f579e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: core: Support revert of new Cinder snapshot.
by tnisan＠redhat.com 18 Jan '16

18 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Support revert of new Cinder snapshot. ...................................................................... core: Support revert of new Cinder snapshot. Adding revert task when creating Cinder snapshot so the volumes which were created based on this snapshot will be removed. Change-Id: Ic6ac83f1df6d149d52870e933de403a7e2f579e4 Bug-Url: https://bugzilla.redhat.com/1297312 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommand.java 1 file changed, 28 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52355 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6ac83f1df6d149d52870e933de403a7e2f579e4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: restapi: Fix update of virtio_scsi.enabled
by tnisan＠redhat.com 18 Jan '16

18 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix update of virtio_scsi.enabled ...................................................................... restapi: Fix update of virtio_scsi.enabled Currently the "virtio_scsi.enabled" property is ignored by the update operations of virtual machines, templates and instance types. This patch fixes that. Change-Id: Id016e1006c5e07aacf80e6661e30b61d0c20a128 Bug-Url: https://bugzilla.redhat.com/1298489 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java 3 files changed, 13 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52352 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id016e1006c5e07aacf80e6661e30b61d0c20a128 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0