January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.2]: userportal: Fixed New Template dialog size
by tnisan＠redhat.com 19 Jan '16

19 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: userportal: Fixed New Template dialog size ...................................................................... userportal: Fixed New Template dialog size Changed the size of the New Template dialog in the user portal so elements won't slide off it. Change-Id: I28758fce935c6057d328f387e0838a035d6faa0f Bug-Url: https://bugzilla.redhat.com/1190142 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Tomer Saban: Verified -- To view, visit https://gerrit.ovirt.org/52369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28758fce935c6057d328f387e0838a035d6faa0f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: userportal: Fixed New Template dialog size
by tnisan＠redhat.com 19 Jan '16

19 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: userportal: Fixed New Template dialog size ...................................................................... userportal: Fixed New Template dialog size Changed the size of the New Template dialog in the user portal so elements won't slide off it. Change-Id: I28758fce935c6057d328f387e0838a035d6faa0f Bug-Url: https://bugzilla.redhat.com/1190142 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Tomer Saban: Verified -- To view, visit https://gerrit.ovirt.org/51226 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28758fce935c6057d328f387e0838a035d6faa0f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: userportal: Fix exception in resources VM table
by tnisan＠redhat.com 19 Jan '16

19 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: userportal: Fix exception in resources VM table ...................................................................... userportal: Fix exception in resources VM table - Fixed issue where the ID was not being passed to the columns - Fixed issue where getContainerElement was returning the wrong object causing some NPEs. Change-Id: I403f139c9814e6b2bf61f684285d2b6d5cb88380 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1291156 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/resources/VmTable.java 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I403f139c9814e6b2bf61f684285d2b6d5cb88380 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: userportal: show fill in fields message
by tnisan＠redhat.com 19 Jan '16

19 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: userportal: show fill in fields message ...................................................................... userportal: show fill in fields message - Fixed when pressing enter without filling in the login fields you would see an error well without text. Change-Id: I5b1d345ff09268784241f0e775e52985c7e4f1ed Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1290350 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51816 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b1d345ff09268784241f0e775e52985c7e4f1ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: auto-scroll SetupNetworks interfaces list during d...
by awels＠redhat.com 19 Jan '16

19 Jan '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: auto-scroll SetupNetworks interfaces list during drag-and-drop ...................................................................... webadmin: auto-scroll SetupNetworks interfaces list during drag-and-drop When a host has more the 6 network interfaces, the Setup Host Networks popup dialog needs to scroll to access all of the interfaces. During a drag-and-drop of a logical network or network label, the interface list did not allow scrolling. This patch adds auto-scroll handling so a user can access all of the host's available interfaces. To auto-scroll the interfaces list: 1. start a drag operation on a logical network, label or interface 2. move the mouse pointer close to the top of the interface list to auto scroll the list down 3. move the mouse pointer close to the bottom of the interface list to auto scroll the list up Scroll will stop when the drag operation is complete or the mouse is moved outside the autoscroll zone. Change-Id: I2c6fe977f014309659d5559d4609d9361a43274e Bug-Url: https://bugzilla.redhat.com/1249895 Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com> --- A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/AutoScrollAdapter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/AutoScrollDisableEvent.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/AutoScrollEnableEvent.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/AutoScrollOverEvent.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java 6 files changed, 315 insertions(+), 17 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Scott Dickerson: Verified -- To view, visit https://gerrit.ovirt.org/51731 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c6fe977f014309659d5559d4609d9361a43274e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.6]: Add missing parentheses to function call
by dougsland＠redhat.com 19 Jan '16

19 Jan '16

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: Add missing parentheses to function call ...................................................................... Add missing parentheses to function call self.application.plugins() is a method, not a property Change-Id: Ia990566705574e873cfd6eb5deefdcb329acecc9 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/51910 Continuous-Integration: Jenkins CI Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com> Reviewed-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Continuous-Integration: Douglas Schilling Landgraf <dougsland(a)redhat.com> Tested-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> (cherry picked from commit c2c88f32c78950eef64e832207676b0410462224) Reviewed-on: https://gerrit.ovirt.org/52371 --- M src/engine_page.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia990566705574e873cfd6eb5deefdcb329acecc9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.6]: Check for Hosted Engine in self.application.plugins
by dougsland＠redhat.com 19 Jan '16

19 Jan '16

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: Check for Hosted Engine in self.application.plugins ...................................................................... Check for Hosted Engine in self.application.plugins We cannot call hosted_engine_page.Plugin() directly (needs app as an argument), nor call we call it with app (already registered). Iterate through the plugins in the application and check from there. Change-Id: Ia375098593b827b7406ffedecc1763bc7da7a1b8 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1258397 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/51825 Continuous-Integration: Jenkins CI Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com> (cherry picked from commit 34e05aec54bb025ec342a1ce8f72de35275e72bf) Reviewed-on: https://gerrit.ovirt.org/52370 Reviewed-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Continuous-Integration: Douglas Schilling Landgraf <dougsland(a)redhat.com> Tested-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia375098593b827b7406ffedecc1763bc7da7a1b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-node-plugin-vdsm[master]: Add missing parentheses to function call
by dougsland＠redhat.com 19 Jan '16

19 Jan '16

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: Add missing parentheses to function call ...................................................................... Add missing parentheses to function call self.application.plugins() is a method, not a property Change-Id: Ia990566705574e873cfd6eb5deefdcb329acecc9 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/51910 Continuous-Integration: Jenkins CI Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com> Reviewed-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Continuous-Integration: Douglas Schilling Landgraf <dougsland(a)redhat.com> Tested-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests Fabian Deutsch: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia990566705574e873cfd6eb5deefdcb329acecc9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: short cycle for vm that disappeared
by ahadas＠redhat.com 18 Jan '16

18 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: short cycle for vm that disappeared ...................................................................... core: short cycle for vm that disappeared Handle VMs that are not reported by VDSM first in the VM analyzer. This change simplifies checks that are done in the analysis later on. Change-Id: I66ec7e239ed0db74cb0bf44d1cf683fa630550b7 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 1 file changed, 135 insertions(+), 140 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51930 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66ec7e239ed0db74cb0bf44d1cf683fa630550b7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fetch vm dynamic info from vm analyzers
by ahadas＠redhat.com 18 Jan '16

18 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fetch vm dynamic info from vm analyzers ...................................................................... core: fetch vm dynamic info from vm analyzers Change the way VmsMonitoring fetches VM dynamic info from VM analyzers: iterate the analyzers using the stream API and get the dynamic info instead of the statistics being set inside VmsMonitoring by the analyzers. Note that the added code for processVmsWithDevicesChange is not as efficient as it used to be, but the process of extracting the handling of the devices from VmsMonitoring is in progress and is expected to change this code anyway. Change-Id: I4aa8e5a2778c0aae85644043b3a1530970a862eb Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmAnalyzerTest.java 3 files changed, 29 insertions(+), 25 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/51692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4aa8e5a2778c0aae85644043b3a1530970a862eb Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0