November 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi : Add manual execution of 'Check for upgrades'
by Code Review 22 Nov '16

22 Nov '16

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: restapi : Add manual execution of 'Check for upgrades' ...................................................................... restapi : Add manual execution of 'Check for upgrades' Add a manual check for upgrades in restapi to trigger checking for host upgrade packages. Change-Id: Ie5827e86cc860c116133ae90ce315617b4a5f011 Bug-Url: https://bugzilla.redhat.com/1279378 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62348 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5827e86cc860c116133ae90ce315617b4a5f011 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add new web application for documentation
by Code Review 22 Nov '16

22 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add new web application for documentation ...................................................................... restapi: Add new web application for documentation This patchs adds a new 'apidoc.war' web application that will contain the documentation of the API. This application will be accessible via the '/ovirt-engine/apidoc' URL and it won't require authentication. Change-Id: I7043f117cfeb7d2967b563feae7aebcf3b0ec04f Related-To: https://bugzilla.redhat.com/1386508 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile A backend/manager/modules/restapi/apidoc/exclude-filters.xml A backend/manager/modules/restapi/apidoc/pom.xml A backend/manager/modules/restapi/apidoc/src/main/webapp/WEB-INF/jboss-web.xml A backend/manager/modules/restapi/apidoc/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/restapi/pom.xml M ovirt-engine.spec.in M packaging/services/ovirt-engine/ovirt-engine.conf.in 8 files changed, 142 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Alexander Wels: Looks good to me, but someone else must approve Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/67172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7043f117cfeb7d2967b563feae7aebcf3b0ec04f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: README: add hint to build for specific locale
by Code Review 22 Nov '16

22 Nov '16

>From Martin Betak <mbetak(a)redhat.com>: Martin Betak has submitted this change and it was merged. Change subject: README: add hint to build for specific locale ...................................................................... README: add hint to build for specific locale Change-Id: I220da6b1c86bc10d92ba1d96a9bfc5ef538e151e Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M README.adoc 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Dominik Holler: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/67163 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I220da6b1c86bc10d92ba1d96a9bfc5ef538e151e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[master]: storage: remove _customize_mnt_options for iSCSI/FC
by Code Review 22 Nov '16

22 Nov '16

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: storage: remove _customize_mnt_options for iSCSI/FC ...................................................................... storage: remove _customize_mnt_options for iSCSI/FC Custom mount options are not supported on iSCSI and FC. Change-Id: I7bc5b1d8aa07061f7c767e718b077084168edf38 Bug-Url: https://bugzilla.redhat.com/1397305 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/gr-he-setup/storage/blockd.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/67159 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bc5b1d8aa07061f7c767e718b077084168edf38 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: cleanup: Fix message and use relevant try scope.
by Code Review 22 Nov '16

22 Nov '16

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: cleanup: Fix message and use relevant try scope. ...................................................................... cleanup: Fix message and use relevant try scope. Fix debug message and remove variables decleration from the try scope Change-Id: I6fac62389de4b552367899467d8f50e08815a514 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/66953 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fac62389de4b552367899467d8f50e08815a514 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Update qcow images with qcow_compat at endAction.
by Code Review 22 Nov '16

22 Nov '16

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Update qcow images with qcow_compat at endAction. ...................................................................... core: Update qcow images with qcow_compat at endAction. Update the image with the appropriate qcow_compat returned from VDSM. Change-Id: Ie5cda1318bd966fc9c9e1ff57bc524ea539bb1bc Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/66951 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5cda1318bd966fc9c9e1ff57bc524ea539bb1bc Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add support for QemuImageInfo in ImagesHandler
by Code Review 22 Nov '16

22 Nov '16

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add support for QemuImageInfo in ImagesHandler ...................................................................... core: Add support for QemuImageInfo in ImagesHandler Add a helper method to fetch QemuImageInfo Change-Id: Idf18fead0f01a61f0666bc74b0ae737b8c0dbdc1 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/67007 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf18fead0f01a61f0666bc74b0ae737b8c0dbdc1 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add support for image prepare and teardown
by Code Review 22 Nov '16

22 Nov '16

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add support for image prepare and teardown ...................................................................... core: Add support for image prepare and teardown Add helper methods at images handler for prepare and teardown. Change-Id: I74ec2883009658c6f30b637fa90fc51f563921ea Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java 1 file changed, 31 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/67082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74ec2883009658c6f30b637fa90fc51f563921ea Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Introduce QemuImageInfo
by Code Review 22 Nov '16

22 Nov '16

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Introduce QemuImageInfo ...................................................................... core: Introduce QemuImageInfo QemuImageInfo returns the information returned from VDSM getQemuImageInfo. QemuImageInfo wraps QemuimgInfo to assign the appropriate host to execute the operation. Change-Id: I6f79f1258e6b2dc81c48fe8db793173af5abe976 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/QemuImageInfo.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/QemuVolumeFormat.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetQemuImageInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/QemuImageInfoReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 9 files changed, 255 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/66950 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f79f1258e6b2dc81c48fe8db793173af5abe976 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Adjust OVF reader and writer with the qcow compat.
by Code Review 22 Nov '16

22 Nov '16

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Adjust OVF reader and writer with the qcow compat. ...................................................................... core: Adjust OVF reader and writer with the qcow compat. Update Ovf reader and writer and their tests with the new qcow compat field. Change-Id: I02b8a7eac4e057ae8ceeed22dfa55cf7c753b717 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 3 files changed, 14 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02b8a7eac4e057ae8ceeed22dfa55cf7c753b717 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0