Change in ovirt-engine-sdk-java[sdk_3.6]: sdk: Regenerate against the latest API
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Regenerate against the latest API
......................................................................
sdk: Regenerate against the latest API
This patch regenerates the SDK using the latest API obtained from
the engine built from commit 0238295, tag ovirt-engine-3.6.10.
Change-Id: I3fb590055081bdef63b053fe1b42a65a1b17c645
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/pom.xml
M generator/src/main/resources/rsdl.xml
M sdk/src/main/java/org/ovirt/engine/sdk/decorators/Cluster.java
M sdk/src/main/java/org/ovirt/engine/sdk/decorators/StorageConnection.java
4 files changed, 117 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/66349
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3fb590055081bdef63b053fe1b42a65a1b17c645
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.6
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-hosted-engine-setup[master]: timezone: improving errors handling
by Code Review
>From Simone Tiraboschi <stirabos(a)redhat.com>:
Simone Tiraboschi has submitted this change and it was merged.
Change subject: timezone: improving errors handling
......................................................................
timezone: improving errors handling
Change-Id: I24765f7ff4eaf9474585446fe1c66d09048b01a2
Bug-Url: https://bugzilla.redhat.com/1318350
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/gr-he-common/vm/cloud_init.py
1 file changed, 22 insertions(+), 8 deletions(-)
Approvals:
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/66301
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24765f7ff4eaf9474585446fe1c66d09048b01a2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: Propagate UpdateVm failure to UpdateClusterCommand
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: Propagate UpdateVm failure to UpdateClusterCommand
......................................................................
core: Propagate UpdateVm failure to UpdateClusterCommand
When changing cluster compatibility version with UpdateClusterCommand,
UpdateVmCommand is called for every VM in the cluster. If
UpdateVmCommand fails, failure details are not propagated to
UpdateClusterCommand and the failure is displayed to user as generic
"Internal error".
The patch fixes this issue.
Change-Id: Ib68f691db5027106c582ed6ecd2d53c7d82e3454
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373573
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/66205
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib68f691db5027106c582ed6ecd2d53c7d82e3454
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: Remove space check when restoring a snapshot
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove space check when restoring a snapshot
......................................................................
core: Remove space check when restoring a snapshot
When a snapshot is restored the old leaves are discarded. This is NOT
a merge operation, just a remove volume call.
As such, it does not require any additional storage, and these
validations should be removed.
Change-Id: Icf459dd5f49d4d90c74de5e7314d3792419d69b4
Bug-Url: https://bugzilla.redhat.com/1390072
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommandTest.java
2 files changed, 0 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/66324
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf459dd5f49d4d90c74de5e7314d3792419d69b4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: @Inject GetTemplateInterfacesByTemplateIdQuery Daos
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: @Inject GetTemplateInterfacesByTemplateIdQuery Daos
......................................................................
core: @Inject GetTemplateInterfacesByTemplateIdQuery Daos
@Inject the DAOs instead of explicitly getting them from DbFacade.
Change-Id: I9525b83f981ec96284845590c890763b1444b96d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/GetTemplateInterfacesByTemplateIdQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/template/GetTemplateInterfacesByTemplateIdQueryTest.java
2 files changed, 11 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/66314
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9525b83f981ec96284845590c890763b1444b96d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: @Inject GetTemplatesByVnicProfileIdQuery Daos
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: @Inject GetTemplatesByVnicProfileIdQuery Daos
......................................................................
core: @Inject GetTemplatesByVnicProfileIdQuery Daos
@Inject the DAOs instead of explicitly getting them from DbFacade.
Change-Id: I71181f6b5c7eee3278fec5f9c1e829c8e961f50d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/GetTemplatesByVnicProfileIdQuery.java
1 file changed, 7 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/66315
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71181f6b5c7eee3278fec5f9c1e829c8e961f50d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: @Inject GetVmTemplatesAndNetworkInterfacesByNetworkIdQ...
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: @Inject GetVmTemplatesAndNetworkInterfacesByNetworkIdQuery Daos
......................................................................
core: @Inject GetVmTemplatesAndNetworkInterfacesByNetworkIdQuery Daos
@Inject the DAOs instead of explicitly getting them from DbFacade.
Change-Id: I2140714aa78808874e3af1a1b3adc83debbb82f0
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/GetVmTemplatesAndNetworkInterfacesByNetworkIdQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/template/GetVmTemplatesAndNetworkInterfacesByNetworkIdQueryTest.java
2 files changed, 20 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/66316
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2140714aa78808874e3af1a1b3adc83debbb82f0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-hosted-engine-setup[master]: ssh: enable ssh root login
by Code Review
>From Simone Tiraboschi <stirabos(a)redhat.com>:
Simone Tiraboschi has submitted this change and it was merged.
Change subject: ssh: enable ssh root login
......................................................................
ssh: enable ssh root login
Ask to the user about ssh login for the root user.
Ask an ssh pub key for the root user.
Change-Id: If1d2e274536558d057d48607a6400ce55abfa4e2
Bug-Url: https://bugzilla.redhat.com/1331858
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/gr-he-common/vm/cloud_init.py
2 files changed, 135 insertions(+), 9 deletions(-)
Approvals:
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/65817
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1d2e274536558d057d48607a6400ce55abfa4e2
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: webadmin: VM import layout
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: VM import layout
......................................................................
webadmin: VM import layout
- Updated import VM layout to use bootstrap
grid based layout instead of mashup of different
types of panels.
Change-Id: I747dcb7d276e419dbedb881a96401d1458ab1084
Bug-Url: https://bugzilla.redhat.com/1390271
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelWidgetWithInfo.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/VerticalSplitTable.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.ui.xml
4 files changed, 227 insertions(+), 258 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/66283
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I747dcb7d276e419dbedb881a96401d1458ab1084
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: backend: Remove needless CommandBase#getLockManager getter
by Code Review
>From Martin Betak <mbetak(a)redhat.com>:
Martin Betak has submitted this change and it was merged.
Change subject: backend: Remove needless CommandBase#getLockManager getter
......................................................................
backend: Remove needless CommandBase#getLockManager getter
Change-Id: I4104126008702e322141ba9b242c8334d8572dd2
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeSnapshotCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveImageCommand.java
12 files changed, 19 insertions(+), 23 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/66303
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4104126008702e322141ba9b242c8334d8572dd2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months