Change in jenkins[master]: adding missing vdsm builds for ppc64le
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: adding missing vdsm builds for ppc64le
......................................................................
adding missing vdsm builds for ppc64le
Also updated excludes for 4.1
Change-Id: I943892285be73cc33f257bbcc41100035784f4fd
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/projects/vdsm/vdsm_standard.yaml
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68993
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I943892285be73cc33f257bbcc41100035784f4fd
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-hosted-engine-setup[master]: he: Prevent last HE host from going to the local maintenance...
by Code Review
>From Simone Tiraboschi <stirabos(a)redhat.com>:
Simone Tiraboschi has submitted this change and it was merged.
Change subject: he: Prevent last HE host from going to the local maintenance mode.
......................................................................
he: Prevent last HE host from going to the local maintenance mode.
Checks, if there are other hosts capable to host engine VM
and cancels LocalMaintenance mode in case there are no hosts
for it.
Change-Id: I6964d773ab95d3ccd9bf3a73fe27b99849d7d2d2
Bug-Url: https://bugzilla.redhat.com/1394570
Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/set_maintenance.py
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Denis Chaplygin: Verified
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, but someone else must approve
Simone Tiraboschi: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67273
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6964d773ab95d3ccd9bf3a73fe27b99849d7d2d2
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in jenkins[master]: ovirt-appliance: add check and manual jobs
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-appliance: add check and manual jobs
......................................................................
ovirt-appliance: add check and manual jobs
Added check-patch, check-merged and build-manual
jobs to ease the testing of the patches
Change-Id: I58db5a763240796a2fb795232beb31487f9901fd
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt-appliance/ovirt-appliance.yaml
1 file changed, 38 insertions(+), 7 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68970
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I58db5a763240796a2fb795232beb31487f9901fd
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0]: core: DeactivateStorageDomainWithOvfUpdate - context passing
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: DeactivateStorageDomainWithOvfUpdate - context passing
......................................................................
core: DeactivateStorageDomainWithOvfUpdate - context passing
Currently DeactivateStorageDomainWithOvfUpdate passes its compensation
context to the executed DeactivateStorageDomain command.
When passing the compensation context along the hirerchy, it was decided
in BZ 1364804 that the reponsiblity to revert the compensation data is on
the parent command.
DeactivateStorageDomainWithOvfUpdate is always succesfull (so is its
end methods) - and therefore in case of error in the child command
execution the compensation context isn't reverted which causes the domain
to remain locked.
This patch solves that by not passing the context to the executed
command - so it will have a compensation context of its own.
Change-Id: Iebbb3084d52c7744d1f92a98c31d3a3c916e6e03
Bug-Url: https://bugzilla.redhat.com/1405772
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainWithOvfUpdateCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/68965
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebbb3084d52c7744d1f92a98c31d3a3c916e6e03
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0]: vdsbroker: mark vds as spm candidate before connectStoragePool
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: vdsbroker: mark vds as spm candidate before connectStoragePool
......................................................................
vdsbroker: mark vds as spm candidate before connectStoragePool
When we assign the spm role we first perform connectStoragePool()
to make sure that the host has the latest pool metadata.
If connectStoragePool fails on the master domain being unavailable
we'll attempt to perform failover (start the spm on a different host)
if there are more hosts in the data center. When there are no more
candidate hosts for the spm role reconstruct will be performed.
Because the failure is on the connect operation, the host won't be
marked as the current candidate for the spm rule which will prevent
failover from running, causing for reconstruct to not be executed.
Change-Id: I65a44d9c42782ea27aa257e5b53ccb70c9dbcca8
Bug-Url: https://bugzilla.redhat.com/1397861
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/68964
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65a44d9c42782ea27aa257e5b53ccb70c9dbcca8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: core: DeactivateStorageDomainWithOvfUpdate - context passing
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: DeactivateStorageDomainWithOvfUpdate - context passing
......................................................................
core: DeactivateStorageDomainWithOvfUpdate - context passing
Currently DeactivateStorageDomainWithOvfUpdate passes its compensation
context to the executed DeactivateStorageDomain command.
When passing the compensation context along the hirerchy, it was decided
in BZ 1364804 that the reponsiblity to revert the compensation data is on
the parent command.
DeactivateStorageDomainWithOvfUpdate is always succesfull (so is its
end methods) - and therefore in case of error in the child command
execution the compensation context isn't reverted which causes the domain
to remain locked.
This patch solves that by not passing the context to the executed
command - so it will have a compensation context of its own.
Change-Id: Iebbb3084d52c7744d1f92a98c31d3a3c916e6e03
Bug-Url: https://bugzilla.redhat.com/1405772
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainWithOvfUpdateCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/68932
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebbb3084d52c7744d1f92a98c31d3a3c916e6e03
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: vdsbroker: mark vds as spm candidate before connectStoragePool
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: vdsbroker: mark vds as spm candidate before connectStoragePool
......................................................................
vdsbroker: mark vds as spm candidate before connectStoragePool
When we assign the spm role we first perform connectStoragePool()
to make sure that the host has the latest pool metadata.
If connectStoragePool fails on the master domain being unavailable
we'll attempt to perform failover (start the spm on a different host)
if there are more hosts in the data center. When there are no more
candidate hosts for the spm role reconstruct will be performed.
Because the failure is on the connect operation, the host won't be
marked as the current candidate for the spm rule which will prevent
failover from running, causing for reconstruct to not be executed.
Change-Id: I65a44d9c42782ea27aa257e5b53ccb70c9dbcca8
Bug-Url: https://bugzilla.redhat.com/1397861
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxy.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/68931
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65a44d9c42782ea27aa257e5b53ccb70c9dbcca8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: replace vague error message with specific ones.
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: replace vague error message with specific ones.
......................................................................
core: replace vague error message with specific ones.
Split 'inexisting network attachment' into 3 different failures
diferentiating upon action requested to be done with them.
Change-Id: If99e5feab8a97b355f3b3da964cc16a48282809d
Bug-Url: https://bugzilla.redhat.com/1324482
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 29 insertions(+), 44 deletions(-)
Approvals:
Marcin Mirecki: Looks good to me, but someone else must approve
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/61193
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If99e5feab8a97b355f3b3da964cc16a48282809d
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik <Dominik.Holler(a)gmx.net>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: webadmin: hide "Read Only" checkbox when selecting IDE inter...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: hide "Read Only" checkbox when selecting IDE interface
......................................................................
webadmin: hide "Read Only" checkbox when selecting IDE interface
Change-Id: I85ecb559ca96e94fc7aa5c1f93c227da75931ba9
Bug-Url: https://bugzilla.redhat.com/1347113
Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Benny Zlotnik: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68915
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I85ecb559ca96e94fc7aa5c1f93c227da75931ba9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Release mac addresses on detach SD or remove DC.
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Release mac addresses on detach SD or remove DC.
......................................................................
core: Release mac addresses on detach SD or remove DC.
Release mac addresses from memory once VMs are being removed as part of
the detach process.
Change-Id: I95c0008c0a91ccd5aba924d8b2f5a4904268c2f3
Bug-Url: https://bugzilla.redhat.com/1405761
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DetachStorageDomainFromPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java
3 files changed, 35 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/68920
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95c0008c0a91ccd5aba924d8b2f5a4904268c2f3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months