December 2016 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: core: Fix unicast MAC address validation
by Code Review 22 Dec '16

22 Dec '16

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: core: Fix unicast MAC address validation ...................................................................... core: Fix unicast MAC address validation Change-Id: Id14c6e23dcb8f68c2242a4715bf1344f0f0186bd Bug-url: https://bugzilla.redhat.com/1406415 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> (cherry picked from commit 4b80941ac468d78b04e0c8513b8d1c214ff6f572) --- M src/ovirt_hosted_engine_setup/util.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Simone Tiraboschi: Looks good to me, approved Ido Rosenzwig: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68985 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id14c6e23dcb8f68c2242a4715bf1344f0f0186bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.1 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: std ci: add notification plugin to standard CI
by Code Review 22 Dec '16

22 Dec '16

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: std ci: add notification plugin to standard CI ...................................................................... std ci: add notification plugin to standard CI Needed to support GetBadgets integration With Jenkins. Might be used in the future to capture jenkins events for reporting. Change-Id: I2f95b2a70933b5bf8f1f16edc135893c0898848e Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/yaml/templates/standard-stage.yaml 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f95b2a70933b5bf8f1f16edc135893c0898848e Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: core: Fix unicast MAC address validation
by Code Review 22 Dec '16

22 Dec '16

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: core: Fix unicast MAC address validation ...................................................................... core: Fix unicast MAC address validation Change-Id: Id14c6e23dcb8f68c2242a4715bf1344f0f0186bd Bug-url: https://bugzilla.redhat.com/1406415 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M src/ovirt_hosted_engine_setup/util.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, approved Ido Rosenzwig: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id14c6e23dcb8f68c2242a4715bf1344f0f0186bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add new vdsm branch ovirt-4.1 to automation checks
by Code Review 22 Dec '16

22 Dec '16

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Add new vdsm branch ovirt-4.1 to automation checks ...................................................................... Add new vdsm branch ovirt-4.1 to automation checks Change-Id: I38cea06877d2484193f846a4e4f7c541215a4f32 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M jobs/confs/projects/vdsm/vdsm_standard.yaml 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68984 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38cea06877d2484193f846a4e4f7c541215a4f32 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Prevent the usage of spaces in the NFS path
by Code Review 22 Dec '16

22 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Prevent the usage of spaces in the NFS path ...................................................................... webadmin: Prevent the usage of spaces in the NFS path Add the NoSpacesValidation validation to NfsStorageModel.validate() in order to prevent users form entering spaces in the Export Path field in the "New Domain" window. Change-Id: Id2319ceb7883b7316c8568a30efbbe64ac97a99b Bug-Url: https://bugzilla.redhat.com/1323663 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Benny Zlotnik: Verified Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67658 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2319ceb7883b7316c8568a30efbbe64ac97a99b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Prevent users from using spaces in NFS paths
by Code Review 22 Dec '16

22 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Prevent users from using spaces in NFS paths ...................................................................... core: Prevent users from using spaces in NFS paths Add a check to make sure no spaces are present in the NFS mount path when adding a new storage domain Change-Id: Ib7f5c9accfec262e774be7fbb1ea086a38b7958c Bug-Url: https://bugzilla.redhat.com/1323663 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NfsMountPointConstraint.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/NFSMountPointConstraintTest.java 3 files changed, 8 insertions(+), 1 deletion(-) Approvals: Benny Zlotnik: Verified Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67843 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7f5c9accfec262e774be7fbb1ea086a38b7958c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: add error indication to invalid VM name
by Code Review 22 Dec '16

22 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: add error indication to invalid VM name ...................................................................... webadmin: add error indication to invalid VM name When importing a VM there was no indication of an invalid VM name in the general sub tab, this patch adds a highlight with the information in the tooltip by changing the UI element to StringEntityModelTextBoxOnlyEditor which has validation unlike the previous TextBoxChanger. Change-Id: Ia6484840460ea05f8e186f410b89c58b39d0d79d Bug-Url: https://bugzilla.redhat.com/1403578 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmImportGeneralModelForm.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java 2 files changed, 14 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Benny Zlotnik: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68452 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6484840460ea05f8e186f410b89c58b39d0d79d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: rename variable to a meaningful name
by Code Review 22 Dec '16

22 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: rename variable to a meaningful name ...................................................................... webadmin: rename variable to a meaningful name tmp is now vmName Change-Id: Ie0c10c1f558413f785a60fa91d6816bc1100454a Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Benny Zlotnik: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0c10c1f558413f785a60fa91d6816bc1100454a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: change the default usb model
by Code Review 21 Dec '16

21 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: change the default usb model ...................................................................... core: change the default usb model The default usb model should be piix3-uhci that as opposed to ich9-ehci1 is supposed to work properly with usb devices that require USB-1.0 like smartcard. Change-Id: Ibf9cd1f564cb8d1da8e4a996f37d97d210ced7f9 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Michal Skrivanek: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/68923 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf9cd1f564cb8d1da8e4a996f37d97d210ced7f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Fix bugs in sdk yamls
by Code Review 21 Dec '16

21 Dec '16

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Fix bugs in sdk yamls ...................................................................... Fix bugs in sdk yamls Added check patch and check merged for new SDK V4 projects Removed unneeded V3 check patch and check merged for 4.0 and master Fixed bug of build artifacts in sdk java. They were triggering after a python code had been changed Change-Id: Ib43595aa6c1766a18006baec272fe6b6bedac972 --- M jobs/confs/projects/ovirt-engine-sdk-java/ovirt-engine-sdk-java_build-artifacts.yaml M jobs/confs/projects/ovirt-engine-sdk/ovirt-engine-sdk_build-artifacts.yaml M jobs/confs/yaml/templates/standard-stage.yaml 3 files changed, 104 insertions(+), 10 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Gil Shinar: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib43595aa6c1766a18006baec272fe6b6bedac972 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0