Change in ovirt-engine[master]: webadmin: Remove disk read only changeability in AbstractDis...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Remove disk read only changeability in AbstractDiskModel
......................................................................
webadmin: Remove disk read only changeability in AbstractDiskModel
Since commit 9f332f38 the readonly field is not displayed when selecting
IDE interface thus changing the changeability is pointless
Change-Id: I97d5392b6cb10af7873a2fc9843c9b22b15773fb
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Benny Zlotnik: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/68907
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97d5392b6cb10af7873a2fc9843c9b22b15773fb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0]: userportal: create/attach disks from new VM does nothing
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: userportal: create/attach disks from new VM does nothing
......................................................................
userportal: create/attach disks from new VM does nothing
Regression introduced by Ieb1f07fceeff0b7975dc8ab51eab625c38d77fdd
It fixed the issue for webadmin but the userportal has been forgotten.
This patch fixes it for user portal as well. This particular fix is only a
hotfix, the proper solution is proposed to master
(https://gerrit.ovirt.org/#/c/67532/).
Change-Id: I59b648ba9da627cd70b6a1d5d1dde8d3082c3147
Bug-Url: https://bugzilla.redhat.com/1406042
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/UserPortalListProvider.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/TemplateModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java
6 files changed, 98 insertions(+), 20 deletions(-)
Approvals:
Tomas Jelinek: Verified
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68861
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59b648ba9da627cd70b6a1d5d1dde8d3082c3147
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in gerrit-admin[master]: Fix change bug status in set_modified hook
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: Fix change bug status in set_modified hook
......................................................................
Fix change bug status in set_modified hook
There is no need to change the bug status to MODIFIED
for 'master' branch.
Change-Id: Idf7538be3df1e8e04ce4fa3358e492c2394ba596
Fixes: OVIRT-947
Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com>
---
M hooks/custom_hooks/set_modified
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Shlomo Ben David: Verified
Eyal Edri: Looks good to me, approved
Gil Shinar: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68853
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf7538be3df1e8e04ce4fa3358e492c2394ba596
Gerrit-PatchSet: 1
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
7 years, 4 months
Change in ovirt-engine[master]: core: auto start vms with lease
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: auto start vms with lease
......................................................................
core: auto start vms with lease
When detecting that a host is non-responsive we move the VMs that
are supposed to run on that host to Unknown status. This patch
adds to that a special treatment for VMs with leases: for each
VM with a lease, we will try to run the VM on another host.
The lease should prevent us from getting a split-brain. However,
we do not want to try to run the VM on each vds monitoring cycle
(which is by default every 3 seconds) so we define a config value
for setting the frequency of those attempts.
Note that when host becomes non-responsive we get network exceptions
from several places:
1. calls to refresh host capabilities.
2. calls to poll vms (on statistics iterations).
3. every command that interacts with vdsm.
As a result, VdsManager#restartVmsWithLeaseIfNeeded may be called
simultaneously from several threads and that may cause us to skip
a restart attempt. Thus, adding a lock to ensure mutually exclusive
execution of that method.
Change-Id: I464f14fe953a6fedfa53d6655eeb31965b5f1579
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
5 files changed, 57 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/68361
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I464f14fe953a6fedfa53d6655eeb31965b5f1579
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Add links to disk storage domains
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Add links to disk storage domains
......................................................................
restapi: Add links to disk storage domains
Currently the server doesn't add links to the elements of the
'disk.storage_domains' list. This happens because the 'LinkHelper'
doesn't take into account that elements of lists may also need links. To
avoid that issue this patch changes the disks resource so that it adds
those links explicitly.
Change-Id: I1243ff5e164c807d06868de812a291cf2034c074
Bug-Url: https://bugzilla.redhat.com/1406064
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit b639543c04ecf1d4a49a67d40c70a519e07c3adc)
(cherry picked from commit 79c5d6c855bc517781a731afcd1478a8afc92b67)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java
2 files changed, 29 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68905
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1243ff5e164c807d06868de812a291cf2034c074
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Use ids to calculate intersections
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Use ids to calculate intersections
......................................................................
restapi: Use ids to calculate intersections
Currently when the user uses together the 'filter' and 'search'
mechanisms, the server performs two queries: one with filter only, and
one with search only. Then the it calculates and returns the
intersection. But this intersection is calculated assuming that the
objects returned by both queries can be reliably compared using the
'equals' methods. This isn't true, in general. The net result is that
many times the intersection is empty, when it should't. To avoid that
issue this patch changes the server so that it compares the objects by
id, instead of using the 'equals' method.
Change-Id: Id6fd395ca3d3aea7ab2dcdcdf2438e4c487cfc1f
Bug-Url: https://bugzilla.redhat.com/1402799
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit b1040767587db36211115f156f6dd93ef3fcf2de)
(cherry picked from commit 3c85ebf8f5d98639218307848ea19265651841fb)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java
1 file changed, 49 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68904
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6fd395ca3d3aea7ab2dcdcdf2438e4c487cfc1f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: core: vm.vmStatic.maxMemorySizeMb is None
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: vm.vmStatic.maxMemorySizeMb is None
......................................................................
core: vm.vmStatic.maxMemorySizeMb is None
this is regression from patch:
https://gerrit.ovirt.org/#/c/67747
Change-Id: I3aef340a4dc9277aa26eb75b61111631b577ad1d
Bug-Url: https://bugzilla.redhat.com/1406304
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Shahar Havivi: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/68890
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3aef340a4dc9277aa26eb75b61111631b577ad1d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: userportal: create/attach disks from new VM does nothing
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: userportal: create/attach disks from new VM does nothing
......................................................................
userportal: create/attach disks from new VM does nothing
Regression introduced by Ieb1f07fceeff0b7975dc8ab51eab625c38d77fdd
It fixed the issue for webadmin but the userportal has been forgotten.
This patch fixes it for user portal as well. This particular fix is only a
hotfix, the proper solution is proposed to master
(https://gerrit.ovirt.org/#/c/67532/).
Change-Id: I59b648ba9da627cd70b6a1d5d1dde8d3082c3147
Bug-Url: https://bugzilla.redhat.com/1406042
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/UserPortalListProvider.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/TemplateModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java
6 files changed, 98 insertions(+), 20 deletions(-)
Approvals:
Tomas Jelinek: Verified
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68862
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59b648ba9da627cd70b6a1d5d1dde8d3082c3147
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: Release mac addresses on detach SD or remove DC.
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Release mac addresses on detach SD or remove DC.
......................................................................
core: Release mac addresses on detach SD or remove DC.
Release mac addresses from memory once VMs are being removed as part of
the detach process.
Change-Id: I95c0008c0a91ccd5aba924d8b2f5a4904268c2f3
Bug-Url: https://bugzilla.redhat.com/1405761
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DetachStorageDomainFromPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java
3 files changed, 35 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/68796
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95c0008c0a91ccd5aba924d8b2f5a4904268c2f3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: add vm lease on add/edit/import vm
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: add vm lease on add/edit/import vm
......................................................................
core: add vm lease on add/edit/import vm
Add VM lease in the following flows:
Add VM - if we fail to create the lease the VM is not added.
Import VM - if we fail to create the lease, the VM is imported without lease.
Edit VM - if we fail to create the lease, the VM is not updated. Note that
even if we fail to remove the previous lease, we proceed with the update.
Change-Id: I7c666a17d664c2b73ea7cfef10987f12b2bc1b5c
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
7 files changed, 58 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Arik Hadas: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68110
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c666a17d664c2b73ea7cfef10987f12b2bc1b5c
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months