February 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: add code setting storage pool id in DetachNetworkFromV...
by alkaplan＠redhat.com 04 Feb '16

04 Feb '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: add code setting storage pool id in DetachNetworkFromVdsInterfaceCommand ...................................................................... core: add code setting storage pool id in DetachNetworkFromVdsInterfaceCommand DetachNetworkFromVdsInterfaceCommand does not initialize storagePoolId property defined in CommandBase. So when method: org.ovirt.engine.core.bll.CommandBase#getMacPool is called, it will find: org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogableBase#getStoragePoolId to be null. Which causes MacPool not be found for null-valued datacenter. Change-Id: I2bd3d7bcb8a6bbd667d9bbde6658a8746f195692 Bug-Url: https://bugzilla.redhat.com/1299630 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Marcin Mirecki: Looks good to me, but someone else must approve Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bd3d7bcb8a6bbd667d9bbde6658a8746f195692 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: serialization/deserialization of SnapshotType
by tnisan＠redhat.com 04 Feb '16

04 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core: serialization/deserialization of SnapshotType ...................................................................... core: serialization/deserialization of SnapshotType Because of the toString() implementation of SnapshotType (which is used in returned messages) its deserialization is broken. This patch fixes the serialization issue, as this code seems unneeded to me I've removed it in change I8fb722dd15f0ccc2ac058765bfd6802a2a21134c. This patch just fixes the serialization is it should be backported to the 3.6 branch and I'd like to minimize the changes and testing scope there. Change-Id: Iee7192bd4e3bdf0b56ee57d4b25c5fcc17190be7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1303840 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/53067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee7192bd4e3bdf0b56ee57d4b25c5fcc17190be7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: CreateAllSnapshotsFromVmCommand - use snapshot type fr...
by tnisan＠redhat.com 04 Feb '16

04 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core: CreateAllSnapshotsFromVmCommand - use snapshot type from params ...................................................................... core: CreateAllSnapshotsFromVmCommand - use snapshot type from params When CreateAllSnapshotsFromVmCommand is executed the snapshot type from the parameters is used if the execution is internal, otherwise a default value is used and set to the parameters. This change removes that code and sets a default value in the parameters class. Change-Id: I66d50e6189e7facfab26317e1c3270107903410e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1303840 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllSnapshotsFromVmParameters.java 2 files changed, 1 insertion(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/53066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66d50e6189e7facfab26317e1c3270107903410e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-3.6]: build: don't check for specific version of livecd-tools
by sbonazzo＠redhat.com 04 Feb '16

04 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: don't check for specific version of livecd-tools ...................................................................... build: don't check for specific version of livecd-tools Change-Id: I51f1e4d5aa3e90aad04f6fdb2c28a58a6111ccb7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51f1e4d5aa3e90aad04f6fdb2c28a58a6111ccb7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: build: don't check for specific version of livecd-tools
by sbonazzo＠redhat.com 04 Feb '16

04 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: don't check for specific version of livecd-tools ...................................................................... build: don't check for specific version of livecd-tools Change-Id: I51f1e4d5aa3e90aad04f6fdb2c28a58a6111ccb7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51f1e4d5aa3e90aad04f6fdb2c28a58a6111ccb7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: v2v - add support for importing Xen VMs
by shavivi＠redhat.com 04 Feb '16

04 Feb '16

Shahar Havivi has submitted this change and it was merged. Change subject: core: v2v - add support for importing Xen VMs ...................................................................... core: v2v - add support for importing Xen VMs Change-Id: I245ac0c08c7b4cd618236279720c9ac5e41bddf7 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromExternalProviderCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmFromExternalProviderCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ConvertVmParameters.java 3 files changed, 31 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I245ac0c08c7b4cd618236279720c9ac5e41bddf7 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: call directly resetCompensation
by masayag＠redhat.com 04 Feb '16

04 Feb '16

Moti Asayag has submitted this change and it was merged. Change subject: core: call directly resetCompensation ...................................................................... core: call directly resetCompensation Removed check and clean is defined in DefaultCompensationContext, while no action variant is in NoOpCompensationContext. So direct call should be used. Bug-Url: https://bugzilla.redhat.com/1283062 Change-Id: I125caf76d20a44d4e8fddf0bc4d2d1739b14ae12 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I125caf76d20a44d4e8fddf0bc4d2d1739b14ae12 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VmOldInfoBuilder streaming
by amureini＠redhat.com 04 Feb '16

04 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: VmOldInfoBuilder streaming ...................................................................... core: VmOldInfoBuilder streaming Replace the outdated of Apache Commons Collections' Predicate with modern Java 8 streaming APIs to improve the code's readability and make it more standard. Change-Id: Iec52b1db149c8513ac3ff712aa553c6795718b49 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java 1 file changed, 1 insertion(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53044 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec52b1db149c8513ac3ff712aa553c6795718b49 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: VolumeBrickModel copy-paste mistake
by amureini＠redhat.com 04 Feb '16

04 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: VolumeBrickModel copy-paste mistake ...................................................................... webadmin: VolumeBrickModel copy-paste mistake VolumeBrickModel#validate should check the replica and stripe count, but a copy-paste error checks the replica count twice instead of checking both of them. This patch fixes the problem. This patch addresses Coverity CID 1201866. Change-Id: I0e3ee444755e3470695c0c9c4e0c3f5008edfba1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53046 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e3ee444755e3470695c0c9c4e0c3f5008edfba1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: vdsm-jsonrpc-java: add 3.6 branch
by dcaro＠redhat.com 03 Feb '16

03 Feb '16

David Caro has submitted this change and it was merged. Change subject: vdsm-jsonrpc-java: add 3.6 branch ...................................................................... vdsm-jsonrpc-java: add 3.6 branch Change-Id: Ia47a1ca36f99b1d23de64f9e5b1f7b149f09ec71 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml M jobs/confs/projects/vdsm-jsonrpc-java/vdsm-jsonrpc-java_standard.yaml 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Sandro Bonazzola: Looks good to me; Ready for review Jenkins CI: Passed CI tests David Caro: Ready for merge -- To view, visit https://gerrit.ovirt.org/53027 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia47a1ca36f99b1d23de64f9e5b1f7b149f09ec71 Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0