March 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: change template version of pool removed some vm devices
by piotr.kliczewski＠gmail.com 25 Mar '16

25 Mar '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: change template version of pool removed some vm devices ...................................................................... core: change template version of pool removed some vm devices The problem was the incorrect way of determining if the template has the device or not. Change-Id: I24df2494fb4a3d9945dccb9f3320cdd4976c8c5d Bug-Url: https://bugzilla.redhat.com/1281732 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55205 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24df2494fb4a3d9945dccb9f3320cdd4976c8c5d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Avoid UpdateVmDiskCommand for hosted engine Edit VM
by piotr.kliczewski＠gmail.com 25 Mar '16

25 Mar '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Avoid UpdateVmDiskCommand for hosted engine Edit VM ...................................................................... webadmin: Avoid UpdateVmDiskCommand for hosted engine Edit VM After OK in Edit VM Dialog of a hosted engine: - The UpdateVmDiskCommand is not called - Disk-edit buttons are disabled Change-Id: I4ffaa7725039d58f55e88ef22e586349323d70a9 Bug-Url: https://bugzilla.redhat.com/1311908 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImagesModel.java 3 files changed, 24 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Tomas Jelinek: Looks good to me, approved Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/55126 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ffaa7725039d58f55e88ef22e586349323d70a9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Added VmActionByVmOriginTypeValidator for Allowed Cmds
by piotr.kliczewski＠gmail.com 25 Mar '16

25 Mar '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: Added VmActionByVmOriginTypeValidator for Allowed Cmds ...................................................................... engine: Added VmActionByVmOriginTypeValidator for Allowed Cmds Refactoring of VmHandler. The COMMANDS_ALLOWED_ON_ moved from VmHandler to new VmActionByVmOriginTypeValidator, so they can be reused in UI. Change-Id: Iaf4fc340dd3b2ffdfa243f4f98307e255dee7651 Bug-Url: https://bugzilla.redhat.com/1311908 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/VmActionByVmOriginTypeValidator.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 3 files changed, 42 insertions(+), 23 deletions(-) Approvals: Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55125 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf4fc340dd3b2ffdfa243f4f98307e255dee7651 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: otopi: add standard ci on master
by sbonazzo＠redhat.com 25 Mar '16

25 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: otopi: add standard ci on master ...................................................................... otopi: add standard ci on master Change-Id: I7520f671c1415ea85fabb88098b9b492fcbb5ff8 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A jobs/confs/projects/otopi/otopi_standard.yaml 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7520f671c1415ea85fabb88098b9b492fcbb5ff8 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add V3 invalid value exception mapper
by juan.hernandez＠redhat.com 24 Mar '16

24 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add V3 invalid value exception mapper ...................................................................... restapi: Add V3 invalid value exception mapper The V3 adapters perform conversions from string to enums and the other way around, and they may fail. When this happens the exception isn't converted into a error message because the V3 application doesn't have any exception mapper registered. This patch adds a new invalid value exception mapper to V3. Change-Id: I750cc8e3b6cba95ff438b68da4522fdda3acdd57 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/V3Application.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/V3InvalidValueExceptionMapper.java 2 files changed, 39 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55232 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I750cc8e3b6cba95ff438b68da4522fdda3acdd57 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Use "fromValue" in V3 adapters
by juan.hernandez＠redhat.com 24 Mar '16

24 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use "fromValue" in V3 adapters ...................................................................... restapi: Use "fromValue" in V3 adapters The recent introduction of type safe enums in version 4 of the API introduced a regression in the V3 adapters. These adapters convert the strings used in V3 to the enums used in V4, but some of them do so using the "valueOf" method of the enum types, wich expects strings exactly equal to the enum values, and these values are all upper case. The API, both V3 and V4, should ignore case of the strings, which is achieved using the "fromValue" method. This changes all the V3 adapters to use the "fromValue" method. Change-Id: I0637285b60dc7030dcbfa65d97927978e05e839d Bug-Url: https://bugzilla.redhat.com/1320964 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3AgentConfigurationInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3CPUInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3ConfigurationInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DataCenterInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskSnapshotInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DisplayInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3EventInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3GlusterHookInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3GlusterServerHookInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3GlusterVolumeInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3GraphicsConsoleInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3GuestNicConfigurationInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3HardwareInformationInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3HostInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3HostNICInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3InstanceTypeInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3LogicalUnitInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3MethodInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3MigrationOptionsInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3NICInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3OpenStackNetworkProviderInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3OpenstackVolumeAuthenticationKeyInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3QoSInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3ReportedDeviceInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3SchedulingPolicyUnitInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3SnapshotInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3StepInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3StorageConnectionInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3StorageDomainInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3StorageInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VMInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmPoolInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VnicPassThroughInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3WatchDogInAdapter.java 35 files changed, 55 insertions(+), 55 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0637285b60dc7030dcbfa65d97927978e05e839d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: packaging: gettext: use 0.18.2 or latest
by didi＠redhat.com 24 Mar '16

24 Mar '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: packaging: gettext: use 0.18.2 or latest ...................................................................... packaging: gettext: use 0.18.2 or latest Use gettext 0.18.2 or newest: gettext 0.19.6 introduces a new macro, allowing to use latest gettext provided it's newer than requires See: https://lists.gnu.org/archive/html/bug-gettext/2015-08/msg00026.html - Solved: autoreconf: running: automake --add-missing --copy --force-missing configure.ac:39: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged. configure.ac:39: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead, configure.ac:39: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files. - ignore autogenerated intl directory - Drop requirement on GCC for having gettext support, we're using Python. Change-Id: I0a05eec912f7fff9fb3b4891b74e4e7253964afa Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .gitignore M configure.ac M otopi.spec.in M po/Makevars M po/POTFILES.in M po/pt_BR.po 6 files changed, 314 insertions(+), 269 deletions(-) Approvals: Sandro Bonazzola: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a05eec912f7fff9fb3b4891b74e4e7253964afa Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine-backup: use otopi-config-query instead of inline code
by sbonazzo＠redhat.com 24 Mar '16

24 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: engine-backup: use otopi-config-query instead of inline code ...................................................................... engine-backup: use otopi-config-query instead of inline code Change-Id: I2f4872a3cfe1fcb703346e7744c905462d3bed59 Bug-Url: https://bugzilla.redhat.com/1216888 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M ovirt-engine.spec.in M packaging/bin/engine-backup.sh.in 2 files changed, 6 insertions(+), 32 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/54945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f4872a3cfe1fcb703346e7744c905462d3bed59 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Fix jdk not being expanded
by sbonazzo＠redhat.com 24 Mar '16

24 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Fix jdk not being expanded ...................................................................... Fix jdk not being expanded It turns out that if the name collides with an existing element, it will not expand it if it's not set Change-Id: I111b61c7c72ac11c48418b92b34451883b63e72b Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-engine.yaml M jobs/confs/yaml/templates/engine-upgrade.yaml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Jenkins CI: Passed CI tests David Caro: Verified; Ready for review -- To view, visit https://gerrit.ovirt.org/55200 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I111b61c7c72ac11c48418b92b34451883b63e72b Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: automation: add Standard CI
by sbonazzo＠redhat.com 24 Mar '16

24 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: add Standard CI ...................................................................... automation: add Standard CI Change-Id: I5456412e0fc92e65825b47773d825e318af1a3ea Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A automation/build-artifacts.packages A automation/build-artifacts.repos A automation/build-artifacts.sh A automation/check-merged.packages A automation/check-merged.repos A automation/check-merged.sh A automation/check-patch.packages A automation/check-patch.repos A automation/check-patch.sh M ovirt-host-deploy.spec.in 10 files changed, 67 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55197 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5456412e0fc92e65825b47773d825e318af1a3ea Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0