March 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: change template version of pool removed some vm devices
by tjelinek＠redhat.com 24 Mar '16

24 Mar '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core: change template version of pool removed some vm devices ...................................................................... core: change template version of pool removed some vm devices The problem was the incorrect way of determining if the template has the device or not. Change-Id: I24df2494fb4a3d9945dccb9f3320cdd4976c8c5d Bug-Url: https://bugzilla.redhat.com/1281732 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24df2494fb4a3d9945dccb9f3320cdd4976c8c5d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Sessions in left tree was called 'Guest Information'
by tnisan＠redhat.com 24 Mar '16

24 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Sessions in left tree was called 'Guest Information' ...................................................................... webadmin: Sessions in left tree was called 'Guest Information' Regression introduced by: eefc4d0488fe43d4f11e40335253b5a358230878 The eefc4d0488fe43d4f11e40335253b5a358230878 have introduced a new subtab called "Guest Information" but accidentally have renamed the "Sessions" tree item to it. Change-Id: I3dd40329870f1786c460490a877f4bfb9ea38d3b Bug-Url: https://bugzilla.redhat.com/1318936 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55122 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3dd40329870f1786c460490a877f4bfb9ea38d3b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: prevent a race on add template version
by ahadas＠redhat.com 24 Mar '16

24 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: prevent a race on add template version ...................................................................... core: prevent a race on add template version When adding a template version, we add the quartz job and then mapping the ID of the base template to that job so we will be able to stop on-going updates of VMs to the latest version of the template. The problem is that we first "register" the quartz job and only then add it to the map (because we need to ID of the produced job). But when the job is being executed before the mapping is set, the VM updates will not take place. This patch suggests a simple fix - to add the template with null job before registering the quartz job, and update the mapping after the job is created. We should rewrite the mechanism that cancels on-going updates someday. Change-Id: I955a655f2eaef8510e3884e7895b9ca6cd0a6349 Bug-Url: https://bugzilla.redhat.com/1294511 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/55185 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I955a655f2eaef8510e3884e7895b9ca6cd0a6349 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: centos-7: Disable webadmin auto logout
by sbonazzo＠redhat.com 24 Mar '16

24 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: centos-7: Disable webadmin auto logout ...................................................................... centos-7: Disable webadmin auto logout This patch set the MAX_LOGIN_MINUTES value to -1 to disable the auto logout of the user. Change-Id: I99ab00253b6ca40d67a428627c6d460708af28bc Bug-Url: https://bugzilla.redhat.com/1307262 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/engine-setup-yad.sh 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54991 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99ab00253b6ca40d67a428627c6d460708af28bc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: README.config-query: added a few usage examples
by didi＠redhat.com 24 Mar '16

24 Mar '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: README.config-query: added a few usage examples ...................................................................... README.config-query: added a few usage examples Change-Id: I52d96bacf7754ac5ffe261b97f332a58bddc706a Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M README.config-query 1 file changed, 123 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/55147 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52d96bacf7754ac5ffe261b97f332a58bddc706a Gerrit-PatchSet: 3 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-host-deploy: move master to standard ci
by sbonazzo＠redhat.com 24 Mar '16

24 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-host-deploy: move master to standard ci ...................................................................... ovirt-host-deploy: move master to standard ci Change-Id: I917c1fa9d983a24609b1e43266e61072cf59ed60 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-host-deploy/ovirt-host-deploy_create-rpms.yaml A jobs/confs/projects/ovirt-host-deploy/ovirt-host-deploy_standard.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 3 files changed, 20 insertions(+), 16 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55198 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I917c1fa9d983a24609b1e43266e61072cf59ed60 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Sessions in left tree was called 'Guest Information'
by tjelinek＠redhat.com 24 Mar '16

24 Mar '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Sessions in left tree was called 'Guest Information' ...................................................................... webadmin: Sessions in left tree was called 'Guest Information' Regression introduced by: eefc4d0488fe43d4f11e40335253b5a358230878 The eefc4d0488fe43d4f11e40335253b5a358230878 have introduced a new subtab called "Guest Information" but accidentally have renamed the "Sessions" tree item to it. Change-Id: I3dd40329870f1786c460490a877f4bfb9ea38d3b Bug-Url: https://bugzilla.redhat.com/1318936 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved Vinzenz Feenstra: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3dd40329870f1786c460490a877f4bfb9ea38d3b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine-backup: allow backups to be done without ovirt-engine.
by piotr.kliczewski＠gmail.com 24 Mar '16

24 Mar '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine-backup: allow backups to be done without ovirt-engine. ...................................................................... engine-backup: allow backups to be done without ovirt-engine. This patch allows the usage of engine-backup tool in machines that does not have ovirt-engine installed. This is required to create backups for machines that just run reports/dwh. Change-Id: I533d4e275c5ee333b27723b30236f0d23a4732d8 Bug-Url: https://bugzilla.redhat.com/1320092 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M .gitignore M Makefile M ovirt-engine.spec.in R packaging/bin/engine-backup.sh.in 4 files changed, 96 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/55045 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I533d4e275c5ee333b27723b30236f0d23a4732d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: "VM Id" -> "VM ID"
by amureini＠redhat.com 24 Mar '16

24 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: "VM Id" -> "VM ID" ...................................................................... webadmin: "VM Id" -> "VM ID" "Id", with an uppercase I and a lowercase d is not a shorthand for identification - It's a term in psychology (see, e.g., https://en.wikipedia.org/wiki/Id,_ego_and_super-ego#Id) The proper shorthand for identifier is ID, with both letters uppercased. This patch resolves the frontend mistakes with this regard. Change-Id: I1274cdeb8f35d9b037d74ae46e4a8d8c353530f7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1274cdeb8f35d9b037d74ae46e4a8d8c353530f7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: vdsm: give vdsm config higher priority
by sbonazzo＠redhat.com 24 Mar '16

24 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: give vdsm config higher priority ...................................................................... vdsm: give vdsm config higher priority vdsm configuration must be executed before vdsm restart. Change-Id: Id6b11427e50e7fb60f6f42c736229820a1fff729 Bug-Url: https://bugzilla.redhat.com/1320059 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/packages.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55183 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6b11427e50e7fb60f6f42c736229820a1fff729 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0