April 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: remove handleVmOnDown
by ahadas＠redhat.com 18 Apr '16

18 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: remove handleVmOnDown ...................................................................... core: remove handleVmOnDown The handling of report of Down VM from host that is different than the one we expect the VM to run on in handleVmDown is incorrect - we neither want it to remove the async command nor to update the dynamic VM data. The handling of report of Down VM from the host that we expect the VM to run on was merged to proceedDownVm, rednering handleVmOnDown redundant and therefore is removed. Change-Id: Ie2d7b1994c3066e6964f1addab4a659d2004add4 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 22 insertions(+), 34 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/55736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2d7b1994c3066e6964f1addab4a659d2004add4 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in vm-analyzer tests
by ahadas＠redhat.com 18 Apr '16

18 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in vm-analyzer tests ...................................................................... core: cleanup in vm-analyzer tests Some of the mocked are not needed anymore, thus removed. Change-Id: I7c12c68e986fa10dfa371ae1e8aaccaa9725bd95 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerTest.java 1 file changed, 0 insertions(+), 21 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/56259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c12c68e986fa10dfa371ae1e8aaccaa9725bd95 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Create vm_templates_view without other entity types
by ahadas＠redhat.com 18 Apr '16

18 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Create vm_templates_view without other entity types ...................................................................... core: Create vm_templates_view without other entity types The search query used currently for Templates view looks over vm_templates_view that contains several different entity types and then filters templates out of the result that was returned from SQL query. But this works badly with limited queries - the query that is limited to return one page of results (for example, 100 items) may return less. >From Frontend point of view, the page that is not full should be the last one. To fix this, a new view must be created containing only template entities. The post-filtering will not be needed and the query will always return a full page of results for all pages except the last one. Change-Id: I244c9a22fd3d8bd9e0b3ac2ebea717740fc030d9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1317789 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/vm_templates_sp.sql M packaging/dbscripts/vms_sp.sql 4 files changed, 73 insertions(+), 66 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I244c9a22fd3d8bd9e0b3ac2ebea717740fc030d9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: use VdsDynamicDao in vm-analyzer
by ahadas＠redhat.com 18 Apr '16

18 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: use VdsDynamicDao in vm-analyzer ...................................................................... core: use VdsDynamicDao in vm-analyzer During the analysis of the VM the analyzer needs to check the status of the host that the VM is being migrated to and no other information about hosts is needed, therefore it can use VdsDynamicDao instead of VdsDao. That reduces the complexity of the queries from the database. Change-Id: I332baefe4e133a0353dbdddec9e82c9325a92a24 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerTest.java 4 files changed, 21 insertions(+), 20 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I332baefe4e133a0353dbdddec9e82c9325a92a24 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove removeVmFromCache
by ahadas＠redhat.com 18 Apr '16

18 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: remove removeVmFromCache ...................................................................... core: remove removeVmFromCache VmAnalyzer#proceedDisappearedVm already does the work in the mentioned method for VMs that stopped being reported. This patch adds the missing part to VmAnalyzer#proceedDownVm in order to reder VmAnalyzer#removeVmFromCache redundant. Change-Id: Ice13abffd478f43dae564b1537e60fa041bf0fcd Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerTest.java 2 files changed, 6 insertions(+), 48 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/55735 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice13abffd478f43dae564b1537e60fa041bf0fcd Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine : Add filter to skip initializing authz extensions
by mperina＠redhat.com 18 Apr '16

18 Apr '16

Martin Peřina has submitted this change and it was merged. Change subject: engine : Add filter to skip initializing authz extensions ...................................................................... engine : Add filter to skip initializing authz extensions Add a conig ENGINE_EXTENSIONS_IGNORED to skip loading the extensions by the provider type. Change-Id: Id5c30a5fd48da0abcaf8359623bbbec567b8e16f Bug-Url: https://bugzilla.redhat.com/1092744 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfile.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java M packaging/services/ovirt-engine/ovirt-engine.conf.in 5 files changed, 22 insertions(+), 18 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56050 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5c30a5fd48da0abcaf8359623bbbec567b8e16f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Allow restoring to a different ver...
by sbonazzo＠redhat.com 18 Apr '16

18 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Allow restoring to a different version ...................................................................... packaging: engine-backup: Allow restoring to a different version Change-Id: Ia315333c3479656f9c0515f16e438292c005ad98 Bug-Url: https://bugzilla.redhat.com/1318580 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh.in 1 file changed, 79 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/55046 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia315333c3479656f9c0515f16e438292c005ad98 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: asynctasks: do not start/stop engine
by sbonazzo＠redhat.com 18 Apr '16

18 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: asynctasks: do not start/stop engine ...................................................................... packaging: setup: asynctasks: do not start/stop engine async tasks handling/cleanup during setup/upgrade is protected from adding additional tasks by moving the engine to "maintenance mode". Without this patch, we also try to start the engine when setting maintenance mode, and stop it when we finish. This breaks the migration flow described in the referenced bug, where we run setup of version X where engine of version X is already installed, but the database is from an older version. In this flow, we do not want to start the newer engine to run against an older database. It's also ugly in other ways: In a normal upgrade, if the engine was up, we needlessly try to start it. Later on, this code takes the engine down, while we immediately try doing that again (at transaction begin). Stop doing that. Just set maintenance mode in the database and expect the engine to behave accordingly, if it's up. If the engine is down, and there are pending tasks, notify the user accordingly. Change-Id: I4f9d31dbb6b748ac3c49ceb7d7d2b53cbd6d38df Bug-Url: https://bugzilla.redhat.com/1318580 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py 1 file changed, 17 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/56033 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f9d31dbb6b748ac3c49ceb7d7d2b53cbd6d38df Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Clean up VdsProperties
by amureini＠redhat.com 17 Apr '16

17 Apr '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Clean up VdsProperties ...................................................................... core: Clean up VdsProperties Removed unused constants. Change-Id: Iaa07276043d9d97e215510ecdfd47fe7584f5dcf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 1 file changed, 1 insertion(+), 33 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa07276043d9d97e215510ecdfd47fe7584f5dcf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove VdsProperties#migrationMethodtoString
by amureini＠redhat.com 17 Apr '16

17 Apr '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove VdsProperties#migrationMethodtoString ...................................................................... core: Remove VdsProperties#migrationMethodtoString This entire method is just a convoluted way to get the migration method name, albeit lower-cased. Change-Id: I4d044d551afa23d1231540f2dbca39cf1cde74e7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 2 files changed, 1 insertion(+), 19 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d044d551afa23d1231540f2dbca39cf1cde74e7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0