Change in ovirt-engine[master]: restapi: Support skip LUN status check
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Support skip LUN status check
......................................................................
restapi: Support skip LUN status check
Adding support for skipping the LUN status check in
the REST API.
Checking the status of the LUN is an heavy weight operation
and this data is not always needed by the user.
The default is `true` for backward compatibility.
The parameter `report_status` is available both on getting the list of a
host storages or a specific host storage:
GET /hosts/{host:id}/storage
GET /hosts/{host:id}/storage/{storage:id}
For example, to skip the LUN status check, set `report_status` to false:
(The `status` field of the LUN will not be present in the response)
GET /hosts/{host:id}/storage/{storage:id};report_status=false
<host_storage id="360014051136c20574f743bdbd28177fd">
<logical_units>
<logical_unit id="360014051136c20574f743bdbd28177fd">
<lun_mapping>0</lun_mapping>
<paths>1</paths>
<product_id>lun0</product_id>
<serial>SLIO-ORG_lun0_1136c205-74f7-43bd-bd28-177fd5ce6993</serial>
<size>10737418240</size>
<vendor_id>LIO-ORG</vendor_id>
<volume_group_id>O9Du7I-RahN-ECe1-dZ1w-nh0b-64io-MNzIBZ</volume_group_id>
</logical_unit>
</logical_units>
<type>iscsi</type>
<host id="8bb5ade5-e988-4000-8b93-dbfc6717fe50"/>
</host_storage>
Change-Id: Ia772a0e7d9a67c8364e05c9f36a71a9111d1fdde
Bug-Url: https://bugzilla.redhat.com/1308350
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/restapi/README.adoc
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResource.java
3 files changed, 86 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/56301
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia772a0e7d9a67c8364e05c9f36a71a9111d1fdde
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in jenkins[master]: ovirt-engine_upgrade_to_master: add missing key
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-engine_upgrade_to_master: add missing key
......................................................................
ovirt-engine_upgrade_to_master: add missing key
Add:
OVESETUP_DWH_CORE/enable=bool:False
DWH is now mandatory for the engine. For jenkins purposes, it's enough
if we disable it.
Change-Id: I6872c588c7aacfa30a4409639759b8006ab61457
Bug-Url: https://bugzilla.redhat.com/1318665
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M jobs/ovirt-engine_upgrade_to_master/setup.file.otopi
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me; Passed CI tests; Ready for merge
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/56321
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6872c588c7aacfa30a4409639759b8006ab61457
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: do not test individual locking of pool, do test generi...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: do not test individual locking of pool, do test generic behavior
......................................................................
core: do not test individual locking of pool, do test generic behavior
Change-Id: I926f10fe6fc3070c126b9e8f395a32ccb7575b69
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerDc.java
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacPoolLockingProxyTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/LockedObjectFactory.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/lock/LockedObjectFactoryTest.java
4 files changed, 209 insertions(+), 256 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53132
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I926f10fe6fc3070c126b9e8f395a32ccb7575b69
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: creation of LockingProxy can be generalized for all cl...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: creation of LockingProxy can be generalized for all classes.
......................................................................
core: creation of LockingProxy can be generalized for all classes.
• tests were intentionally left unchaged, so that they demonstrate,
that functionality is equal.
Change-Id: I7c00ef7252212e2a7112cbfaf579bf5078935ed4
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPool.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolLockingProxy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerDc.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacPoolLockingProxyTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerDcTest.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/AcquireReadLock.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/AcquireWriteLock.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/LockedObjectFactory.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/lock/LockedObjectFactoryLockingInvocationHandlerTest.java
9 files changed, 200 insertions(+), 94 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53131
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c00ef7252212e2a7112cbfaf579bf5078935ed4
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-dwh[master]: history:removed collection of dc statistics
by Shirly Radco
Shirly Radco has submitted this change and it was merged.
Change subject: history:removed collection of dc statistics
......................................................................
history:removed collection of dc statistics
removed collection of data center statistics,
time in status.
Change-Id: I08ba1d6279385157593f424f080fba3baf25a6b9
Bug-Url: https://bugzilla.redhat.com/1300328
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M etl_export/src/main/java/ovirt_engine_dwh/aggregationtodaily_4_0/AggregationToDaily.java
M etl_export/src/main/java/ovirt_engine_dwh/aggregationtohourly_4_0/AggregationToHourly.java
M etl_export/src/main/java/ovirt_engine_dwh/historydelete_4_0/HistoryDelete.java
M etl_export/src/main/java/ovirt_engine_dwh/statisticssync_4_0/StatisticsSync.java
M packaging/dbscripts/create_views_3_6.sql
M packaging/dbscripts/create_views_4_0.sql
A packaging/dbscripts/upgrade/04_00_0020_drop_datacenter_statistics_tables.sql
M tos_project/process/AggregationToDaily_4.0.item
M tos_project/process/AggregationToDaily_4.0.properties
M tos_project/process/AggregationToHourly_4.0.item
M tos_project/process/AggregationToHourly_4.0.properties
M tos_project/process/HistoryDelete_4.0.item
M tos_project/process/HistoryDelete_4.0.properties
M tos_project/process/StatisticsSync_4.0.item
M tos_project/process/StatisticsSync_4.0.properties
15 files changed, 1,661 insertions(+), 9,323 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56115
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08ba1d6279385157593f424f080fba3baf25a6b9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: history: remove dwh_datacenter_history_view
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: history: remove dwh_datacenter_history_view
......................................................................
history: remove dwh_datacenter_history_view
Change-Id: I9721fe1e9ce14d891f233d5f1ad2e2d8decbcd03
Bug-Url: https://bugzilla.redhat.com/1327012
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/dbscripts/create_dwh_views.sql
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Shirly Radco: Verified; Looks good to me, but someone else must approve
Eli Mesika: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56114
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9721fe1e9ce14d891f233d5f1ad2e2d8decbcd03
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: packaging: setup: Configure access to dwh db
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Configure access to dwh db
......................................................................
packaging: setup: Configure access to dwh db
If setting up dwh and engine on the same machine, write out the dwh db
credentials to an engine config file so that it can access dwh db.
Otherwise instruct the user to configure access later.
Change-Id: Ia241480fc59b3369bc99340af474b155f88ea93c
Bug-Url: https://bugzilla.redhat.com/1318665
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/__init__.py
A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/dwh_database.py
3 files changed, 207 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/56297
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia241480fc59b3369bc99340af474b155f88ea93c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: extracted locking to proxy
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: extracted locking to proxy
......................................................................
core: extracted locking to proxy
if we want to use decorators to influence pool behavior, pool itserlf
must not contain locking(which is cross-cutting concern anyways and
should have not be defined there in first place).
Bug-Url: https://bugzilla.redhat.com/1283062
Change-Id: I88ad24237971ffccbd6446b75a6846dfd099cfac
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolLockingProxy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerDc.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolUsingRanges.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacPoolLockingProxyTest.java
4 files changed, 362 insertions(+), 49 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/50515
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88ad24237971ffccbd6446b75a6846dfd099cfac
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: rename
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: rename
......................................................................
core: rename
MacPoolManagerStrategy —> MacPool
MacPoolManagerRanges —> MacPoolUsingRanges
Bug-Url: https://bugzilla.redhat.com/1283062
Change-Id: I31043b0bd275b576e74be0d9d0e77b74cae9cb56
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPool.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerDc.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolUsingRanges.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacsStorage.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/ObjectCounter.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/Range.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MacAddressValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVMFromConfigurationCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerDcTest.java
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacsStorageTest.java
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/ObjectCounterTest.java
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/RangeTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/SnapshotVmConfigurationHelperTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommandTest.java
34 files changed, 134 insertions(+), 124 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50514
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31043b0bd275b576e74be0d9d0e77b74cae9cb56
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: nesting PluralMessages into NetworkValidator
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: nesting PluralMessages into NetworkValidator
......................................................................
core: nesting PluralMessages into NetworkValidator
PluralMessages was intended to help with singular-plural localization
pairs. This is bad approach, but I thought it should help with
transition. But when variable replacements hit this class it becomes
really unreadable and complexity overcame the benefits.
This class was also used from NetworkAttachmentValidator, but that one
can delegate to NetworkValidator, so PluralMessages was simplified a
lot, uses newly available methods, and is made accessible only to
NetworkValidator.
Change-Id: I6c88ed8f66ace2c515d1174cf305204074f432ce
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkFromClusterInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/PluralMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 81 insertions(+), 93 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45648
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c88ed8f66ace2c515d1174cf305204074f432ce
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months