Change in ovirt-engine[master]: core: Fix HotPlugDiskToVmCommandTest
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix HotPlugDiskToVmCommandTest
......................................................................
core: Fix HotPlugDiskToVmCommandTest
Change-Id: Ie72738bf55b94c2f9dba6654abc421530084717d
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55707
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie72738bf55b94c2f9dba6654abc421530084717d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: core: Remove useless method in HotUnPlugDiskFromVmCommand
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Remove useless method in HotUnPlugDiskFromVmCommand
......................................................................
core: Remove useless method in HotUnPlugDiskFromVmCommand
Remove overridden method with the exact same behavior as the super method
Change-Id: I26c04ce636ee7183bc2e6fab85ae094db5cf6718
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/HotUnPlugDiskFromVmCommand.java
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55699
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26c04ce636ee7183bc2e6fab85ae094db5cf6718
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: core: Reduce accessibility of methods in HotPlugDiskToVmCommand
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Reduce accessibility of methods in HotPlugDiskToVmCommand
......................................................................
core: Reduce accessibility of methods in HotPlugDiskToVmCommand
Change-Id: I30eca174422441f76b52da49ccf9547504acc445
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55698
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30eca174422441f76b52da49ccf9547504acc445
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[ovirt-engine-3.6]: setup: fixing setup when engine option is not enabled
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: setup: fixing setup when engine option is not enabled
......................................................................
setup: fixing setup when engine option is not enabled
The user can also install engine-setup rpms and respond No to
Configure Engine on this host (Yes, No).
Supporting that path.
Change-Id: I38dcd682946485f97f704f99ca6d51c5c4efb0d2
Bug-Url: https://bugzilla.redhat.com/1318986
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine_common/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/storage.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py
4 files changed, 40 insertions(+), 20 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55133
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38dcd682946485f97f704f99ca6d51c5c4efb0d2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-reports[ovirt-engine-reports-3.6]: build: after build reports for 3.6.5.1
by Shirly Radco
Shirly Radco has submitted this change and it was merged.
Change subject: build: after build reports for 3.6.5.1
......................................................................
build: after build reports for 3.6.5.1
Change-Id: I968491153b8ceedc32a1271b0a2ac0ee0e3b5f54
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M version.mak
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I968491153b8ceedc32a1271b0a2ac0ee0e3b5f54
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.6
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-reports[ovirt-engine-reports-3.6]: build: build reports for 3.6.5.1
by Shirly Radco
Shirly Radco has submitted this change and it was merged.
Change subject: build: build reports for 3.6.5.1
......................................................................
build: build reports for 3.6.5.1
Change-Id: I32b01a081bb8b0a78fb7ecb9febd35d028f0db56
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M ovirt-engine-reports.spec.in
M version.mak
2 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55655
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32b01a081bb8b0a78fb7ecb9febd35d028f0db56
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.6
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: userportal, webadmin: use a custom patched bootstrap.js
by gshereme＠redhat.com
Greg Sheremeta has submitted this change and it was merged.
Change subject: userportal, webadmin: use a custom patched bootstrap.js
......................................................................
userportal, webadmin: use a custom patched bootstrap.js
Temporarily switch to a custom patched bootstrap.js.
Bootstrap 3.3.4 - 3.3.6 have a memory leak in the tooltips
that we are using extensively. It will take a while to get
that fixed upstream, so for now let's include the fix locally.
I addded a GWT-TODO so we remember to switch back to upstream
when its fixed.
Change-Id: Ie6e423738fa2905b24ae448bd870dd1b375b250a
X-Ref: https://github.com/twbs/bootstrap/issues/17973#issuecomment-202648725
Bug-Url: https://bugzilla.redhat.com/1294678
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/javascripts.tag
A packaging/branding/ovirt.brand/bootstrap-3.3.6-custom.js
2 files changed, 2,365 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55546
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6e423738fa2905b24ae448bd870dd1b375b250a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in jenkins[master]: Publish Node.js packages
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Publish Node.js packages
......................................................................
Publish Node.js packages
This patch adds the Node.js packages required to build oVirt JavaScript
applications to the publisher, so that these packages will be available
for the builds of other packages that require them.
Change-Id: If485dd91ce232e6ce9e9a15a1824607e174582ba
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55542
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If485dd91ce232e6ce9e9a15a1824607e174582ba
Gerrit-PatchSet: 6
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: engine: Introduce Ipv6Constraint
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Introduce Ipv6Constraint
......................................................................
engine: Introduce Ipv6Constraint
Change-Id: I92be79ced44d39e0092bd67e58bd65677c470539
Bug-Url: https://bugzilla.redhat.com/1080725
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/Ipv6Constraint.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/Ipv6.java
A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/Ipv6ConstraintTest.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 117 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved; Passed CI tests
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/53622
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92be79ced44d39e0092bd67e58bd65677c470539
Gerrit-PatchSet: 30
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: engine: allow IPv6 address as a host name
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: allow IPv6 address as a host name
......................................................................
engine: allow IPv6 address as a host name
Allow IPv6 address as a host name in business entity validation.
Change-Id: Ib90ae3e4286701c650f3f96c8e2ff2575b5d7baa
Bug-Url: https://bugzilla.redhat.com/1080725
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java
2 files changed, 15 insertions(+), 5 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved; Passed CI tests
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/53175
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib90ae3e4286701c650f3f96c8e2ff2575b5d7baa
Gerrit-PatchSet: 37
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months