Change in ovirt-engine[master]: core: CommandBase - end step for commands with callbacks
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: CommandBase - end step for commands with callbacks
......................................................................
core: CommandBase - end step for commands with callbacks
After command with callback endAction() is executed its execution
and finalizing steps should end to reflect the actual status.
Change-Id: I64d78be669e4ce08981dff15691f76af236ab2e3
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 1 insertion(+), 5 deletions(-)
Approvals:
Moti Asayag: Looks good to me, approved
Liron Aravot: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55709
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64d78be669e4ce08981dff15691f76af236ab2e3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[ovirt-engine-3.6]: core: reducing race - avoid syncing the storage domain statu...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: reducing race - avoid syncing the storage domain status when its in process
......................................................................
core: reducing race - avoid syncing the storage domain status when its in process
This patch reduce the chance of encountering a race condition, currently
we have a chance of encountring concurrent modifications to the storage
domain status
[1] - Operation on the domain
[2] - Timer that executes every few seconds GetStoragePoolInfo on the SPM host
and updates the domain data/pool metadata in the DB to match the data retrieved
from the SPM.
Those two process aren't synchronized which is problematic. The problem increased
when different statuses were added to indicate the operation performed on the domain
but the code in the timer ([2]) wasn't update.
As a first step for this patch makes [2] aware of this status which should reduce
drastically the chance for the race condition which is the condition we lived with so
far, looking forward we should look into improve that code and check the necessity of
it (as in V4 we'll no longer support any DC version with the pool metadata on storage).
Change-Id: I7080b74770e1b192ea03798f4afb7143a5f5a796
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1311121
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/55726
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7080b74770e1b192ea03798f4afb7143a5f5a796
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: core: cleanup old event notification history
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: cleanup old event notification history
......................................................................
core: cleanup old event notification history
Description of the problem:
Customer is recording each login/logout from the system and sends
notifications on those events, in the database there are more than 0.5
Million of records for both audit_log and event_notification_hist
tables.
engine_357=# select count(*) from public.event_notification_hist;
count
--------
540260
(1 row)
engine_357=# select count(*) from public.audit_log;
count
--------
540250
(1 row)
The validatedb.sh script validates that there is no data that violates
Foreign Keys.
As part of this validation, the following query is generated and
executed :
select (audit_log_id)
from public.event_notification_hist
where (audit_log_id) IS NOT NULL
and (audit_log_id) not in (
select audit_log_id from public.audit_log);
This is a very heavy query considering table sizes above and I can
understand why it expands from 1.5 hours to 7 hours, simply because both
tables keep on growing
One reason for this slow query is luck of suitable index on
event_notification_hist
Engine has a scheduler job that cleans records older than 30 days.
By checking why the audit_log and event_notification_history have
records older than 30 days I found that the cleanup mechanism skips
records that their audit_log_id exists in event_notification_history.
This caused the audit_log to include records older than 30 days and
event_notification_history not to be cleaned ever, making the upgrade
heavier from version to version as records grows.
This patch
1) Adds the missing index on event_notification_history so the FK
validation will use index and not do a table scan on such large tables.
2) Modify the cleanup mechanism to delete all old records, since
event_notification_history has a FK with DELETE CASCADE on audit_log, it
will be cleaned up as well.
Patch was validated on the customer problematic DB and solved the
problem.
Change-Id: Ib93c1a37b0838d9020ca4f8a300346b3fe3b87f0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1323826
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/dbscripts/audit_log_sp.sql
A packaging/dbscripts/upgrade/04_00_0420_add_index_event_notification_hist.sql
2 files changed, 5 insertions(+), 9 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Eli Mesika: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55724
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib93c1a37b0838d9020ca4f8a300346b3fe3b87f0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: core: remove confusing 'stable' field from VmAnalyzer
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: remove confusing 'stable' field from VmAnalyzer
......................................................................
core: remove confusing 'stable' field from VmAnalyzer
The field called 'stable' was used to discover whether or not we
should call removeVmFromCache method in updateRepository. The logic
there is not trivial and buttom line is that this method is called
only when the status of the reported VM is down and the VM is
running on the monitored host (dbVm != null).
Therefore, moving the call to be proceedDownVm. This move should
have no side effects (it might not be necessary at all - but
need some more investigation before removing it) and it makes
the 'stable' field redundant.
Change-Id: Ib4c636d11f92b6915fec03701a37f5335ef42411
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 4 insertions(+), 10 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/55631
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4c636d11f92b6915fec03701a37f5335ef42411
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: webadmin: Name validation invalidates the General tab
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Name validation invalidates the General tab
......................................................................
webadmin: Name validation invalidates the General tab
When validation of VM Name fails in the Edit VM/Template/Pool Dialog,
the "General" tab is marked as invalid and gets focus.
Change-Id: Ib2de0d635df993db49dcd64fff5e5b5069f35baa
Bug-Url: https://bugzilla.redhat.com/1314417
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
7 files changed, 12 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Marek Libra: Verified
--
To view, visit https://gerrit.ovirt.org/55141
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2de0d635df993db49dcd64fff5e5b5069f35baa
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: webadmin: Tooltip for cpuInfo
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Tooltip for cpuInfo
......................................................................
webadmin: Tooltip for cpuInfo
VM/Template/Pool General subtab shows tooltip explaining format of
the displayed Number of CPU Cores field.
Similar for userportal VM Detail.
With this patch, the displayed cpuInfo value is in shorten form (i.e. '8 (2:4:1)').
Change-Id: Ic485fdc7c9305efe5d6652c440be964970bf4c73
Bug-Url: https://bugzilla.redhat.com/1296127
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormItem.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateGeneralModelForm.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolGeneralModelForm.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.ui.xml
8 files changed, 52 insertions(+), 14 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Marek Libra: Verified
--
To view, visit https://gerrit.ovirt.org/54995
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic485fdc7c9305efe5d6652c440be964970bf4c73
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: engine: Block move network by removing the old att and creat...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Block move network by removing the old att and creating a new one
......................................................................
engine: Block move network by removing the old att and creating a new one
Moving a network from nic to nic should be done only by changing the
nic_id/nic_name of the already existing attachment that contains the
network.
Removing the old attachmnet and creating a new one for the same
network, shouldn't be supported by the setup networks command.
Change-Id: Ibb28c11eda2dbf702614ba86272ed84b73423a15
Bug-Url: https://bugzilla.redhat.com/1322947
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 83 insertions(+), 0 deletions(-)
Approvals:
Marcin Mirecki: Looks good to me, but someone else must approve
Alona Kaplan: Verified; Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55687
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb28c11eda2dbf702614ba86272ed84b73423a15
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: webadmin: moving network from nic to nic should reuse the sa...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: moving network from nic to nic should reuse the same attachment
......................................................................
webadmin: moving network from nic to nic should reuse the same attachment
Change-Id: Ie26aeadf1845f99b58fdbbabd83f693ad3a64d75
Bug-Url: https://bugzilla.redhat.com/1322947
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/DataFromHostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModelParametersHelper.java
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/ExecuteNetworkCommandInNetworkOperationTest.java
4 files changed, 61 insertions(+), 16 deletions(-)
Approvals:
Marcin Mirecki: Looks good to me, but someone else must approve
Alona Kaplan: Verified; Passed CI tests
Daniel Erez: Looks good to me, approved
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55686
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie26aeadf1845f99b58fdbbabd83f693ad3a64d75
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: engine: HostSetupNetworkValidator small cleanup
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: HostSetupNetworkValidator small cleanup
......................................................................
engine: HostSetupNetworkValidator small cleanup
- Changing some variable nams
attachmentsById -> existingAttachmentsById
networkAttachmentsByNetworkId -> networkAttachmentsFromParamsByNetworkId
- Adding new usefull map
existingAttachmentsByNetworkId
- Remove unneeded check from - 'notRemovingLabeledNetworks'
(patch https://gerrit.ovirt.org/#/c/55687 makes it unneeded)
- Changing 'validateNotRemovingUsedNetworkByVms()' to check only one
network at a time, and not all the networks each iteration.
Change-Id: I9a5e64696a77547bcce857bd348e401ab6e10add
Bug-Url: https://bugzilla.redhat.com/1322947
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
2 files changed, 25 insertions(+), 62 deletions(-)
Approvals:
Marcin Mirecki: Looks good to me, but someone else must approve
Alona Kaplan: Verified; Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55632
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a5e64696a77547bcce857bd348e401ab6e10add
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: core: reducing race - avoid syncing the storage domain statu...
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: reducing race - avoid syncing the storage domain status when its in process
......................................................................
core: reducing race - avoid syncing the storage domain status when its in process
This patch reduce the chance of encountering a race condition, currently
we have a chance of encountring concurrent modifications to the storage
domain status
[1] - Operation on the domain
[2] - Timer that executes every few seconds GetStoragePoolInfo on the SPM host
and updates the domain data/pool metadata in the DB to match the data retrieved
from the SPM.
Those two process aren't synchronized which is problematic. The problem increased
when different statuses were added to indicate the operation performed on the domain
but the code in the timer ([2]) wasn't update.
As a first step for this patch makes [2] aware of this status which should reduce
drastically the chance for the race condition which is the condition we lived with so
far, looking forward we should look into improve that code and check the necessity of
it (as in V4 we'll no longer support any DC version with the pool metadata on storage).
Change-Id: I7080b74770e1b192ea03798f4afb7143a5f5a796
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1311121
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Eyal Edri: Looks good to me, but someone else must approve
David Caro: Verified
Liron Aravot: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55496
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7080b74770e1b192ea03798f4afb7143a5f5a796
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months