Change in ovirt-engine[ovirt-engine-3.6]: userportal, webadmin: use a custom patched bootstrap.js
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: userportal, webadmin: use a custom patched bootstrap.js
......................................................................
userportal, webadmin: use a custom patched bootstrap.js
Temporarily switch to a custom patched bootstrap.js.
Bootstrap 3.3.4 - 3.3.6 have a memory leak in the tooltips
that we are using extensively. It will take a while to get
that fixed upstream, so for now let's include the fix locally.
I addded a GWT-TODO so we remember to switch back to upstream
when its fixed.
Change-Id: Ie6e423738fa2905b24ae448bd870dd1b375b250a
X-Ref: https://github.com/twbs/bootstrap/issues/17973#issuecomment-202648725
Bug-Url: https://bugzilla.redhat.com/1294678
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/javascripts.tag
A packaging/branding/ovirt.brand/bootstrap-3.3.6-custom.js
2 files changed, 2,365 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55554
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6e423738fa2905b24ae448bd870dd1b375b250a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: webadmin: UI plugin API - showAlert
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: UI plugin API - showAlert
......................................................................
webadmin: UI plugin API - showAlert
This patch adds new UI plugin API function ('showAlert')
that can be used to show application-wide alert messages.
API signature:
showAlert(alertTypeName, message, options)
Possible 'alertTypeName' values (default is 'info'):
danger
warning
success
info
The 'options' parameter is, by convention, optional and
used to group additional alert settings:
autoHideMs [number]
Number of milliseconds after which the alert should be
automatically closed. A negative value is functionally
equivalent to 0 (auto-hide disabled).
Example usage:
api.showAlert('success', 'Success alert message');
api.showAlert('danger', 'Error message with auto-hide', {
autoHideMs: 3000
});
Change-Id: Ib4462f0d10bfdded2994cdccd3f0cc2aec9c2252
Bug-Url: https://bugzilla.redhat.com/1285432
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/AlertOptions.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java
4 files changed, 63 insertions(+), 1 deletion(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/55504
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4462f0d10bfdded2994cdccd3f0cc2aec9c2252
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: webadmin, userportal: Ensure popups are non-singletons
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Ensure popups are non-singletons
......................................................................
webadmin,userportal: Ensure popups are non-singletons
All UiCommon model-bound popups (classes that extend
AbstractModelBoundPopupPresenterWidget) are already
treated as non-singletons: closing the popup causes
all associated handlers to be released.
This patch ensures that following popups are treated
as non-singletons too:
- (2x) AboutPopupPresenterWidget (about dialog)
- ErrorPopupPresenterWidget (default error dialog)
- ConfigurePopupPresenterWidget (config dialog)
DynamicUrlContentPopupPresenterWidget (custom dialog
triggered via UI plugin API) was adapted too to stay
consistent with above mentioned dialogs.
Change-Id: I32602bfad905f0e351d4d35cf774322bbb2c5148
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BasePresenterModule.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractPopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ErrorPopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ErrorPopupManagerImpl.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ErrorPopupManager.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/PresenterModule.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/AboutPopupPresenterWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/HeaderPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AboutPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/DynamicUrlContentPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/configure/ConfigurePopupPresenterWidget.java
13 files changed, 67 insertions(+), 37 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified; Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/54898
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32602bfad905f0e351d4d35cf774322bbb2c5148
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: webadmin, userportal: Remove GenericApiGWTService.getLoggedIn...
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Remove GenericApiGWTService.getLoggedInUser
......................................................................
webadmin,userportal: Remove GenericApiGWTService.getLoggedInUser
Removed unused getLoggedInUser() method from GWT RPC interface.
Change-Id: Ie4dd72a6b91557757f2b237b145ace818c2556e2
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/gwtservices/GenericApiGWTService.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
2 files changed, 9 insertions(+), 32 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/53138
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4dd72a6b91557757f2b237b145ace818c2556e2
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: webadmin: fix memory leak in alerts / events footer
by gshereme＠redhat.com
Greg Sheremeta has submitted this change and it was merged.
Change subject: webadmin: fix memory leak in alerts / events footer
......................................................................
webadmin: fix memory leak in alerts / events footer
Fixed a large memory leak in alerts and events footer.
Each table has a 'dismiss' column and cell. The cells
were holding references to ModelProviders, which created
a circular reference. These tables also update every 5
seconds, so that was a ton of DOM nodes that were
detached and not GC-able.
Change-Id: Ib0ede93316863258f57619ce3e229417b4420e33
Bug-Url: https://bugzilla.redhat.com/1294678
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractImageButtonCell.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/AlertListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/AlertsEventsFooterView.java
5 files changed, 54 insertions(+), 37 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55547
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0ede93316863258f57619ce3e229417b4420e33
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Mordechai Lehrer <mlehrer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: webadmin: frontend Optional<T>
by mbetak＠redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: webadmin: frontend Optional<T>
......................................................................
webadmin: frontend Optional<T>
Lightweight imimation of Java 8 java.util.Optional
Change-Id: I690c20da8f44f10b0c7ef3965e31414e9db11244
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
A frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/Optional.java
1 file changed, 73 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55561
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I690c20da8f44f10b0c7ef3965e31414e9db11244
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: core: MigrationPoliciesSupported config value added
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: MigrationPoliciesSupported config value added
......................................................................
core: MigrationPoliciesSupported config value added
Configuration value enabling advanced migration settings: bandwidth,
policies.
Enabled since 4.0.
Change-Id: I87a19679bcda0cb65f82834e2c85f9652676fd95
Bug-Url: https://bugzilla.redhat.com/1252426
Feature-Page: http://www.ovirt.org/Features/Migration_Enhancements
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
4 files changed, 16 insertions(+), 0 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/54888
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87a19679bcda0cb65f82834e2c85f9652676fd95
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine-cli[master]: Make ovirt-engine-cli more portable: - replace sys.platform ...
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Make ovirt-engine-cli more portable: - replace sys.platform with os.name posix
......................................................................
Make ovirt-engine-cli more portable:
- replace sys.platform with os.name posix
Tested on OpenBSD.
Change-Id: I721c51df0ec5f1ccb78b621535d87185c15ce799
Bug-Url: https://bugzilla.redhat.com/1304643
Signed-off-by: Jiri Belka <jbelka(a)redhat.com>
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M src/cli/platform/__init__.py
M src/ovirtcli/platform/__init__.py
M src/ovirtcli/platform/windows/__init__.py
3 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53133
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I721c51df0ec5f1ccb78b621535d87185c15ce799
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Jiri Belka <jbelka(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-dwh[master]: packaging:added ant to automation
by Shirly Radco
Shirly Radco has submitted this change and it was merged.
Change subject: packaging:added ant to automation
......................................................................
packaging:added ant to automation
Change-Id: I679f73699048d2f5310068965193285c23ba94b1
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M automation/build-artifacts.packages
M automation/check-merged.packages
M automation/check-patch.packages
3 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55732
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I679f73699048d2f5310068965193285c23ba94b1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6.5]: core: Added permissions to Power User
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Added permissions to Power User
......................................................................
core: Added permissions to Power User
Added permission to 'Attach Disk Profile' to Power User.
Change-Id: If17d5bc09c60e3ab6b22e40260f82222ded25c3d
Bug-Url: https://bugzilla.redhat.com/1311052
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
(cherry picked from commit be9724556fbc82de3a171acc5a2df335ce5b22e2)
---
A packaging/dbscripts/upgrade/03_06_2090_add_attach_disk_profile_permissions_to_power_user_role.sql
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Tomer Saban: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55446
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If17d5bc09c60e3ab6b22e40260f82222ded25c3d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.5
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month