May 2016 - Engine-commits - oVirt List Archives

Change in jenkins[master]: changed upgrade jobs concurrent builds to 6
by eedri＠redhat.com 16 May '16

16 May '16

Eyal Edri has submitted this change and it was merged. Change subject: changed upgrade jobs concurrent builds to 6 ...................................................................... changed upgrade jobs concurrent builds to 6 Change-Id: I9c111963d08d14b9c292cd313eefe3075ccb1fe5 Signed-off-by: ngoldin <ngoldin(a)redhat.com> --- M jobs/confs/yaml/templates/engine-upgrade.yaml 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Nadav Goldin: Verified; Ready for review Eyal Edri: Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57525 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c111963d08d14b9c292cd313eefe3075ccb1fe5 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: db: Renaming DB upgrade script 04_00_0640->04_00_0650
by ahadas＠redhat.com 16 May '16

16 May '16

Arik Hadas has submitted this change and it was merged. Change subject: db: Renaming DB upgrade script 04_00_0640->04_00_0650 ...................................................................... db: Renaming DB upgrade script 04_00_0640->04_00_0650 Change-Id: Ib5db870c631fea12e5e0506ea9f50dad56051a94 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- R packaging/dbscripts/upgrade/04_00_0650_add_stateful_to_vm_pools.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57531 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5db870c631fea12e5e0506ea9f50dad56051a94 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-imageio: Add standard automation project
by eedri＠redhat.com 16 May '16

16 May '16

Eyal Edri has submitted this change and it was merged. Change subject: ovirt-imageio: Add standard automation project ...................................................................... ovirt-imageio: Add standard automation project Change-Id: Ic5251def28bf53d78010a0649a72585bce1d20d9 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- A jobs/confs/projects/ovirt-imageio/ovirt-imageio.yaml 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Verified Nadav Goldin: Looks good to me Eyal Edri: Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57461 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5251def28bf53d78010a0649a72585bce1d20d9 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Simplify VideoDeviceSettings
by ahadas＠redhat.com 16 May '16

16 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Simplify VideoDeviceSettings ...................................................................... core: Simplify VideoDeviceSettings Simplified VideoDeviceSettings, avoiding instantiation of inner classes and their inheritance from the common interface. Simple calls of static methods give exactly the same result. The inner classes were left untouched to scope interrelated methods and constants together. Change-Id: I725f3de52c490f37d6a13fe3e2bee76bca19cc83 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VideoDeviceSettings.java 1 file changed, 20 insertions(+), 36 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57512 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I725f3de52c490f37d6a13fe3e2bee76bca19cc83 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: added ovirt-imageio scm
by eedri＠redhat.com 16 May '16

16 May '16

Eyal Edri has submitted this change and it was merged. Change subject: added ovirt-imageio scm ...................................................................... added ovirt-imageio scm Change-Id: Icd5d8d0af0cb042bafd67226353648ceee5179a3 Signed-off-by: ngoldin <ngoldin(a)redhat.com> --- A jobs/confs/yaml/scms/ovirt-imageio.yaml 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Nadav Goldin: Verified; Ready for review Nir Soffer: Verified Eyal Edri: Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd5d8d0af0cb042bafd67226353648ceee5179a3 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Stateful VM Pools implementation
by ahadas＠redhat.com 16 May '16

16 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Stateful VM Pools implementation ...................................................................... core: Stateful VM Pools implementation This patch introduces stateful VM Pools. * Stateful VM Pools are designated by 'stateful' flag in the VmPool object. * VMs from a stateful VM Pool are always started in stateful mode (stateless snapshot is not created). The state of the VM is preserved even when VM is passed to a different user. * VMs from Automatic Stateful VM Pool are freed after VM shutdown and can be taken by another user after that. VMs from Manual Stateful VM Pool are freed manually by administrator by removing UserRole permission for the VM. Change-Id: I70e28fa20285eaa94b2b0586f07305f94b4526ee Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1234394 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_00_0640_add_stateful_to_vm_pools.sql M packaging/dbscripts/vm_pools_sp.sql 23 files changed, 177 insertions(+), 58 deletions(-) Approvals: Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/55633 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70e28fa20285eaa94b2b0586f07305f94b4526ee Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: disable reports for 4.0
by gshereme＠redhat.com 16 May '16

16 May '16

Greg Sheremeta has submitted this change and it was merged. Change subject: webadmin: disable reports for 4.0 ...................................................................... webadmin: disable reports for 4.0 Disabled reports for 4.0 * removed link from welcome page * removed the configuration for servlets that serve reports pages Change-Id: I4f49b8f9bca57829cbc549ed7d6c1e0d29e57f6a Bug-Url: https://bugzilla.redhat.com/1335199 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml M packaging/branding/ovirt.brand/welcome_page.template 3 files changed, 0 insertions(+), 42 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/57470 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f49b8f9bca57829cbc549ed7d6c1e0d29e57f6a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CpuVendor enum introduced
by ahadas＠redhat.com 16 May '16

16 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: CpuVendor enum introduced ...................................................................... core: CpuVendor enum introduced Enum of CPU vendors. Vendor is distinguished based on CPU flag. Change-Id: Id0665e889e6cac379f4e46fe5ec72edbea501cc6 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/CpuVendor.java 2 files changed, 37 insertions(+), 9 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57362 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0665e889e6cac379f4e46fe5ec72edbea501cc6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Live storage migration - replace SEAT with COCO
by laravot＠redhat.com 16 May '16

16 May '16

Liron Aravot has submitted this change and it was merged. Change subject: core: Live storage migration - replace SEAT with COCO ...................................................................... core: Live storage migration - replace SEAT with COCO This patch replaces the use of the SEAT infrastrature in the live storage migration flow with the use of the coco infra. Change-Id: I1d4f29657eb09a4b19ba930acaad1c6d84db0895 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveImageCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/CreateImagePlaceholderCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/CreateImagePlaceholderTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDisksTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveSnapshotTaskHandler.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveStorageMigrationHelper.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/SyncImageGroupDataCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/VmReplicateDiskFinishTaskHandler.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/VmReplicateDiskStartTaskHandler.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateImagePlaceholderCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LiveMigrateDiskParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LiveMigrateVmDisksParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SyncImageGroupDataCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 20 files changed, 680 insertions(+), 934 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d4f29657eb09a4b19ba930acaad1c6d84db0895 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: [SLA] Fix FindBugs issues related to global @NonNull settings
by rgolan＠redhat.com 16 May '16

16 May '16

Roy Golan has submitted this change and it was merged. Change subject: [SLA] Fix FindBugs issues related to global @NonNull settings ...................................................................... [SLA] Fix FindBugs issues related to global @NonNull settings This change allows us to apply @NonNull globally to all methods in the scheduling subpackage without breaking the build. Change-Id: I4e098b21c318d35174d0a620e465fb6a8f4f8ca9 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HaReservationBalancePolicyUnit.java 3 files changed, 14 insertions(+), 7 deletions(-) Approvals: Martin Sivák: Verified Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Jenny Tokar: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56320 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e098b21c318d35174d0a620e465fb6a8f4f8ca9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0