May 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: RunVmValidatorTest lists
by amureini＠redhat.com 16 May '16

16 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: RunVmValidatorTest lists ...................................................................... core: RunVmValidatorTest lists Use the standard Collections#singletonList for a list with a single hard-coded element instead of anonymously extending ArrayList in a difficult to understand way. Change-Id: I5bc3ad90ead11ceb69ab17676ec7398c2129b2da Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bc3ad90ead11ceb69ab17676ec7398c2129b2da Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RunVmValidatorTest strictness
by amureini＠redhat.com 16 May '16

16 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: RunVmValidatorTest strictness ...................................................................... core: RunVmValidatorTest strictness Make the canRunVmAsStateless test stricter by making sure that the vmNotInPreview validation is indeed applied to the VM in question and not just any random guid. Change-Id: I7981d421f8c2f2dbc05e98e8c74be23511b43743 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7981d421f8c2f2dbc05e98e8c74be23511b43743 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RunVmValidatorTest#mockVmPropertiesUtils exceptions
by amureini＠redhat.com 16 May '16

16 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: RunVmValidatorTest#mockVmPropertiesUtils exceptions ...................................................................... core: RunVmValidatorTest#mockVmPropertiesUtils exceptions Test set-up methods should throw exceptions if they fail to set up the test, making it error out instead of silently catching the exception and having the test fail in some hard to debug way later. Moreover, a test (or any piece of reasonable software, for that matter), should certainly not just dump the stacktrace to stderr (instead of using some proper logging framework). Change-Id: I1c8560223dad4412e28ad7f7be5f33d7965e4b85 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java 1 file changed, 3 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c8560223dad4412e28ad7f7be5f33d7965e4b85 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Optimization of DB access in REST GET vms
by ahadas＠redhat.com 16 May '16

16 May '16

Arik Hadas has submitted this change and it was merged. Change subject: restapi: Optimization of DB access in REST GET vms ...................................................................... restapi: Optimization of DB access in REST GET vms Number of DB queries for getting graphics devices within a REST GET VMS List call is constant (2). It was linear with the count of VMs before. New GetGraphicsDevicesMultipleQuery is added. The GetVmDeviceByTypeAndDevice stored procedure supports filtering and the result set is filtered on the given UUID[] vm_ids list. Index on vm_device 'type,device,alias' is added. Change-Id: I9040c0790f5b10860fbdfed6ba6e1667e5901d83 Bug-Url: https://bugzilla.redhat.com/1268216 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetGraphicsDevicesMultipleQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDaoImpl.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/DisplayHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java A packaging/dbscripts/upgrade/04_00_0640_add_index_on_vm_device.sql M packaging/dbscripts/vm_device_sp.sql 9 files changed, 160 insertions(+), 15 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50658 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9040c0790f5b10860fbdfed6ba6e1667e5901d83 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-3.6]: kickstart: Register .vv files
by lveyde＠redhat.com 16 May '16

16 May '16

Lev Veyde has submitted this change and it was merged. Change subject: kickstart: Register .vv files ...................................................................... kickstart: Register .vv files Register .vv files so they'll be opened automatically. Change-Id: Ic8ab22e0a679ffa60c94d7810a2a3124439c13bd Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1307261 --- M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8ab22e0a679ffa60c94d7810a2a3124439c13bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: kickstart: Register .vv files
by lveyde＠redhat.com 16 May '16

16 May '16

Lev Veyde has submitted this change and it was merged. Change subject: kickstart: Register .vv files ...................................................................... kickstart: Register .vv files Register .vv files so they'll be opened automatically. Change-Id: Ic8ab22e0a679ffa60c94d7810a2a3124439c13bd Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1307261 --- M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57464 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8ab22e0a679ffa60c94d7810a2a3124439c13bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: send all graphics device attrs as specParams
by tnisan＠redhat.com 16 May '16

16 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: send all graphics device attrs as specParams ...................................................................... core: send all graphics device attrs as specParams If Vdsm receives a graphic device, it doesn't look for global parameters, and checks only the device specParams. This patch makes sure we fill the specParams correctly. Change-Id: I7fbde1568785228fc83fc5315a8491ca6d117692 Bug-Url: https://bugzilla.redhat.com/1331333 Backport-To: 3.6 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 3 files changed, 31 insertions(+), 24 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Francesco Romani: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56834 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fbde1568785228fc83fc5315a8491ca6d117692 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix problematic host percentage display
by oourfali＠redhat.com 16 May '16

16 May '16

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix problematic host percentage display ...................................................................... core: fix problematic host percentage display The fencing policy checks how many hosts are in problems and prints percentage of problematic hosts in the cluster. The value printed is double and sometimes looks not friendly (for example : 77.77777777777779) This patch rounds the resulted percentage to integer. Change-Id: Ib0b73398bc58a96790e0608ca60aa88ccd5837aa Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57452 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0b73398bc58a96790e0608ca60aa88ccd5837aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Dashboard no storage
by oourfali＠redhat.com 16 May '16

16 May '16

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Dashboard no storage ...................................................................... webadmin: Dashboard no storage - The dashboard was reporting 1T for storage if none was defined. This patch now returns 0 instead of 1 and uses 1 for some calculations instead of 0 to avoid div by 0 exception. Change-Id: I1a8db87847ada5c0996744698cef02e5455576de Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/GlobalUtilizationResourceSummary.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57394 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a8db87847ada5c0996744698cef02e5455576de Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused GetMacPoolsByDataCenterIdQuery
by amureini＠redhat.com 16 May '16

16 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused GetMacPoolsByDataCenterIdQuery ...................................................................... core: Remove unused GetMacPoolsByDataCenterIdQuery This query is never used throughout the codebase. This patch removes the unused bll query, the DAO method only it uses, the underlying stored procedure used by that DAO method and the constant in VdcQueryType. Change-Id: I8c99e1dce0768f8705c52a34ac66a0ef71c34bf1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetMacPoolsByDataCenterIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MacPoolDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MacPoolDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/MacPoolDaoTest.java M packaging/dbscripts/mac_pools_sp.sql 6 files changed, 0 insertions(+), 60 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c99e1dce0768f8705c52a34ac66a0ef71c34bf1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0