May 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix NPE on import template
by ahadas＠redhat.com 16 May '16

16 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fix NPE on import template ...................................................................... core: fix NPE on import template A regression that was caused by recent refactoring lead to a NPE in the validation of ImportVmTemplateCommand. The problem was that the ImportValidator was instanciated using its empty ctor, thus the ID of the storage-pool was null when reaching the validation of mac-addresses. This patch fixes this by passing the parameters of the ImportVmTemplateCommand that contain the ID of the storage-pool to the ImportValidator. Change-Id: I133ceca9cb78a3c7bb67a967d9baba53065e7ea4 Bug-Url: https://bugzilla.redhat.com/1336405 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmTemplateParameters.java 5 files changed, 17 insertions(+), 12 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/57516 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I133ceca9cb78a3c7bb67a967d9baba53065e7ea4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: renaming plugin directory names
by stirabos＠redhat.com 16 May '16

16 May '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: packaging: renaming plugin directory names ...................................................................... packaging: renaming plugin directory names Renaming plugin directory names to improve readability. Change-Id: Ic9bc4265bd954ba0289625ec6d840022b90d2c36 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M configure.ac M po/POTFILES.in M po/pt_BR.po M src/bin/ovirt-hosted-engine-setup M src/plugins/Makefile.am R src/plugins/gr-he-common/Makefile.am R src/plugins/gr-he-common/core/Makefile.am R src/plugins/gr-he-common/core/__init__.py R src/plugins/gr-he-common/core/misc.py R src/plugins/gr-he-common/core/offlinepackager.py R src/plugins/gr-he-common/core/remote_answerfile.py R src/plugins/gr-he-common/core/vdsmconf.py R src/plugins/gr-he-common/engine/Makefile.am R src/plugins/gr-he-common/engine/__init__.py R src/plugins/gr-he-common/engine/health.py R src/plugins/gr-he-common/vm/Makefile.am R src/plugins/gr-he-common/vm/__init__.py R src/plugins/gr-he-common/vm/boot_disk.py R src/plugins/gr-he-common/vm/cloud_init.py R src/plugins/gr-he-common/vm/misc.py R src/plugins/gr-he-setup/Makefile.am R src/plugins/gr-he-setup/core/Makefile.am R src/plugins/gr-he-setup/core/__init__.py R src/plugins/gr-he-setup/core/answerfile.py R src/plugins/gr-he-setup/core/conf.py R src/plugins/gr-he-setup/core/misc.py R src/plugins/gr-he-setup/core/preview.py R src/plugins/gr-he-setup/core/shell.py R src/plugins/gr-he-setup/core/titles.py R src/plugins/gr-he-setup/engine/Makefile.am R src/plugins/gr-he-setup/engine/__init__.py R src/plugins/gr-he-setup/engine/add_host.py R src/plugins/gr-he-setup/engine/fqdn.py R src/plugins/gr-he-setup/engine/os_install.py R src/plugins/gr-he-setup/ha/Makefile.am R src/plugins/gr-he-setup/ha/__init__.py R src/plugins/gr-he-setup/ha/ha_notifications.py R src/plugins/gr-he-setup/ha/ha_services.py R src/plugins/gr-he-setup/libvirt/Makefile.am R src/plugins/gr-he-setup/libvirt/__init__.py R src/plugins/gr-he-setup/libvirt/configureqemu.py R src/plugins/gr-he-setup/network/Makefile.am R src/plugins/gr-he-setup/network/__init__.py R src/plugins/gr-he-setup/network/bridge.py R src/plugins/gr-he-setup/network/firewall.py R src/plugins/gr-he-setup/network/firewall_manager.py R src/plugins/gr-he-setup/network/gateway.py R src/plugins/gr-he-setup/network/iptables.py R src/plugins/gr-he-setup/pki/Makefile.am R src/plugins/gr-he-setup/pki/__init__.py R src/plugins/gr-he-setup/pki/vdsmpki.py R src/plugins/gr-he-setup/sanlock/Makefile.am R src/plugins/gr-he-setup/sanlock/__init__.py R src/plugins/gr-he-setup/sanlock/lockspace.py R src/plugins/gr-he-setup/storage/Makefile.am R src/plugins/gr-he-setup/storage/__init__.py R src/plugins/gr-he-setup/storage/blockd.py R src/plugins/gr-he-setup/storage/heconf.py R src/plugins/gr-he-setup/storage/nfs.py R src/plugins/gr-he-setup/storage/storage.py R src/plugins/gr-he-setup/system/Makefile.am R src/plugins/gr-he-setup/system/__init__.py R src/plugins/gr-he-setup/system/packages.py R src/plugins/gr-he-setup/system/sshd.py R src/plugins/gr-he-setup/system/vdsmenv.py R src/plugins/gr-he-setup/vdsmd/Makefile.am R src/plugins/gr-he-setup/vdsmd/__init__.py R src/plugins/gr-he-setup/vdsmd/cpu.py R src/plugins/gr-he-setup/vdsmd/vdsmconf.py R src/plugins/gr-he-setup/vm/Makefile.am R src/plugins/gr-he-setup/vm/__init__.py R src/plugins/gr-he-setup/vm/boot_cdrom.py R src/plugins/gr-he-setup/vm/configurevm.py R src/plugins/gr-he-setup/vm/cpu.py R src/plugins/gr-he-setup/vm/image.py R src/plugins/gr-he-setup/vm/mac.py R src/plugins/gr-he-setup/vm/machine.py R src/plugins/gr-he-setup/vm/memory.py R src/plugins/gr-he-setup/vm/runvm.py R src/plugins/gr-he-upgradeappliance/Makefile.am R src/plugins/gr-he-upgradeappliance/core/Makefile.am R src/plugins/gr-he-upgradeappliance/core/__init__.py R src/plugins/gr-he-upgradeappliance/core/misc.py R src/plugins/gr-he-upgradeappliance/vm/Makefile.am R src/plugins/gr-he-upgradeappliance/vm/__init__.py R src/plugins/gr-he-upgradeappliance/vm/configurevm.py R src/plugins/gr-he-upgradeappliance/vm/runvm.py 87 files changed, 876 insertions(+), 767 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57499 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9bc4265bd954ba0289625ec6d840022b90d2c36 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: upgrade: upgrade engine appliance
by stirabos＠redhat.com 16 May '16

16 May '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: upgrade: upgrade engine appliance ...................................................................... upgrade: upgrade engine appliance Introduce a new tool to let the user easily upgrade the engine appliance. Change-Id: I182e877192f647bed0fe667e87fc4bb557d3256b Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M configure.ac M man/hosted-engine.8 M man/ovirt-hosted-engine-setup.8 M ovirt-hosted-engine-setup.spec.in M po/POTFILES.in M po/pt_BR.po M src/bin/hosted-engine.in M src/bin/ovirt-hosted-engine-setup M src/ovirt_hosted_engine_setup/constants.py M src/ovirt_hosted_engine_setup/vm_status.py M src/plugins/Makefile.am A src/plugins/ovirt-hosted-engine-common/Makefile.am A src/plugins/ovirt-hosted-engine-common/core/Makefile.am A src/plugins/ovirt-hosted-engine-common/core/__init__.py A src/plugins/ovirt-hosted-engine-common/core/misc.py R src/plugins/ovirt-hosted-engine-common/core/offlinepackager.py R src/plugins/ovirt-hosted-engine-common/core/remote_answerfile.py A src/plugins/ovirt-hosted-engine-common/core/vdsmconf.py A src/plugins/ovirt-hosted-engine-common/engine/Makefile.am A src/plugins/ovirt-hosted-engine-common/engine/__init__.py R src/plugins/ovirt-hosted-engine-common/engine/health.py A src/plugins/ovirt-hosted-engine-common/vm/Makefile.am A src/plugins/ovirt-hosted-engine-common/vm/__init__.py R src/plugins/ovirt-hosted-engine-common/vm/boot_disk.py R src/plugins/ovirt-hosted-engine-common/vm/cloud_init.py A src/plugins/ovirt-hosted-engine-common/vm/misc.py M src/plugins/ovirt-hosted-engine-setup/core/Makefile.am M src/plugins/ovirt-hosted-engine-setup/core/__init__.py M src/plugins/ovirt-hosted-engine-setup/core/misc.py M src/plugins/ovirt-hosted-engine-setup/engine/Makefile.am M src/plugins/ovirt-hosted-engine-setup/engine/__init__.py M src/plugins/ovirt-hosted-engine-setup/ha/ha_services.py M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py M src/plugins/ovirt-hosted-engine-setup/vdsmd/vdsmconf.py M src/plugins/ovirt-hosted-engine-setup/vm/Makefile.am M src/plugins/ovirt-hosted-engine-setup/vm/__init__.py M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py A src/plugins/ovirt-hosted-engine-upgrade-appliance/Makefile.am A src/plugins/ovirt-hosted-engine-upgrade-appliance/core/Makefile.am A src/plugins/ovirt-hosted-engine-upgrade-appliance/core/__init__.py A src/plugins/ovirt-hosted-engine-upgrade-appliance/core/misc.py A src/plugins/ovirt-hosted-engine-upgrade-appliance/vm/Makefile.am A src/plugins/ovirt-hosted-engine-upgrade-appliance/vm/__init__.py A src/plugins/ovirt-hosted-engine-upgrade-appliance/vm/configurevm.py A src/plugins/ovirt-hosted-engine-upgrade-appliance/vm/runvm.py 45 files changed, 2,004 insertions(+), 646 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56933 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I182e877192f647bed0fe667e87fc4bb557d3256b Gerrit-PatchSet: 37 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal: variable nav bar height
by awels＠redhat.com 16 May '16

16 May '16

Alexander Wels has submitted this change and it was merged. Change subject: userportal: variable nav bar height ...................................................................... userportal: variable nav bar height Previously, the nav bar was hardcoded to take up 90px of height. When a non-extended user logged into the admin portal, they didn't have access to the nav bar to see the extended tab, but there was still 90px of whitespace there. Now we shrink the nav bar's dock panel container down to 30px when the user isn't an extended user. Also decreased 90 -> 70px. 90 was too much. Change-Id: I3019a22460d361938135498805d10bf21ac0d947 Bug-Url: https://bugzilla.redhat.com/1183741 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/MainSectionPresenter.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/MainSectionView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/MainSectionView.ui.xml 3 files changed, 29 insertions(+), 85 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/57433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3019a22460d361938135498805d10bf21ac0d947 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fixed NullPointerException in FilteredListModel
by awels＠redhat.com 16 May '16

16 May '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fixed NullPointerException in FilteredListModel ...................................................................... webadmin: fixed NullPointerException in FilteredListModel Change-Id: Ie283d670a4c80565f1fc69d86e4083f3e7a0141b Bug-Url: https://bugzilla.redhat.com/1302236 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/FilteredListModel.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/57439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie283d670a4c80565f1fc69d86e4083f3e7a0141b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal, webadmin: fixed vm lock icon positioning
by awels＠redhat.com 16 May '16

16 May '16

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: fixed vm lock icon positioning ...................................................................... userportal, webadmin: fixed vm lock icon positioning Fixed vm lock icon positioning. s/fixed/absolute/ Change-Id: Id9760a0905bc9ad2755b737fb88a46b12f69ed09 Bug-Url: https://bugzilla.redhat.com/1331079 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/57434 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9760a0905bc9ad2755b737fb88a46b12f69ed09 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fixed layout issue in Host dialogs
by awels＠redhat.com 16 May '16

16 May '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fixed layout issue in Host dialogs ...................................................................... webadmin: fixed layout issue in Host dialogs Fixed layout issue in Host and Install Host dialogs where textboxes were floating over radio buttons, making them unclickable. The problem only happened when the Bootstrap row wrapped (when the dialog was skinnier than usual). Change-Id: I65ec6aaedfcb906a97cf5e554f5787ce51437895 Bug-Url: https://bugzilla.redhat.com/1322435 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 2 files changed, 2 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/57449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65ec6aaedfcb906a97cf5e554f5787ce51437895 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddStorageDomainCommon domain names
by amureini＠redhat.com 16 May '16

16 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddStorageDomainCommon domain names ...................................................................... core: AddStorageDomainCommon domain names Use Java 8's slick way of creating a list of domain names instead of re-implementing this boilerplate logic. Change-Id: Ifbf41c9f87ae86db15f8a2d42600759f228bc783 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommon.java 1 file changed, 2 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbf41c9f87ae86db15f8a2d42600759f228bc783 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: do not monitor pool with no prestarted vms
by ahadas＠redhat.com 16 May '16

16 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: do not monitor pool with no prestarted vms ...................................................................... core: do not monitor pool with no prestarted vms Apparently, VmPoolCommandBase#getNumOfPrestartedVmsInPool is a costly method. This patch reduces calls to this method by filtering VM-pools with no prestarted-VMs from being monitored in VmPoolMonitor. Change-Id: I9a0b8ce069fc24a32ca0beaffa93757e032d0181 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/57502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a0b8ce069fc24a32ca0beaffa93757e032d0181 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RunVmValidatorTest spying
by amureini＠redhat.com 16 May '16

16 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: RunVmValidatorTest spying ...................................................................... core: RunVmValidatorTest spying Use spying instead of anonymously extending RunVmValidatorTest in order to make the code easier to read and follow. Not only does this technique follow the generally accepted practices for testing code in the project, it also sets up the groundwork for some extra strictness, provided in the following patch. Change-Id: Ia6a228bacaf52981aea635122238fd2e3b59debe Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java 1 file changed, 7 insertions(+), 19 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57493 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6a228bacaf52981aea635122238fd2e3b59debe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0