Change in ovirt-engine[ovirt-engine-4.0]: restapi: Fix lun collections in ISCSI SD
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Fix lun collections in ISCSI SD
......................................................................
restapi: Fix lun collections in ISCSI SD
When requesting an ISCSI storage domain via REST API, only one LUN
will be retrieved in case the SD have multiple LUNs.
This patch fixes the logic on the LUNS retrieval in REST API.
The following patch introduced the issue: commit 654d7de
Change-Id: Ic833809db02c2861def1da0918e95fd953205ad4
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1350343
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java
1 file changed, 11 insertions(+), 8 deletions(-)
Approvals:
Tal Nisan: Looks good to me, but someone else must approve
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/59820
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic833809db02c2861def1da0918e95fd953205ad4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: engine: IPv4AddressConverter should also convert netmask pre...
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: IPv4AddressConverter should also convert netmask prefix with leading slash
......................................................................
engine: IPv4AddressConverter should also convert netmask prefix with leading slash
IPv4AddressConverter should convert netmask prefixes both with
and without a leading hash
Change-Id: I40fc2e17319f866c9e226988e9b2ba1e4c7b1933
Bug-Url: https://bugzilla.redhat.com/1294334
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IPv4AddressConverter.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/IPv4AddressConverterTest.java
2 files changed, 13 insertions(+), 0 deletions(-)
Approvals:
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/58968
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40fc2e17319f866c9e226988e9b2ba1e4c7b1933
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: webadmin: Fix NPE when importing a registered VM
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix NPE when importing a registered VM
......................................................................
webadmin: Fix NPE when importing a registered VM
Change-Id: I7a0bc2057c7a3f96b6642df9037010371857f231
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1350203
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterEntityPopupView.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/59782
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a0bc2057c7a3f96b6642df9037010371857f231
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: core: Fix error in hot-attaching disk to VM as Virtio-ISCSI/...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix error in hot-attaching disk to VM as Virtio-ISCSI/SPAPR-SCSI
......................................................................
core: Fix error in hot-attaching disk to VM as Virtio-ISCSI/SPAPR-SCSI
Change-Id: I4a25487876c9b2481324e300d850123dc725c67a
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1350226
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/59790
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a25487876c9b2481324e300d850123dc725c67a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: webadmin: Fix ClassCastException when importing a registered VM
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix ClassCastException when importing a registered VM
......................................................................
webadmin: Fix ClassCastException when importing a registered VM
When a VM applications list was empty a bug in the process of the app list
caused the list of application to be created as a list of lists as opposed
to a list of strings
Change-Id: I52b798d94750b086f9571de88a4cc36d06e71a74
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1350200
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterVmInfoPanel.java
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/59781
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52b798d94750b086f9571de88a4cc36d06e71a74
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in mom[master]: Add GuestIoTuneOptional collector
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Add GuestIoTuneOptional collector
......................................................................
Add GuestIoTuneOptional collector
The new collector will collect the same data as GuestIoTune,
but will not prevent policy evaluation when IoTune data
are missing.
The IoTune controller was updated to handle missing data.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1346252
Change-Id: Ic05c6aa7c48a272b160ca95da95d88fe9e382884
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/59460
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Continuous-Integration: Jenkins CI
---
A mom/Collectors/GuestIoTuneOptional.py
M mom/Collectors/Makefile.am
M mom/Controllers/IoTune.py
3 files changed, 20 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/59460
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic05c6aa7c48a272b160ca95da95d88fe9e382884
Gerrit-PatchSet: 3
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Add label comboboxes to VM & host dialogs
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Add label comboboxes to VM & host dialogs
......................................................................
webadmin: Add label comboboxes to VM & host dialogs
This patch adds read-only comboboxes to the general tab of the
add/edit dialog boxes for VMs and hosts. The boxes are
populated with all available affinity labels. For existing VMs
and hosts, labels that have been set through the REST API are
shown as selected.
This is phase 1 of this feature. Phase 2 will introduce the
ability to change selected labels via the UI. Until that time,
labels can be modified via the REST API.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1338799
Change-Id: Iad36512b423a20b3ad7ad9e01ff43882555fcdb6
Signed-off-by: Phillip Bailey <phbailey(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalExistingVmModelBehavior.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml
13 files changed, 172 insertions(+), 4 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Phillip Bailey: Verified
--
To view, visit https://gerrit.ovirt.org/59256
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad36512b423a20b3ad7ad9e01ff43882555fcdb6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Add support for disk attachments update
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add support for disk attachments update
......................................................................
core: Add support for disk attachments update
Change-Id: I7ba132c7055eab48053af82ed59921dd6daef8dd
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1350207
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskAttachmentResource.java
1 file changed, 36 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59811
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ba132c7055eab48053af82ed59921dd6daef8dd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Map correctly disk interface types
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Map correctly disk interface types
......................................................................
restapi: Map correctly disk interface types
Currently the mapping of disk interfaces is implemented using string
translation, thus assuming that the names of the enums are exactly the
same in the backend and in the API. But that isn't true. This patch
changes that mapping so that it uses type safe enums.
Change-Id: I0fabd55154eb78de271cbf3805375181e144d2ea
Bug-Url: https://bugzilla.redhat.com/1349594
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 84ff17784ea1784df62bd6daf42b53c1ee3e422e)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskAttachmentMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java
3 files changed, 41 insertions(+), 40 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59808
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0fabd55154eb78de271cbf3805375181e144d2ea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Add V3 adapter for host storage
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Add V3 adapter for host storage
......................................................................
restapi: Add V3 adapter for host storage
The host storage collection and resource don't work in version 3 of the
API because the required adapters didn't exist. This patch adds it.
Change-Id: Ib39f6a5e0268b130df6d4a5139604c21428f6a0b
Bug-Url: https://bugzilla.redhat.com/1349517
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit d0f42bd20513f741bb85b361e41ce97cb61af078)
---
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3HostStoragesOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3StorageServer.java
2 files changed, 46 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59807
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib39f6a5e0268b130df6d4a5139604c21428f6a0b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months