June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: engine: Can't assign ip for a network attached to the same n...
by tnisan＠redhat.com 27 Jun '16

27 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Can't assign ip for a network attached to the same nic as mgmt ...................................................................... engine: Can't assign ip for a network attached to the same nic as mgmt The validation that caused this wrong blocking is 'networkIpAddressWasSameAsHostnameAndChanged()'. Comparing the code of the validation in the old setup network command to the new one, shows that besides the bug in the title, the old logic was changed by mistake. After rethinking about this validation we came to conclusion that the old and the new validations block cases that may be permitted by the vdsm. So we decided, for now, to remove the engine level validation. In case of a real problem, the vdsm will perform a rollback. Change-Id: Ia965a98c0a466d77238f45254f95e008145befcc Bug-Url: https://bugzilla.redhat.com/1348920 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 6 files changed, 1 insertion(+), 119 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia965a98c0a466d77238f45254f95e008145befcc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: Sync gluster servers with virt service
by tnisan＠redhat.com 27 Jun '16

27 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Sync gluster servers with virt service ...................................................................... engine: Sync gluster servers with virt service Currently the code skips syncing gluster server status as well as probing alternate interfaces if the cluster has virt service. We need to make sure that servers are not removed if virt service is enabled, but other info can be synced. Fixing with this patch Change-Id: Idf4c591284cef9a4223134bca9887cb47df5ccfe Bug-Url: https://bugzilla.redhat.com/1300095 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java 1 file changed, 45 insertions(+), 42 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Verified; Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf4c591284cef9a4223134bca9887cb47df5ccfe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: imageio: add imageio port to IPTables configuration
by tnisan＠redhat.com 26 Jun '16

26 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: imageio: add imageio port to IPTables configuration ...................................................................... imageio: add imageio port to IPTables configuration Change-Id: I97d8cf3add33caee546e24dc8f316bf619fca3ef Bug-Url: https://bugzilla.redhat.com/1350208 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/59784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97d8cf3add33caee546e24dc8f316bf619fca3ef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Allow user to create a vm from blank template on local...
by tnisan＠redhat.com 26 Jun '16

26 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Allow user to create a vm from blank template on local storage ...................................................................... core: Allow user to create a vm from blank template on local storage When user creates a new vm from blank template on local storage the vm is pinned to the one host that exists on the storage. Since the blank template is not pinned to a specific host the authorization for that action fails (the dedicated host of the vm is compared to the dedicated host of the template and since only admin is allowed to change hosts and the template is not pinned an exception is thrown). The fix is to remove the comparison of hosts in case the vm is created from a default template. Change-Id: I5f30844e3f992e4a1454e0ddeab6ae4d13591997 Bug-Url: https://bugzilla.redhat.com/1350223 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> (cherry picked from commit 4522754) Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/59709 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f30844e3f992e4a1454e0ddeab6ae4d13591997 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Allow user to create a vm from blank template on local...
by tnisan＠redhat.com 26 Jun '16

26 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Allow user to create a vm from blank template on local storage ...................................................................... core: Allow user to create a vm from blank template on local storage When user creates a new vm from blank template on local storage the vm is pinned to the one host that exists on the storage. Since the blank template is not pinned to a specific host the authorization for that action fails (the dedicated host of the vm is compared to the dedicated host of the template and since only admin is allowed to change hosts and the template is not pinned an exception is thrown). The fix is to remove the comparison of hosts in case the vm is created from a default template. Change-Id: I5f30844e3f992e4a1454e0ddeab6ae4d13591997 Bug-Url: https://bugzilla.redhat.com/1284472 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> (cherry picked from commit 4522754) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/59786 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f30844e3f992e4a1454e0ddeab6ae4d13591997 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: otopi fix for master publisher
by eedri＠redhat.com 26 Jun '16

26 Jun '16

Eyal Edri has submitted this change and it was merged. Change subject: otopi fix for master publisher ...................................................................... otopi fix for master publisher - fix otopi master to use build artifacts job Change-Id: I2099e6e7981c22a0b119768f3cdaabf75baf29e7 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/59766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2099e6e7981c22a0b119768f3cdaabf75baf29e7 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Verify that a disk exists when setting its interface.
by tnisan＠redhat.com 26 Jun '16

26 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Verify that a disk exists when setting its interface. ...................................................................... webadmin: Verify that a disk exists when setting its interface. In cases where adding a new disk to a VM, the model should add the default interface. Currently the code wants to infer the interface by the vm's disk. but since there is no disk, a NPE is thrown. Change-Id: I17d5d1232db7fd4746fa6543a67d7895e20e99f7 Bug-Url: https://bugzilla.redhat.com/1344367 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/59783 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17d5d1232db7fd4746fa6543a67d7895e20e99f7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Remove unnecessary public modifier
by tnisan＠redhat.com 26 Jun '16

26 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Remove unnecessary public modifier ...................................................................... engine: Remove unnecessary public modifier Remove unnecessary public modifier in SerialChildExecutingCommand. Change-Id: Ifbc073064fe5e8bddcfc03395d829e461454609b Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialChildExecutingCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/59679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbc073064fe5e8bddcfc03395d829e461454609b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Add gluster type to fetch server connections.
by tnisan＠redhat.com 26 Jun '16

26 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Add gluster type to fetch server connections. ...................................................................... core: Add gluster type to fetch server connections. Add gluster storage type to fetch storage server connections. Change-Id: Iab911023ff96a10e2af9e1c0131061fb74593bad Bug-Url: https://bugzilla.redhat.com/1325863 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M packaging/dbscripts/storages_sp.sql 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/59779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab911023ff96a10e2af9e1c0131061fb74593bad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Verify that a disk exists when setting its interface.
by tnisan＠redhat.com 26 Jun '16

26 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Verify that a disk exists when setting its interface. ...................................................................... webadmin: Verify that a disk exists when setting its interface. In cases where adding a new disk to a VM, the model should add the default interface. Currently the code wants to infer the interface by the vm's disk. but since there is no disk, a NPE is thrown. Change-Id: I17d5d1232db7fd4746fa6543a67d7895e20e99f7 Bug-Url: https://bugzilla.redhat.com/1344367 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59780 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17d5d1232db7fd4746fa6543a67d7895e20e99f7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0