June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Host kernel cmdline
by tnisan＠redhat.com 27 Jun '16

27 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Host kernel cmdline ...................................................................... restapi: Host kernel cmdline Host kernel cmdline API allows to inspect kernel command line currently reported by running host and customize kernel parameters that will be set during next host deploy procedure. API: host/os/reported_kernel_cmdline (ro) host/os/custom_kernel_cmdline (rw) Attampts to change host/os/cmdline/reported are silently ignored to keep compatibility with engine SDKs. Change-Id: I6c1f6b3b2fedb74b429ed0d25ba03209f2e10362 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1341268 --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java 1 file changed, 28 insertions(+), 13 deletions(-) Approvals: Jakub Niedermertl: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c1f6b3b2fedb74b429ed0d25ba03209f2e10362 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add support for disk attachments update
by tnisan＠redhat.com 27 Jun '16

27 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Add support for disk attachments update ...................................................................... core: Add support for disk attachments update Change-Id: I7ba132c7055eab48053af82ed59921dd6daef8dd Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1350207 --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskAttachmentResource.java 1 file changed, 36 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57838 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ba132c7055eab48053af82ed59921dd6daef8dd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Map correctly disk interface types
by juan.hernandez＠redhat.com 27 Jun '16

27 Jun '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Map correctly disk interface types ...................................................................... restapi: Map correctly disk interface types Currently the mapping of disk interfaces is implemented using string translation, thus assuming that the names of the enums are exactly the same in the backend and in the API. But that isn't true. This patch changes that mapping so that it uses type safe enums. Change-Id: I0fabd55154eb78de271cbf3805375181e144d2ea Bug-Url: https://bugzilla.redhat.com/1349594 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskAttachmentMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java 3 files changed, 41 insertions(+), 40 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fabd55154eb78de271cbf3805375181e144d2ea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Always populate V3 disk interface and bootable
by juan.hernandez＠redhat.com 27 Jun '16

27 Jun '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Always populate V3 disk interface and bootable ...................................................................... restapi: Always populate V3 disk interface and bootable Currently the V3 disk interface and bootable attributes are only populated with a disk is retrieved, but it isn't populated for disk objects returned by the "add" or "update" operations. To fix that this patch moves the code that populates these attributes from the implementation of the "get" operation to the adapter that transforms all output disk objects. Change-Id: I17634e05969ca826ae9a1c7aa08d9bfcfe0ef620 Bug-Url: https://bugzilla.redhat.com/1349594 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDiskServer.java 2 files changed, 28 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59731 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17634e05969ca826ae9a1c7aa08d9bfcfe0ef620 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add V3 adapter for host storage
by juan.hernandez＠redhat.com 27 Jun '16

27 Jun '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add V3 adapter for host storage ...................................................................... restapi: Add V3 adapter for host storage The host storage collection and resource don't work in version 3 of the API because the required adapters didn't exist. This patch adds it. Change-Id: Ib39f6a5e0268b130df6d4a5139604c21428f6a0b Bug-Url: https://bugzilla.redhat.com/1349517 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3HostStoragesOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3StorageServer.java 2 files changed, 46 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59719 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib39f6a5e0268b130df6d4a5139604c21428f6a0b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix lun collections in ISCSI SD
by juan.hernandez＠redhat.com 27 Jun '16

27 Jun '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix lun collections in ISCSI SD ...................................................................... restapi: Fix lun collections in ISCSI SD When requesting an ISCSI storage domain via REST API, only one LUN will be retrieved in case the SD have multiple LUNs. This patch fixes the logic on the LUNS retrieval in REST API. The following patch introduced the issue: commit 654d7de Change-Id: Ic833809db02c2861def1da0918e95fd953205ad4 Signed-off-by: Fred Rolland <frolland(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1350343 --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java 1 file changed, 11 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/59800 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic833809db02c2861def1da0918e95fd953205ad4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Marking VMs in stateless VM Pools as stateless
by tnisan＠redhat.com 27 Jun '16

27 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Marking VMs in stateless VM Pools as stateless ...................................................................... core: Marking VMs in stateless VM Pools as stateless Previously, vm_static.is_stateless field was not used for pooled VMs. This led to confusing results - when one uses REST API to get information about a VM from a VM Pool, the REST API returns <stateless>false</stateless>, while indeed all VMs in a stateless pool are stateless. Webadmin UI also incorrectly displays "Is Stateless: False" for these VM. This patch adds setting is_stateless=true for all VMs created in a stateless VM Pool and updates this field for all pooled VMs created earlier. Change-Id: I90da0c0877a471435e32837a4798e6f1a4e8205f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1318955 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/upgrade/04_00_0770_set_pool_vms_stateless.sql 10 files changed, 8 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified -- To view, visit https://gerrit.ovirt.org/59564 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90da0c0877a471435e32837a4798e6f1a4e8205f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Refactor RemoveDisksSnapshot Callback
by laravot＠redhat.com 27 Jun '16

27 Jun '16

Liron Aravot has submitted this change and it was merged. Change subject: engine: Refactor RemoveDisksSnapshot Callback ...................................................................... engine: Refactor RemoveDisksSnapshot Callback Removed DiskSnapshotsCommandCallback, and use SerialChildCommandsExecutionCallback instead. Change RemoveDiskSnapshotsCommand to implement SerialChildExecutingCommand methods. Change-Id: I828a52ec30f318ada0084985d350ba124550ba97 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommandCallback.java 2 files changed, 14 insertions(+), 75 deletions(-) Approvals: Freddy Rolland: Verified Ala Hino: Looks good to me, but someone else must approve Liron Aravot: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/56724 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I828a52ec30f318ada0084985d350ba124550ba97 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Refactor RemoveSnapshotSingleDiskLive CB
by laravot＠redhat.com 27 Jun '16

27 Jun '16

Liron Aravot has submitted this change and it was merged. Change subject: engine: Refactor RemoveSnapshotSingleDiskLive CB ...................................................................... engine: Refactor RemoveSnapshotSingleDiskLive CB In this patch we use SerialChildCommandsExecutionCallback for the RemoveSnapshotSingleDiskLiveCommandCallback. In the command we removed the handling the execution states, leaving it to the generic callback. Change-Id: I1f7ad5fdabed323ea6804c4ca8484f448061e88b Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskLiveCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskLiveCommandCallback.java 2 files changed, 38 insertions(+), 67 deletions(-) Approvals: Jenkins CI: Passed CI tests Freddy Rolland: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f7ad5fdabed323ea6804c4ca8484f448061e88b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Support Katello 3.x version
by tnisan＠redhat.com 27 Jun '16

27 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Support Katello 3.x version ...................................................................... engine: Support Katello 3.x version In addition to Katello 2.1, the Katello 3.1 support is added to ovirt-engine. In order to detect the Katello version, an api call for /api/v2/status will be sent, and by the return value, the provider version is detected: 1. 1.11 and above - Katello 3.1 2. less than 1.11 - Katello 2 Change-Id: I36dfcd325a199294cb1a8e281ccccadbd13607b3 Bug-Url: https://bugzilla.redhat.com/1346263 Bug-Url: https://bugzilla.redhat.com/1348449 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/ContentHostProvider.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/HostProviderProxy.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ContentHostV30.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ContentHostsV30Wrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/KatelloProvider.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/KatelloV21Provider.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/KatelloV30Provider.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ReportedForemanStatus.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/SystemProviderFinder.java 10 files changed, 366 insertions(+), 115 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/59777 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36dfcd325a199294cb1a8e281ccccadbd13607b3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0