June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Alert for disconnected gluster peer
by sabose＠redhat.com 22 Jun '16

22 Jun '16

Sahina Bose has submitted this change and it was merged. Change subject: engine: Alert for disconnected gluster peer ...................................................................... engine: Alert for disconnected gluster peer Show an alert when a gluster peer is in disconnected state, with a link to restart glusterd Change-Id: I97f19a6f8b062b4a09036189eae06a3bf72dbee7 Bug-Url: https://bugzilla.redhat.com/1262046 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/PeerStatus.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralInfoPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/HostStatusCell.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages.properties M packaging/dbscripts/create_views.sql 10 files changed, 88 insertions(+), 6 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Sahina Bose: Verified Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59403 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97f19a6f8b062b4a09036189eae06a3bf72dbee7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Remove extra input field
by awels＠redhat.com 21 Jun '16

21 Jun '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Remove extra input field ...................................................................... webadmin: Remove extra input field - For some reason we were using an input field/label combination as a label and not hiding the input field. This patch switches it to a label that takes the state of the associated field into account to enable/disable the label. Change-Id: Ib869feccfa740d832ed2e3ba7aec35f8996cb74f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1346299 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 2 files changed, 6 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59561 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib869feccfa740d832ed2e3ba7aec35f8996cb74f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fill name in hosts
by awels＠redhat.com 21 Jun '16

21 Jun '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fill name in hosts ...................................................................... webadmin: fill name in hosts - Fixed issue where turning on foreman/satellite would not populate the discovered host name. Change-Id: Ifef6c75b64fbd066c6e14623182642cd85be4a30 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1346299 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifef6c75b64fbd066c6e14623182642cd85be4a30 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: dashboard: Optimize VM status query
by awels＠redhat.com 21 Jun '16

21 Jun '16

Alexander Wels has submitted this change and it was merged. Change subject: dashboard: Optimize VM status query ...................................................................... dashboard: Optimize VM status query - the vm_samples_history table will grow significantly every minute (number of VMs each time). This made the original query slow as it needs to go through the entire table to lookup the right history_id. I modified the query to first filter on time frame, and then select the latest history_id from the filtered set. The query now takes < 100ms. - Made similar changes to the top 10 cpu/mem/storage vm lookup to filter by timeframe as significantly reducing the query time. - Verified all other queries are fast in a scale environment. - Note all the queries are using the DWH views and one of those views is missing an index on vm_id and history_datetime. These will not be fast unless that index is added. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1345934 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1345947 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1345944 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1344428 Change-Id: I834e3231c72fb3f0bcbadb67870c143bfb98c69e Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/StorageDomainDwhDAO.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/VmDwhDAO.properties 2 files changed, 73 insertions(+), 68 deletions(-) Approvals: Shirly Radco: Looks good to me, but someone else must approve Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59089 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I834e3231c72fb3f0bcbadb67870c143bfb98c69e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: restricting the job to only run on physical hosts
by eedri＠redhat.com 21 Jun '16

21 Jun '16

Eyal Edri has submitted this change and it was merged. Change subject: restricting the job to only run on physical hosts ...................................................................... restricting the job to only run on physical hosts - Lago jobs can run only on fc23 BM for now Change-Id: Ic2710c279c2ae6deffb52b180a8918002743dacb Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-system-tests/ovirt-system-tests_standard.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2710c279c2ae6deffb52b180a8918002743dacb Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: 403 returned when console can't be stolen
by tnisan＠redhat.com 21 Jun '16

21 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: 403 returned when console can't be stolen ...................................................................... restapi: 403 returned when console can't be stolen HTTP status code changed from 500 to 403 when user asks for vv file and the console is already assigned to other user and user don't have sufficient permissions to steal the console. The reason is to indicate that it's not a server problem but rather permission/state issue. Change-Id: I72a9c9e0e84f8ca5253eb09cb447b88a4f55d4ce Bug-Url: https://bugzilla.redhat.com/1305600 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsoleResource.java 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72a9c9e0e84f8ca5253eb09cb447b88a4f55d4ce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Remove completely the 'capabilities' collection
by tnisan＠redhat.com 21 Jun '16

21 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Remove completely the 'capabilities' collection ...................................................................... restapi: Remove completely the 'capabilities' collection In version 4 of the API the top level 'capabilities' collection was removed, and replaced by the new 'clusterlevels' collection. This patch completes the cleanup, removing all the code that was used to implement the 'capabilities' collection. Change-Id: Ic2176623fe97971ae3848c4cfadd8b167201dc70 Bug-Url: https://bugzilla.redhat.com/1347157 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit d73031afa9f5101c0d7eba836dd6a4ef3ed4475e) --- D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/CapabilitiesResource.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/CapabiliyResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilityResource.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java D backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResourceTest.java D backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilityResourceTest.java 10 files changed, 2 insertions(+), 3,140 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2176623fe97971ae3848c4cfadd8b167201dc70 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Update to model 4.0.23
by tnisan＠redhat.com 21 Jun '16

21 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Update to model 4.0.23 ...................................................................... restapi: Update to model 4.0.23 The more relevant changes in this new version of the model are the following: * Add `Update` method to the `DiskAttachment` service. * Add types and services for cluster levels support. Change-Id: I8b1b5bd357d64292cdc4c87904a477bfacb1e81a Related-To: https://bugzilla.redhat.com/1347157 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit c4a29338cb49bb1b088425579bc27602d95d6e0a) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskAttachmentResource.java M pom.xml 3 files changed, 14 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/59548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b1b5bd357d64292cdc4c87904a477bfacb1e81a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Add cluster levels support
by tnisan＠redhat.com 21 Jun '16

21 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Add cluster levels support ...................................................................... restapi: Add cluster levels support The top level 'capabilities' collection has been replaced by the new 'clusterlevels' collection. This new collection will contain the information that isn't available in the model, like the list of CPU types available for each cluster level: GET /clusterlevels This will return a list of `ClusterLevel` objects containing the details for all the cluster levels supported by the system: <cluster_levels> <cluster_level id="3.6" href="/clusterlevels/3.6"> <cpu_types> <cpu_type> <name>Intel Conroe Family</name> <level>2</level> <architecture>x86_64</architecture> </cpu_type> ... </cpu_types> ... </cluster_level> </cluster_levels> Each specific cluster level has it's own subresource, identified by the version itself: GET /clusterlevels/3.6 This will return the details of that version: <cluster_level id="3.6" href="/clusterlevels/3.6"> <cpu_types> <cpu_type> <name>Intel Conroe Family</name> <level>2</level> <architecture>x86_64</architecture> </cpu_type> ... </cpu_types> ... </cluster_level> Change-Id: Ifcd16aa01e2e8e959fdd25977e21b154e949d934 Bug-Url: https://bugzilla.redhat.com/1347157 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit cdc3e2a46be6d26af6c94b32f947b4a5427eb666) --- M backend/manager/modules/restapi/README.adoc M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ApiRootLinksCreator.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterLevelResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterLevelsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3ApiOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java 8 files changed, 241 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcd16aa01e2e8e959fdd25977e21b154e949d934 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: adding standard ci for ovirt-system-tests
by eedri＠redhat.com 21 Jun '16

21 Jun '16

Eyal Edri has submitted this change and it was merged. Change subject: adding standard ci for ovirt-system-tests ...................................................................... adding standard ci for ovirt-system-tests Change-Id: Icb4b885e269906613e6646b984b52c8ee380b55b Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- A jobs/confs/projects/ovirt-system-tests/ovirt-system-tests_standard.yaml 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59556 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb4b885e269906613e6646b984b52c8ee380b55b Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0