Change in ovirt-engine[master]: core: DiskImagesValidatorTest disk aliases
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: DiskImagesValidatorTest disk aliases
......................................................................
core: DiskImagesValidatorTest disk aliases
Used Java 8's new streaming APIs to collect an array of DiskImages to a
validation message instead of re-implementing the same logic with a
StringBuilder.
Change-Id: I6547779e8ae194b406e412d0533e4b461ba8318d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidatorTest.java
1 file changed, 2 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59590
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6547779e8ae194b406e412d0533e4b461ba8318d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: DiskImagesValidatorTest consistent assertions
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: DiskImagesValidatorTest consistent assertions
......................................................................
core: DiskImagesValidatorTest consistent assertions
Use the modern assertThat throughout the code instead of mixing
assertion styles.
Change-Id: I16ab305da0fe750a422f1ca0561558c0b91970a9
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidatorTest.java
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/59589
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16ab305da0fe750a422f1ca0561558c0b91970a9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: DiskImagesValidatorTest type inference
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: DiskImagesValidatorTest type inference
......................................................................
core: DiskImagesValidatorTest type inference
Change-Id: I5c166c2ba6dcb2b1830008aa5bf25efeeef9d0b0
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidatorTest.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/59586
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c166c2ba6dcb2b1830008aa5bf25efeeef9d0b0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: DiskImagesValidatorTest collections
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: DiskImagesValidatorTest collections
......................................................................
core: DiskImagesValidatorTest collections
Use Collections#singletonList instead of Arrays#asList with a single
element for a [minor] performance improvement.
Change-Id: Ic9fb63e7872f346c01fa980eb108b5a067b60a67
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidatorTest.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/59588
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9fb63e7872f346c01fa980eb108b5a067b60a67
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: Handling copied template disks for unregistered disks.
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Handling copied template disks for unregistered disks.
......................................................................
core: Handling copied template disks for unregistered disks.
Drop unique foreign key in unregistered_disks of disk_id since copied
template disks might not follow the unique key.
Instead added a column of storage_domain_id in unregistered_disks_to_vms
so it will support the foreign key for unregistered_disks.
Change-Id: Ic7ba0fa8caecbbd9ffe62ff45fab075dd01af03c
Bug-Url: https://bugzilla.redhat.com/1302780
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredDisksDaoImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/unregistered_disks_sp.sql
A packaging/dbscripts/upgrade/04_01_0090_drop_unique_constraint.sql
4 files changed, 38 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/59438
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7ba0fa8caecbbd9ffe62ff45fab075dd01af03c
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: Disable testing of unregistered shared disks.
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Disable testing of unregistered shared disks.
......................................................................
core: Disable testing of unregistered shared disks.
Remove support for shared disks since OVF does not support
shared disks as part of the VM configuration
Change-Id: I095a4e97d5eae922369e898189c58eedf242a987
Bug-Url: https://bugzilla.redhat.com/1302780
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredDisksDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
2 files changed, 3 insertions(+), 47 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/59473
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I095a4e97d5eae922369e898189c58eedf242a987
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: fix UploadDiskModel validation and flush.
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: fix UploadDiskModel validation and flush.
......................................................................
webadmin: fix UploadDiskModel validation and flush.
Currently, the validation of the model gets a parameter that determines
if the object's diskModel validation will be called. When starting the
upload, this function is called 2 times, once when flushing, then before
starting the upload.
In case that the diskModel validation failed, it didn't flush, causing
an NPE when calling onUpload() without filling the needed fields- as the
diskModel validation is not called before flushing.
This patch makes the validation always call to the diskModel validation,
and makes flush() to return false if the model wasn't able to flush.
Change-Id: I2fc1942ffffd60254d1344fce582afbb6562c697
Bug-Url: https://bugzilla.redhat.com/1328887
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
1 file changed, 15 insertions(+), 22 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/59456
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fc1942ffffd60254d1344fce582afbb6562c697
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: hide Interface selectbox when resuming upload
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: hide Interface selectbox when resuming upload
......................................................................
webadmin: hide Interface selectbox when resuming upload
Resuming an upload will always be performed on disks that aren't
attached to a VM, therefore the "Interface" selectbox is not relevant in
that scenario.
Change-Id: I0db01d9360c703b95a0d762ba35f961dbc7f1798
Bug-Url: https://bugzilla.redhat.com/1328887
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/59455
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0db01d9360c703b95a0d762ba35f961dbc7f1798
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Restore DataCenter#macPool
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Restore DataCenter#macPool
......................................................................
restapi: Restore DataCenter#macPool
The `macPool` attribute of the `DataCenter` type was removed because it
was going to be replaced by the `macPool` attribute of the `Cluster`
type, but that change wasn't finally introduced in the initial release
of version 4 fo the engine, so the original attribute needs to be
re-introduced in order to preserve support for MAC pools.
Change-Id: I17fe6fbc95e77b997bdb914f315664304eac3edc
Bug-Url: https://bugzilla.redhat.com/1344284
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit bf0851e128afe1340ff81b607f298f92d9ec0f86)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DataCenterInAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DataCenterOutAdapter.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DataCenterMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DataCenterMapperTest.java
4 files changed, 17 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59557
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I17fe6fbc95e77b997bdb914f315664304eac3edc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: dashboard: Optimize VM status query
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: dashboard: Optimize VM status query
......................................................................
dashboard: Optimize VM status query
- the vm_samples_history table will grow significantly every
minute (number of VMs each time). This made the original
query slow as it needs to go through the entire table to
lookup the right history_id. I modified the query to first
filter on time frame, and then select the latest history_id
from the filtered set. The query now takes < 100ms.
- Made similar changes to the top 10 cpu/mem/storage vm lookup
to filter by timeframe as significantly reducing the query time.
- Verified all other queries are fast in a scale environment.
- Note all the queries are using the DWH views and one of those
views is missing an index on vm_id and history_datetime. These
will not be fast unless that index is added.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1345934
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1345947
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1345944
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1344428
Change-Id: I834e3231c72fb3f0bcbadb67870c143bfb98c69e
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/StorageDomainDwhDAO.properties
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/VmDwhDAO.properties
2 files changed, 73 insertions(+), 68 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/59570
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I834e3231c72fb3f0bcbadb67870c143bfb98c69e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months