June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Make DiskModel's default interface not abstract.
by tnisan＠redhat.com 22 Jun '16

22 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Make DiskModel's default interface not abstract. ...................................................................... webadmin: Make DiskModel's default interface not abstract. Disk's interface has nothing to do with the kind of Model inherited from AbstractDiskModel (e.g NewDiskModel, EditDiskModel, ReadOnlyDiskModel). If a disk is attached to a VM, the model should retrieve the right interface. otherwise, it should just take a default one. The current implementation also caused an error in ReadOnlyDiskModel, when resuming an upload. The model tried to retrieve the selected interface, but since the disk was not attached to a VM, an error was thrown. Change-Id: I0e85d980e130a973a865a54eb82758b8f8e30dfb Bug-Url: https://bugzilla.redhat.com/1344367 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ReadOnlyDiskModel.java 4 files changed, 8 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, but someone else must approve Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/59327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e85d980e130a973a865a54eb82758b8f8e30dfb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Disable testing of unregistered shared disks.
by tnisan＠redhat.com 22 Jun '16

22 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Disable testing of unregistered shared disks. ...................................................................... core: Disable testing of unregistered shared disks. Remove support for shared disks since OVF does not support shared disks as part of the VM configuration Change-Id: I095a4e97d5eae922369e898189c58eedf242a987 Bug-Url: https://bugzilla.redhat.com/1302780 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredDisksDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 2 files changed, 3 insertions(+), 47 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/59593 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I095a4e97d5eae922369e898189c58eedf242a987 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Handling copied template disks for unregistered disks.
by tnisan＠redhat.com 22 Jun '16

22 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Handling copied template disks for unregistered disks. ...................................................................... core: Handling copied template disks for unregistered disks. Drop unique foreign key in unregistered_disks of disk_id since copied template disks might not follow the unique key. Instead added a column of storage_domain_id in unregistered_disks_to_vms so it will support the foreign key for unregistered_disks. Change-Id: Ic7ba0fa8caecbbd9ffe62ff45fab075dd01af03c Bug-Url: https://bugzilla.redhat.com/1302780 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredDisksDaoImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/unregistered_disks_sp.sql A packaging/dbscripts/upgrade/04_00_0760_drop_unique_constraint.sql 4 files changed, 38 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/59594 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7ba0fa8caecbbd9ffe62ff45fab075dd01af03c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: comma separated list of values in search
by emesika＠redhat.com 22 Jun '16

22 Jun '16

Eli Mesika has submitted this change and it was merged. Change subject: core: comma separated list of values in search ...................................................................... core: comma separated list of values in search Add metadata in search engine that enables to support column values that actually includes comma separated lists of values For example, if a ISO storage is attached to 2 DCs : dc1 and dc2 then in the storage_domains_for_search view the column datacenter value is "dc1,dc2" , current search syntax will search for 'dc1' or 'dc2' from the tree view and will give no results. The same applies for a disk that is shared by 2 VMs vm2 and vm2 when searching from the disk tab for vm_names with 'vm1' or 'vm2' This patch adds an option to add metadata that enabled to define per table/view a list of columns that have actually comma separated values as "dc1,dc2" or "vm1,vm2" in the examples above. Once this metadata is added, the search engine will build the proper SQL to match any of the comma separated values. Change-Id: Ie0fa048b1d12392f1c1ea81ed720be6c4078f7d0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1320774 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/IConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 6 files changed, 45 insertions(+), 9 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0fa048b1d12392f1c1ea81ed720be6c4078f7d0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Fix adding of quota storage limits
by tnisan＠redhat.com 22 Jun '16

22 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix adding of quota storage limits ...................................................................... restapi: Fix adding of quota storage limits The quota limit resources use inheritance and generics in order to avoid implementing the "add" operation twice, once for cluster limits and another time for storage limits. Unfortunately the JAX-RS implementation that we use doesn't recognize these generic "add" operations, resulting in a 405 error message when they are used. To avoid that error this patch refactors the relevant resources so that they don't use inheritance and generics. The result is more verbose, but simpler, and works. Change-Id: I4ee930ecbf6bd6d477f3746eaa409082688cd5a4 Bug-Url: https://bugzilla.redhat.com/1348559 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 1500465386f3e6d391d8a6a33d232be423cf46c0) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaClusterLimitsResource.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaLimitsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaStorageLimitsResource.java 3 files changed, 74 insertions(+), 72 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ee930ecbf6bd6d477f3746eaa409082688cd5a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: ovirt-engine-notifier : Add support for SNMPv3 traps
by tnisan＠redhat.com 22 Jun '16

22 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: ovirt-engine-notifier : Add support for SNMPv3 traps ...................................................................... ovirt-engine-notifier : Add support for SNMPv3 traps Add support to send SNMPv3 traps from ovirt-engine-notification service. New config variables SNMP_VERSION, SNMP_ENGINE_ID, SNMP_USERNAME, SNMP_AUTH_PASSPHRASE, SNMP_PRIVACY_PASSPHRASE, SNMP_SECURITY_LEVEL, SNMP_AUTH_PROTOCOL and SNMP_PRIVACY_PROTOCOL can be configured to send SNMPv3 traps. net-snmp supports MD5 and SHA auth protocols and AES128 privacy protocol. Change-Id: I5a47f16eaf1d5461f223d514383a26f5696ba255 Bug-Url: https://bugzilla.redhat.com/1268133 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit eb6de31da7c6193950b078e4271edfa038784d8e) --- M backend/manager/dependencies/common/src/main/modules/org/snmp4j/main/module.xml M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/transport/snmp/ProfileTest.java M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 4 files changed, 292 insertions(+), 61 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a47f16eaf1d5461f223d514383a26f5696ba255 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: aaa: My Groups in Add Permission to User dialog throws NPE
by tnisan＠redhat.com 22 Jun '16

22 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: aaa: My Groups in Add Permission to User dialog throws NPE ...................................................................... aaa: My Groups in Add Permission to User dialog throws NPE My Groups in Add Permissions dialog should invoke SSO authz search with the user's external id. The SSO DirectorySearch should search all namespaces for the user. Change-Id: I7f21217df77db1a7ad9672ce200cfd0217ee0608 Bug-Url: https://bugzilla.redhat.com/1346932 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit a5726e93673e61506ea2bd3991c99532759543cf) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/CreateUserSessionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDirectoryGroupsForUserQuery.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/search/DirectorySearch.java 3 files changed, 15 insertions(+), 7 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f21217df77db1a7ad9672ce200cfd0217ee0608 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix adding of quota storage limits
by juan.hernandez＠redhat.com 22 Jun '16

22 Jun '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix adding of quota storage limits ...................................................................... restapi: Fix adding of quota storage limits The quota limit resources use inheritance and generics in order to avoid implementing the "add" operation twice, once for cluster limits and another time for storage limits. Unfortunately the JAX-RS implementation that we use doesn't recognize these generic "add" operations, resulting in a 405 error message when they are used. To avoid that error this patch refactors the relevant resources so that they don't use inheritance and generics. The result is more verbose, but simpler, and works. Change-Id: I4ee930ecbf6bd6d477f3746eaa409082688cd5a4 Bug-Url: https://bugzilla.redhat.com/1348559 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaClusterLimitsResource.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaLimitsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaStorageLimitsResource.java 3 files changed, 74 insertions(+), 72 deletions(-) Approvals: Juan Hernandez: Verified; Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59555 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ee930ecbf6bd6d477f3746eaa409082688cd5a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: My Groups in Add Permission to User dialog throws NPE
by mperina＠redhat.com 22 Jun '16

22 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: aaa: My Groups in Add Permission to User dialog throws NPE ...................................................................... aaa: My Groups in Add Permission to User dialog throws NPE My Groups in Add Permissions dialog should invoke SSO authz search with the user's external id. The SSO DirectorySearch should search all namespaces for the user. Change-Id: I7f21217df77db1a7ad9672ce200cfd0217ee0608 Bug-Url: https://bugzilla.redhat.com/1346932 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/CreateUserSessionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDirectoryGroupsForUserQuery.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/search/DirectorySearch.java 3 files changed, 15 insertions(+), 7 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59563 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f21217df77db1a7ad9672ce200cfd0217ee0608 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DiskImagesValidatorTest assertion order
by amureini＠redhat.com 22 Jun '16

22 Jun '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: DiskImagesValidatorTest assertion order ...................................................................... core: DiskImagesValidatorTest assertion order Fix the order of arguments in assertEquals call so they will print the correct error message in case the test fails. Change-Id: I306cceb90194752ea93ed165778f7ecb14eccd2e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidatorTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/59587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I306cceb90194752ea93ed165778f7ecb14eccd2e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0