Change in ovirt-engine[ovirt-engine-4.0]: packaging: spec: Require ovirt-imageio-proxy-setup
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: spec: Require ovirt-imageio-proxy-setup
......................................................................
packaging: spec: Require ovirt-imageio-proxy-setup
Make the engine plugin of engine-setup require
ovirt-imageio-proxy-setup.
Change-Id: I402b6896bf1da810ad2a0650219f46e9b2f6e4ac
Bug-Url: https://bugzilla.redhat.com/1365744
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit dcb12b888d6f35258883e540c68a09974d1c03c5)
---
M ovirt-engine.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/62364
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I402b6896bf1da810ad2a0650219f46e9b2f6e4ac
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
8 years, 1 month
Change in ovirt-engine[master]: packaging: spec: Require ovirt-imageio-proxy-setup
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: Require ovirt-imageio-proxy-setup
......................................................................
packaging: spec: Require ovirt-imageio-proxy-setup
Make the engine plugin of engine-setup require
ovirt-imageio-proxy-setup.
Change-Id: I402b6896bf1da810ad2a0650219f46e9b2f6e4ac
Bug-Url: https://bugzilla.redhat.com/1365744
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Amit Aviram: Looks good to me, but someone else must approve
Rafael Martins: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/62356
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I402b6896bf1da810ad2a0650219f46e9b2f6e4ac
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: core: Block cluster version change when Snapshot in Preview
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Block cluster version change when Snapshot in Preview
......................................................................
core: Block cluster version change when Snapshot in Preview
Block cluster version change in UpdateClusterVersion
when there is a VM snapshot in preview.
The webadmin shows list such VM names after Cluster Edit dialog.
Change-Id: Ie929a303805fda75ff32111a57ad142fd30726d1
Bug-Url: https://bugzilla.redhat.com/1356027
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 19 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Marek Libra: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/61977
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie929a303805fda75ff32111a57ad142fd30726d1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: engine : Compensation context data is cleared although the d...
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: engine : Compensation context data is cleared although the data wasn't reverted on parent-child command scenario
......................................................................
engine : Compensation context data is cleared although the data wasn't reverted on parent-child command scenario
Compensation should be performed and
the data should be cleared only
if there is compensation data for the
command.
Change-Id: Id49c6206cfcc5216e907d8445e8c091af3c68a94
Bug-Url: https://bugzilla.redhat.com/1364804
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CompensationContext.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/DefaultCompensationContext.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/NoOpCompensationContext.java
4 files changed, 24 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/62194
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id49c6206cfcc5216e907d8445e8c091af3c68a94
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: webadmin: re-enlarge the create snapshot message dialog
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: re-enlarge the create snapshot message dialog
......................................................................
webadmin: re-enlarge the create snapshot message dialog
In case there are no disks allowing a snapshot for the VM, the message
panel size should be enlarged to contain the following two messages:
"Could not detect Guest Agent on the VM. Note that without a Guest Agent
the data on the created snapshot may be inconsistent.
There are no disks allowing a snapshot, only the configuration will be a
part of the VM snapshot.".
And therefore the whole dialog should be enlarged also.
Change-Id: Ib28fad0bbaea9dc16163a9f0ecd71f35668762a6
Bug-Url: https://bugzilla.redhat.com/1360914
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.ui.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmSnapshotCreatePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmSnapshotCreatePopupView.java
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/62323
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib28fad0bbaea9dc16163a9f0ecd71f35668762a6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: webadmin: v2v- kvm username and password are not mandatory
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: v2v- kvm username and password are not mandatory
......................................................................
webadmin: v2v- kvm username and password are not mandatory
The user, password fields are no longer mandatory.
This is supported by adding a checkbox named "authenticaton requires"
as exists in the external providers dialog.
The user name validation rules are also changed by ommiting the check
for special chars and domain.
Furthermore, add a tooltip with a short explanation on the KVM URI field.
Change-Id: I807559e74d18dd37f746b5f4eface1850f4cd6f0
Bug-Url: https://bugzilla.redhat.com/1351542
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.ui.xml
4 files changed, 59 insertions(+), 5 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/62192
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I807559e74d18dd37f746b5f4eface1850f4cd6f0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[ovirt-engine-4.0]: engine : engine startup fails if command ctor fails
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine : engine startup fails if command ctor fails
......................................................................
engine : engine startup fails if command ctor fails
When commands are reloaded after
engine restart, failure in command
constructor should be handled gracefully
by Command Coordinator framework.
Change-Id: Ie4b7dbe65744a62df69891a2281f0c7ebffa5b03
Bug-Url: https://bugzilla.redhat.com/1360378
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCallbacksPoller.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsRepository.java
3 files changed, 20 insertions(+), 15 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Ravi Nori: Verified
Moti Asayag: Looks good to me, approved
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/62351
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4b7dbe65744a62df69891a2281f0c7ebffa5b03
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: packaging: setup: Enroll missing pki on upgrade
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Enroll missing pki on upgrade
......................................................................
packaging: setup: Enroll missing pki on upgrade
Without this patch, imageio-proxy pki will not be generated on upgrade
from 3.6, because it did not exist then.
Change-Id: I67669b0b81e87690ff31d90247d803f175423fe8
Bug-Url: https://bugzilla.redhat.com/1365451
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
1 file changed, 9 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
Amit Aviram: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/62307
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67669b0b81e87690ff31d90247d803f175423fe8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: engine : engine startup fails if command ctor fails
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine : engine startup fails if command ctor fails
......................................................................
engine : engine startup fails if command ctor fails
When commands are reloaded after
engine restart, failure in command
constructor should be handled gracefully
by Command Coordinator framework.
Change-Id: Ie4b7dbe65744a62df69891a2281f0c7ebffa5b03
Bug-Url: https://bugzilla.redhat.com/1360378
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCallbacksPoller.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsRepository.java
3 files changed, 20 insertions(+), 15 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Ravi Nori: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Arik Hadas: Looks good to me, but someone else must approve
Liron Aravot: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/61563
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4b7dbe65744a62df69891a2281f0c7ebffa5b03
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Enforce Clone for template import without base
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: Enforce Clone for template import without base
......................................................................
webadmin: Enforce Clone for template import without base
Import of a template without existing base template has to be
performed by cloning.
Enforced on front-end.
Change-Id: I1d1168daaab129a37dc8b31945214fc38a1624cd
Bug-Url: https://bugzilla.redhat.com/1328725
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportEntityData.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
4 files changed, 27 insertions(+), 5 deletions(-)
Approvals:
Piotr Kliczewski: Passed CI tests
Tomas Jelinek: Looks good to me, approved
Marek Libra: Verified
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/61891
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d1168daaab129a37dc8b31945214fc38a1624cd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month