August 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix possible deadlock
by rgolan＠redhat.com 17 Aug '16

17 Aug '16

Roy Golan has submitted this change and it was merged. Change subject: core: fix possible deadlock ...................................................................... core: fix possible deadlock VmsMonitoring.analyzeVms() method takes a lock for each VM, which will not be unlocked when an exception is thrown inside VmAnalyzer.analyze(). On exception, analyzeVms() will not return anything and the calling method, perform(), will call unlockVms() with an empty list. Change-Id: I5926f935e64f51a17a3ff0ca8a19309ae7792b0c Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/61614 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5926f935e64f51a17a3ff0ca8a19309ae7792b0c Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix NPE in "DC guide me" -> "Create Cluster" flow
by derez＠redhat.com 17 Aug '16

17 Aug '16

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: fix NPE in "DC guide me" -> "Create Cluster" flow ...................................................................... webadmin: fix NPE in "DC guide me" -> "Create Cluster" flow This patch disables creating a new MAC pool from the mentioned flow. Change-Id: I4010a765e6362915da2ee3a7a4a3d12c393310e3 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/cluster/ClusterPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java 2 files changed, 21 insertions(+), 9 deletions(-) Approvals: Marcin Mirecki: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/58691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4010a765e6362915da2ee3a7a4a3d12c393310e3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: removed static calls to DbFacade in UploadImage commands
by derez＠redhat.com 16 Aug '16

16 Aug '16

Daniel Erez has submitted this change and it was merged. Change subject: core: removed static calls to DbFacade in UploadImage commands ...................................................................... core: removed static calls to DbFacade in UploadImage commands Introduced ImageTransferUpdater bean: * Contains the logic of UploadImageCommand -> updateEntity. * Injected in UploadImageCommand and UploadImageStatusCommand. * Used in order to avoid static calls to DbFacade. Change-Id: I6fcb18033ec113d2387d3d57bc320c94f361e4a2 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImageTransferUpdater.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageStatusCommand.java 3 files changed, 112 insertions(+), 81 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Allon Mureinik: Looks good to me, approved Amit Aviram: Looks good to me, but someone else must approve Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fcb18033ec113d2387d3d57bc320c94f361e4a2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: inject ImageTransferDao in UploadImageStatusCommand
by derez＠redhat.com 16 Aug '16

16 Aug '16

Daniel Erez has submitted this change and it was merged. Change subject: core: inject ImageTransferDao in UploadImageStatusCommand ...................................................................... core: inject ImageTransferDao in UploadImageStatusCommand Injecting ImageTransferDao member in UploadImageStatusCommand class. Change-Id: Ie731ac5a4e813b6273b1dd89f732ac71aa3efab1 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageStatusCommand.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62239 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie731ac5a4e813b6273b1dd89f732ac71aa3efab1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: inject ImageTransferDao in UploadImageCommand
by derez＠redhat.com 16 Aug '16

16 Aug '16

Daniel Erez has submitted this change and it was merged. Change subject: core: inject ImageTransferDao in UploadImageCommand ...................................................................... core: inject ImageTransferDao in UploadImageCommand Injecting ImageTransferDao member in UploadImageCommand class. Change-Id: I8ce9f646f72c0b99b53dc9879888c811de15d317 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Allon Mureinik: Looks good to me, approved Amit Aviram: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62238 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ce9f646f72c0b99b53dc9879888c811de15d317 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: remove redundant param in ChildCommandsCallbackBase....
by masayag＠redhat.com 16 Aug '16

16 Aug '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: remove redundant param in ChildCommandsCallbackBase.endAction ...................................................................... engine: remove redundant param in ChildCommandsCallbackBase.endAction Change-Id: Ib084e6e757e0fadf1488b895f8cd8a9ee1a49fdb Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, but someone else must approve Yevgeny Zaspitsky: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib084e6e757e0fadf1488b895f8cd8a9ee1a49fdb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: remove redundant condition in ChildCommandsCallbackBase
by masayag＠redhat.com 16 Aug '16

16 Aug '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: remove redundant condition in ChildCommandsCallbackBase ...................................................................... engine: remove redundant condition in ChildCommandsCallbackBase Change-Id: I35084024cf1b41c7c0501af4ca6bd3ebfa052074 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35084024cf1b41c7c0501af4ca6bd3ebfa052074 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Don't generate streaming support code
by tnisan＠redhat.com 16 Aug '16

16 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Don't generate streaming support code ...................................................................... restapi: Don't generate streaming support code When version 4 of the API was planned it was decided to introduce support for streaming results. This required the introduction of streaming XML and JSON parsing and rendering code, automatically generated from the model. But this code isn't currently used, and generating increases the compilation time and incorrectly reduces the percentage of coverage reported by some tools. To avoid those inconveniences this patch removes the generation of this code from the bulid process. This will be reintroduced later, when the streaming support is completed. Change-Id: Iff09f64dc755493facaa4c9b7e457860c4982f18 Bug-Url: https://bugzilla.redhat.com/1367398 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit fc6d358b24514e01cea90d20a1d8051c7b6822c5) --- M backend/manager/modules/restapi/interface/definition/pom.xml 1 file changed, 0 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Passed CI tests Juan Hernandez: Verified; Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/62385 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff09f64dc755493facaa4c9b7e457860c4982f18 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Update capabilities for V3
by tnisan＠redhat.com 16 Aug '16

16 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Update capabilities for V3 ...................................................................... restapi: Update capabilities for V3 The "capabilities" provided by version 4 of the engine for version 3 of the API aren't generated directly, instead they are stored in a "capabilities.xml" file that is extracted from version 3 of the engine. This file needs to be updated when there are relevant changes in version 3 of the engine. This patch updates it, using version 3.6.7.5 of the engine. Change-Id: Ic3085a972be693c5638005f0acaeab58233bb077 Bug-Url: https://bugzilla.redhat.com/1367400 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 69939e4e8b071653c6ba3232cb133b4edf0351fe) --- M backend/manager/modules/restapi/jaxrs/src/main/resources/v3/capabilities.xml 1 file changed, 38 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/62382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3085a972be693c5638005f0acaeab58233bb077 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: re-enlarge the create snapshot message dialog
by tnisan＠redhat.com 16 Aug '16

16 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: re-enlarge the create snapshot message dialog ...................................................................... webadmin: re-enlarge the create snapshot message dialog In case there are no disks allowing a snapshot for the VM, the message panel size should be enlarged to contain the following two messages: "Could not detect Guest Agent on the VM. Note that without a Guest Agent the data on the created snapshot may be inconsistent. There are no disks allowing a snapshot, only the configuration will be a part of the VM snapshot.". And therefore the whole dialog should be enlarged also. Change-Id: Ib28fad0bbaea9dc16163a9f0ecd71f35668762a6 Bug-Url: https://bugzilla.redhat.com/1360914 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmSnapshotCreatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmSnapshotCreatePopupView.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/62374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib28fad0bbaea9dc16163a9f0ecd71f35668762a6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0