Change in ovirt-engine[master]: core: Fix master breakage on wrong class name
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix master breakage on wrong class name
......................................................................
core: Fix master breakage on wrong class name
In an earlier patch the class DiskImageByBootAndSnapshotComparator was
renamed to DiskByBootAndSnapshotComparator, the new class introduced using
the old class name was breaking the build
Change-Id: I58920b1623c24c4cfc337ac3f43cc4bb5fd63412
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/71167
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I58920b1623c24c4cfc337ac3f43cc4bb5fd63412
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1.0.z]: core: Fix storage domain creation rollback on failure
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix storage domain creation rollback on failure
......................................................................
core: Fix storage domain creation rollback on failure
When adding a new storage domain fails with an exception, the compensation
mechanism should kick in and rollback all newly created entities, among
them the storage domain, however since patch e7b5093 introduced, a command
execution was added as a part of the flow that adds a default disk profile.
This command is using the same context of the parent command resulting in
clearing the old compensation context and upon failure only the disk
profile entity creation is rolled back and the storage domain entity
remains in the DB resulting in the UI inability to remove the connection
and an unusable storage domain entity existing in the database.
This patch fixes it by cloning the context to the add disk profile command
and detaching it from the parent context.
Change-Id: I3d42062313792f680d0f4e6e51ee5837f34a08ec
Bug-Url: https://bugzilla.redhat.com/1404601
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71170
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d42062313792f680d0f4e6e51ee5837f34a08ec
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.0.z
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Fix storage domain creation rollback on failure
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix storage domain creation rollback on failure
......................................................................
core: Fix storage domain creation rollback on failure
When adding a new storage domain fails with an exception, the compensation
mechanism should kick in and rollback all newly created entities, among
them the storage domain, however since patch e7b5093 introduced, a command
execution was added as a part of the flow that adds a default disk profile.
This command is using the same context of the parent command resulting in
clearing the old compensation context and upon failure only the disk
profile entity creation is rolled back and the storage domain entity
remains in the DB resulting in the UI inability to remove the connection
and an unusable storage domain entity existing in the database.
This patch fixes it by cloning the context to the add disk profile command
and detaching it from the parent context.
Change-Id: I3d42062313792f680d0f4e6e51ee5837f34a08ec
Bug-Url: https://bugzilla.redhat.com/1404601
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71165
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d42062313792f680d0f4e6e51ee5837f34a08ec
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: engine: remove redundant mock expectations in DiskValidatorTest
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: remove redundant mock expectations in DiskValidatorTest
......................................................................
engine: remove redundant mock expectations in DiskValidatorTest
Change-Id: I014afba55b02a41f1f3339944a697c665543b230
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/71146
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I014afba55b02a41f1f3339944a697c665543b230
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: webadmin: Missing storage domain validated on FE
by Code Review
>From Tomas Jelinek <tjelinek(a)redhat.com>:
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Missing storage domain validated on FE
......................................................................
webadmin: Missing storage domain validated on FE
If a (non-admin) user creates a new VM based on template with disk that
is stored on storage domain that the user doesn't have pemissions to
then unitVmModel.getDisksAllocationModel().getDisks().get(...)
.getStorageDomain().getSelectedItem() may return `null`. This caused NPE
in DisksAllocationModel#updateImageToDestinationDomainMap().
The missing storage domain is reported as validation problem of Template
field.
Bug-Url: https://bugzilla.redhat.com/1406572
Change-Id: Ib41fa852aec8e8b428ef4c61c924c3c121f75f43
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties
3 files changed, 27 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71128
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib41fa852aec8e8b428ef4c61c924c3c121f75f43
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: packaging: ovirt-engine-hosts-ansible-inventory: handle date...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: ovirt-engine-hosts-ansible-inventory: handle datetime
......................................................................
packaging: ovirt-engine-hosts-ansible-inventory: handle datetime
Convert to strings datetime values, as json can't serialize them.
Change-Id: I786657d3d0f4292bd1d230e4aedb111c43bded1b
Bug-Url: https://bugzilla.redhat.com/1416218
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit 0536a8966285fbe7346a744e43d401be5af95a4a)
---
M packaging/setup/bin/ovirt-engine-hosts-ansible-inventory
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/71140
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I786657d3d0f4292bd1d230e4aedb111c43bded1b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: packaging: spec: Require ansible
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: Require ansible
......................................................................
packaging: spec: Require ansible
Make ovirt-engine-hosts-ansible-inventory require ansible, so that the
playbook it provides can be used.
Change-Id: Ic68c5394f824f0533b42fb32374d29e56c56fa1e
Bug-Url: https://bugzilla.redhat.com/1416257
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/71138
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic68c5394f824f0533b42fb32374d29e56c56fa1e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: core: Fix storage domain creation rollback on failure
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix storage domain creation rollback on failure
......................................................................
core: Fix storage domain creation rollback on failure
When adding a new storage domain fails with an exception, the compensation
mechanism should kick in and rollback all newly created entities, among
them the storage domain, however since patch e7b5093 introduced, a command
execution was added as a part of the flow that adds a default disk profile.
This command is using the same context of the parent command resulting in
clearing the old compensation context and upon failure only the disk
profile entity creation is rolled back and the storage domain entity
remains in the DB resulting in the UI inability to remove the connection
and an unusable storage domain entity existing in the database.
This patch fixes it by cloning the context to the add disk profile command
and detaching it from the parent context.
Change-Id: I3d42062313792f680d0f4e6e51ee5837f34a08ec
Bug-Url: https://bugzilla.redhat.com/1404601
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71119
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d42062313792f680d0f4e6e51ee5837f34a08ec
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: ui: Disable Sparsify for direct LUNs and Cinder disks
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: ui: Disable Sparsify for direct LUNs and Cinder disks
......................................................................
ui: Disable Sparsify for direct LUNs and Cinder disks
SparsifyImageCommand doesn't support direct LUNs and Cinder disks. For
this reason, 'Sparsify' button is disabled in UI for these types of
disks.
Change-Id: I44beaebb3d3c3cd187441d0ec02cff890aaa6dc4
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1414867
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71147
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44beaebb3d3c3cd187441d0ec02cff890aaa6dc4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-hosted-engine-ha[v2.1.z]: When refreshing vm.conf use dedicated method
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: When refreshing vm.conf use dedicated method
......................................................................
When refreshing vm.conf use dedicated method
vm.conf should always be refreshed using a dedicated method.
Change-Id: I632f10782392c855fa72e574e1242579a90d76f6
Bug-Url:https://bugzilla.redhat.com/1411783
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
(cherry picked from commit c1424da)
---
M ovirt_hosted_engine_ha/env/config.py
1 file changed, 15 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/71163
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I632f10782392c855fa72e574e1242579a90d76f6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: v2.1.z
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months