Change in ovirt-hosted-engine-ha[v2.1.z]: Fix adding rng device
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: Fix adding rng device
......................................................................
Fix adding rng device
If there is no rng device in the vm ovf it needs to be added.
Change-Id: Iec5fccc0aac9084b69e8fa2bd41b69163b3be199
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1415994
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
(cherry picked from commit 69a917f)
---
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/71162
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec5fccc0aac9084b69e8fa2bd41b69163b3be199
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: v2.1.z
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-hosted-engine-ha[v2.1.z]: Fix RNG device model when parsing OVF
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: Fix RNG device model when parsing OVF
......................................................................
Fix RNG device model when parsing OVF
The OVF encodes the RNG model to the device field.
But vdsm/libvirt do not support it, so we have to
move it to the model field manually.
Change-Id: Iefbe817dd3b7281dbfd4744232fb3e71db9fbebc
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1415994
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
(cherry picked from commit 6f35ebc)
---
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams_test.py
2 files changed, 8 insertions(+), 1 deletion(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/71161
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefbe817dd3b7281dbfd4744232fb3e71db9fbebc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: v2.1.z
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-hosted-engine-ha[master]: When refreshing vm.conf use dedicated method
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: When refreshing vm.conf use dedicated method
......................................................................
When refreshing vm.conf use dedicated method
vm.conf should always be refreshed using a dedicated method.
Change-Id: I632f10782392c855fa72e574e1242579a90d76f6
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
---
M ovirt_hosted_engine_ha/env/config.py
1 file changed, 15 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/71111
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I632f10782392c855fa72e574e1242579a90d76f6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-hosted-engine-ha[master]: Fix RNG device model when parsing OVF
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: Fix RNG device model when parsing OVF
......................................................................
Fix RNG device model when parsing OVF
The OVF encodes the RNG model to the device field.
But vdsm/libvirt do not support it, so we have to
move it to the model field manually.
Change-Id: Iefbe817dd3b7281dbfd4744232fb3e71db9fbebc
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1415994
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams_test.py
2 files changed, 8 insertions(+), 1 deletion(-)
Approvals:
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/71078
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefbe817dd3b7281dbfd4744232fb3e71db9fbebc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-hosted-engine-ha[master]: Fix adding rng device
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: Fix adding rng device
......................................................................
Fix adding rng device
If there is no rng device in the vm ovf it needs to be added.
Change-Id: Iec5fccc0aac9084b69e8fa2bd41b69163b3be199
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1415994
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/71155
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec5fccc0aac9084b69e8fa2bd41b69163b3be199
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: core: conversion of most of vm dictionary to domxml
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: conversion of most of vm dictionary to domxml
......................................................................
core: conversion of most of vm dictionary to domxml
This patch introduces the LibvirtVmXmlBuilder that will ideally
convert all the content in the VM dictionary that is being sent
to VDSM into a complete domxml.
Although it is not yet complete and not used in any way, we
merge it now so future changes in the VM dictionary would also
be done in this class.
Change-Id: Iba3699e7d3f0853fc178dd669b6e9fd13f24a180
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/xml/XmlTextWriter.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java
3 files changed, 1,326 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Arik Hadas: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64473
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba3699e7d3f0853fc178dd669b6e9fd13f24a180
Gerrit-PatchSet: 37
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: webadmin: scsi dialog - adjust tabs text location
by Code Review
>From Daniel Erez <derez(a)redhat.com>:
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: scsi dialog - adjust tabs text location
......................................................................
webadmin: scsi dialog - adjust tabs text location
Storage dialog -> SCSI -> Tabs:
adjusted text location in the tab.
Before: http://imgur.com/a/YbJ9Q
After: http://imgur.com/a/N1ZrJ
Change-Id: Ie2afc2e997b00108f8e7b8e6cf7baf3dee46e660
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/71145
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2afc2e997b00108f8e7b8e6cf7baf3dee46e660
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: scheduler: Remove cluster upgrade policy from the database t...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: scheduler: Remove cluster upgrade policy from the database table
......................................................................
scheduler: Remove cluster upgrade policy from the database table
The previous commit only deleted the policy units for the policy but not
the policy itself.
Change-Id: I3b18ca5383b7734f863087f56e34f549790080b6
Bug-Url: https://bugzilla.redhat.com/1343440
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_01_0730_remove_el7_upgrade_policy.sql
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Martin Sivák: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69430
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b18ca5383b7734f863087f56e34f549790080b6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in jenkins[master]: Adapt experimental flow to use mirrors
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: Adapt experimental flow to use mirrors
......................................................................
Adapt experimental flow to use mirrors
Using mirrors both for mock and for reposync.
Had to refactor the Groovy script a little to pass around the suit name
and its version instead of an opaque script name.
Change-Id: I9eab84da363bf98e26c7c50d67a361df7b391ffd
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1042
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
---
M jobs/confs/groovy-scripts/test-ovirt-repo.groovy
1 file changed, 56 insertions(+), 26 deletions(-)
Approvals:
Eyal Edri: Looks good to me, approved; Ready for merge
Barak Korren: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69395
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9eab84da363bf98e26c7c50d67a361df7b391ffd
Gerrit-PatchSet: 13
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <david(a)dcaro.es>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: sysprep: Change symlink to real file due to build errors
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: sysprep: Change symlink to real file due to build errors
......................................................................
sysprep: Change symlink to real file due to build errors
Change-Id: I8f437bc12b9d06c2e611056f024268d93074e5e6
Bug-Url: https://bugzilla.redhat.com/1388724
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
(cherry picked from commit 941a6a832ba965a21acd7b4814ba26635f31a33b)
---
D packaging/conf/sysprep/sysprep.2k16x64
A packaging/conf/sysprep/sysprep.2k16x64
2 files changed, 80 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Vinzenz Feenstra: Verified
--
To view, visit https://gerrit.ovirt.org/71144
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f437bc12b9d06c2e611056f024268d93074e5e6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months