February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: UpdateHostNicVfsConfigCommand local var scope
by Code Review 14 Feb '17

14 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateHostNicVfsConfigCommand local var scope ...................................................................... core: UpdateHostNicVfsConfigCommand local var scope Reduced the scope of a local variable to make the block clearer and easier to read. Change-Id: If8a102e981bb5128185b169a45be80f136bfe8f3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateHostNicVfsConfigCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72237 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8a102e981bb5128185b169a45be80f136bfe8f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove redundant InjectorRule usages
by Code Review 14 Feb '17

14 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove redundant InjectorRule usages ...................................................................... core: Remove redundant InjectorRule usages Change-Id: I521498cd449a6ec8618c2f69538ed5353f48cc8a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/RegisterVdsQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerClusterTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/QosRangeValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java 5 files changed, 0 insertions(+), 34 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I521498cd449a6ec8618c2f69538ed5353f48cc8a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: edit vfs: dynamically maintain suggested labels
by Code Review 14 Feb '17

14 Feb '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: edit vfs: dynamically maintain suggested labels ...................................................................... webadmin: edit vfs: dynamically maintain suggested labels Fixing a bug where labels are being generated once during VfsNicLabelModel's instantiation and aren't maintained throughout the configuration of the physical function. suggestedLabels is now maintained (updateSuggestedLabels is triggered on onValueChange and modifies it) and the underlying ListModels setItems are invoked with the now up-to-date variation of suggestedLabels. Bug-Id: https://bugzilla.redhat.com/1410322 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> Change-Id: I0f17638dd2e55ebde99bdd00a044b691e32da29b --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/VfsConfigModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/VfsNicLabelModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/VfsNicLabelWidget.java 4 files changed, 25 insertions(+), 15 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/71804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f17638dd2e55ebde99bdd00a044b691e32da29b Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: NPE on edit pool dialog
by Code Review 14 Feb '17

14 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: NPE on edit pool dialog ...................................................................... webadmin: NPE on edit pool dialog The resource allocation of the edit pool dialog has a logic which tries to select the storage domain of the selected template to be the same as the storage domain on which some Vm from the pool is. The logic has an assumption that the selected template's disks are the parent disks of the respective VM. This assumption is true only if the template is not versioned. If the template has versions, this assumption is broken. This causes an issue that the disk allocation part is not properly inited and consequently fails on validation on NPE. Fixed by first initing the storage to the values of the template disks and than try to match them to the VM ones. Change-Id: Iafc386b7cc4b013293c7b7f627053a438f7df7cc Bug-Url: https://bugzilla.redhat.com/1421725 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72197 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafc386b7cc4b013293c7b7f627053a438f7df7cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Change max vCPU count computation
by Code Review 14 Feb '17

14 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Change max vCPU count computation ...................................................................... core: Change max vCPU count computation Maximum vCPU count for a VM is currently determined by a defined absolute maximum limit and the number of cores and threads. However, on x86 the simple formula may cause overflow of an APIC ID limit due to the bit-based layout of the APIC ID value and then QEMU refuses to run the VM. With this patch we make sure that the value always fits into the APIC limits. See the bug report for explanation. In the future, when x2APIC will be used, we can remove the restriction. Change-Id: I9cced4317eebfd302230152e96c6c32dcf0fb13f Bug-Url: https://bugzilla.redhat.com/1406243 Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmCpuCountHelper.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 120 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Milan Zamazal: Verified -- To view, visit https://gerrit.ovirt.org/72249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cced4317eebfd302230152e96c6c32dcf0fb13f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Don't fork the Maven source plugin
by Code Review 14 Feb '17

14 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Don't fork the Maven source plugin ...................................................................... Don't fork the Maven source plugin Currently the project runs the 'jar' goal of the Maven source plugin.u A side effect of this is that the plugin explicitly executes the 'generate-sources' phase of the build. As a result the code generation, which is attached to that 'generate-sources' phase, runs twice. That doesn't have a big impact, as the generated code is the same, but it wastes resources. This patch changes the build process so that it uses the 'jar-no-fork', which doesn't have that negative side effect. Change-Id: I107a12125f5acb229608b05efba3572f24ebfe3d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I107a12125f5acb229608b05efba3572f24ebfe3d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Remove duplicated Maven compiler plugin
by Code Review 14 Feb '17

14 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Remove duplicated Maven compiler plugin ...................................................................... Remove duplicated Maven compiler plugin The Maven compiler plugin is listed twice in the root POM of the project. This patch removes one of the copies. Change-Id: Idbd3ac8531119470ec60ff9bdaf641add1dd9df4 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/72201 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbd3ac8531119470ec60ff9bdaf641add1dd9df4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unnecessary max memory vdc_option
by Code Review 14 Feb '17

14 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Remove unnecessary max memory vdc_option ...................................................................... core: Remove unnecessary max memory vdc_option * 0000_config.sql file no longer defines value of VMPpc64BitMaxMemorySizeInMB. Default from ConfigValues class will be used. * DB script removes existing vdc_options record if it matches current default - was not customized by user. VM32BitMaxMemorySizeInMB and VM32BitMaxMemorySizeInMB options were not removed since they are used in engine-config utility that can't read defaults from ConfigValues class. Change-Id: I72db784625edc69628857bd399a60d7fdc65e5d9 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- A packaging/dbscripts/upgrade/04_02_0150_remove_VM64BitMaxMemorySizeInMB_vdc_option.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71633 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72db784625edc69628857bd399a60d7fdc65e5d9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Remove Fedora 23 leftovers
by Code Review 14 Feb '17

14 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Remove Fedora 23 leftovers ...................................................................... Remove Fedora 23 leftovers This patch removes some automation files required for Fedora 23. As Fedora 23 is end of life already, these files are no longer required. Change-Id: I300b072329913e802c85fe6ebdd7948738c07d14 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D automation/build-artifacts.packages.fc23 D automation/build.packages.fc23 D automation/check-merged.packages.fc23 D automation/check-patch.packages.fc23 4 files changed, 0 insertions(+), 21 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72198 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I300b072329913e802c85fe6ebdd7948738c07d14 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: packaging: add fc25 spec template
by Code Review 14 Feb '17

14 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: packaging: add fc25 spec template ...................................................................... packaging: add fc25 spec template Change-Id: I324a4e6a52b069314093e2d0ee1b0ce709f82a3d Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A automation/build-artifacts.packages.fc25 A automation/build.packages.fc25 A automation/check-merged.packages.fc25 A automation/check-patch.packages.fc25 A packaging/spec.fc25.in 5 files changed, 110 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I324a4e6a52b069314093e2d0ee1b0ce709f82a3d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <david(a)dcaro.es> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0