Change in ovirt-engine[master]: core: Block adding of a VM lease if high availabilty is not ...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Block adding of a VM lease if high availabilty is not turned on
......................................................................
core: Block adding of a VM lease if high availabilty is not turned on
Bug-Url: https://bugzilla.redhat.com/1417439
Change-Id: I5e81e97c98ecf556919f0df9c2458f2ab3d8d519
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 17 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/72264
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e81e97c98ecf556919f0df9c2458f2ab3d8d519
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: engine: handle TransportRunTimeException in PollVDSCommand
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: engine: handle TransportRunTimeException in PollVDSCommand
......................................................................
engine: handle TransportRunTimeException in PollVDSCommand
Interpret TransportRunTimeException in PollVDSCommand as an
unsuccessful poll attempt and report the exception in debug
level rather then as error.
Change-Id: I50053d3ea96adee9b86dfdabb10834fbfa8735f2
Bug-Url: https://bugzilla.redhat.com/1408870
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FutureVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PollVDSCommand.java
2 files changed, 21 insertions(+), 4 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, but someone else must approve
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/72194
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50053d3ea96adee9b86dfdabb10834fbfa8735f2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: webadmin: New volumes dialog layout
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: New volumes dialog layout
......................................................................
webadmin: New volumes dialog layout
- Update the new volumes dialog to use bootstrap grid
layout.
- Fixed npe when switching from replicated to distributed
replicated.
Change-Id: I08c9e76346b36a66a4891d187367e99dd95518dc
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumePopupView.ui.xml
3 files changed, 130 insertions(+), 158 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/70750
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08c9e76346b36a66a4891d187367e99dd95518dc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kanagaraj.ktr(a)gmail.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: Fix duplicate upgrade script numbers
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix duplicate upgrade script numbers
......................................................................
core: Fix duplicate upgrade script numbers
Both commit 99cbba8 and 61be67 pushed script number 04_02_0150, this patch
fixes it
Change-Id: I314aa36bb93ffc3c08b707c64cfa2afc59c9d970
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
R packaging/dbscripts/upgrade/04_02_0160_add_vm_snapshot_id_to_glance_disks.sql
1 file changed, 0 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72270
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I314aa36bb93ffc3c08b707c64cfa2afc59c9d970
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: add VM snapshot ID to older glance template disks
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: add VM snapshot ID to older glance template disks
......................................................................
core: add VM snapshot ID to older glance template disks
An upgrade script to add a VM snapshot ID to disks of glance image
based template disks. This comes in addition to commit 4ddb7947a4
which fixes the issue for new templates in which disks of templates
made of repository images have no VM snapshot ID which causes an
error when attempting to import them from an export domain.
Change-Id: If17ef8a396bc54d6c5e4f3f4e8cfc54670bcfbd4
Bug-Url: https://bugzilla.redhat.com/1399603
Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_02_0150_add_vm_snapshot_id_to_glance_disks.sql
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Benny Zlotnik: Verified
Jenkins CI: Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/72190
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If17ef8a396bc54d6c5e4f3f4e8cfc54670bcfbd4
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Remove duplicated Maven compiler plugin
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Remove duplicated Maven compiler plugin
......................................................................
Remove duplicated Maven compiler plugin
The Maven compiler plugin is listed twice in the root POM of the
project. This patch removes one of the copies.
Change-Id: Idbd3ac8531119470ec60ff9bdaf641add1dd9df4
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 832149bf7f649b3f4100a11c1a74f8de0af0cf6a)
---
M pom.xml
1 file changed, 0 insertions(+), 10 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/72256
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idbd3ac8531119470ec60ff9bdaf641add1dd9df4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Remove Fedora 23 leftovers
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Remove Fedora 23 leftovers
......................................................................
Remove Fedora 23 leftovers
This patch removes some automation files required for Fedora 23. As
Fedora 23 is end of life already, these files are no longer required.
Change-Id: I300b072329913e802c85fe6ebdd7948738c07d14
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 2fbcdafde3c987e4dba90a69022a0fca7e25d880)
---
D automation/build-artifacts.packages.fc23
D automation/build.packages.fc23
D automation/check-merged.packages.fc23
D automation/check-patch.packages.fc23
4 files changed, 0 insertions(+), 21 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72255
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I300b072329913e802c85fe6ebdd7948738c07d14
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Don't fork the Maven source plugin
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Don't fork the Maven source plugin
......................................................................
Don't fork the Maven source plugin
Currently the project runs the 'jar' goal of the Maven source plugin.u
A side effect of this is that the plugin explicitly executes the
'generate-sources' phase of the build. As a result the code generation,
which is attached to that 'generate-sources' phase, runs twice. That
doesn't have a big impact, as the generated code is the same, but it
wastes resources. This patch changes the build process so that it uses
the 'jar-no-fork', which doesn't have that negative side effect.
Change-Id: I107a12125f5acb229608b05efba3572f24ebfe3d
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit bdb11f9394b5d6e76e4cafeaf2e6aded0f2156e0)
---
M pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72257
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I107a12125f5acb229608b05efba3572f24ebfe3d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Don't use 'bundler' in RPM distributions
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Don't use 'bundler' in RPM distributions
......................................................................
Don't use 'bundler' in RPM distributions
Currently the SDK uses the 'bundler' tool to install the dependencies
and build the SDK. But in some platforms the latest version of this tool
doesn't work correctly with the version of the 'gem' tool. To avoid this
problem, and other potential problems in the future, this patch changes
the build scripts so that they provide a mechanism to build without
bundler. This mechanism consists on two new build profiles: 'bundler'
and 'rpm'. The first, 'bundler', will work as it used to work before
this patch. The new one, 'rpm', will assume that the required gems have
already been installed, with the RPM package manager, for example.
Note that 'bundler' is still the recommended tool for the build, and
will continue to be used in development environments and for the builds
released to 'rubygems.org'.
Change-Id: Ide97e6e6df3ca326f26563a7e3305fd50e0abc14
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 5b5d707aeedefe4745fd73c5b33735aa4f49f001)
---
M automation/build.packages.el7
M automation/build.packages.fc23
M automation/build.packages.fc24
M automation/build.py
M packaging/spec.el7.in
M packaging/spec.fc24.in
M pom.xml
M sdk/Rakefile
M sdk/pom.xml
9 files changed, 183 insertions(+), 86 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72253
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide97e6e6df3ca326f26563a7e3305fd50e0abc14
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: packaging: add fc25 spec template
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: add fc25 spec template
......................................................................
packaging: add fc25 spec template
Change-Id: I324a4e6a52b069314093e2d0ee1b0ce709f82a3d
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit 339c38d8e4430f5daa06f17b475d2a7f7cf30c1d)
---
A automation/build-artifacts.packages.fc25
A automation/build.packages.fc25
A automation/check-merged.packages.fc25
A automation/check-patch.packages.fc25
A packaging/spec.fc25.in
5 files changed, 110 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72254
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I324a4e6a52b069314093e2d0ee1b0ce709f82a3d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months