Change in ovirt-engine[master]: webadmin: fix layout issues
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: fix layout issues
......................................................................
webadmin: fix layout issues
- Fixed layout issue in VM network interface dialog
- Fixed layout issue in Import VM dialog.
Change-Id: Id5a8ff75e11250b5ce8fe6142cc7ad25751ee100
Bug-Url: https://bugzilla.redhat.com/1390271
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmInterfacePopupView.java
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/72309
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5a8ff75e11250b5ce8fe6142cc7ad25751ee100
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Add support for custom headers and query parameters
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Add support for custom headers and query parameters
......................................................................
Add support for custom headers and query parameters
Currently there is no way to send to the server custom headers or query
parameters. This patch adds support for that. For example, if the
caller, for whatever the reason, needs to send the 'My: myvalue' header
and the 'your=yourvalue' query parameter to the request to add a virtual
machine, it can be done as follows:
# Get the reference to the service that managse the collection
# of virtual machines:
vms_service = connection.system_service.vms_service
# Add the virtual machine, with a custom
vms_service.add(
OvirtSDK4::Vm.new,
headers: { my: 'myvalue' },
query: { your: 'yourvalue' }
)
Change-Id: I7f694bbff3889a62169eae894e2ba1071780237a
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 598466b9aaa471d97bf2772db4d6234b0af85b9f)
---
M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java
M sdk/spec/spec_helper.rb
M sdk/spec/vm_service_spec.rb
M sdk/spec/vms_service_spec.rb
4 files changed, 191 insertions(+), 9 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72304
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f694bbff3889a62169eae894e2ba1071780237a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: restapi: Fix VM affinity rule mapping
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Fix VM affinity rule mapping
......................................................................
restapi: Fix VM affinity rule mapping
Fix VM affinity rule default value when no rule is passed.
Change-Id: I226653f4fc32b4af16470452f7bb238e6d5415ae
Bug-Url: https://bugzilla.redhat.com/1414818
Signed-off-by: Yanir Quinn <yquinn(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/AffinityGroupMapper.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Denis Chaplygin: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, but someone else must approve
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
Yanir Quinn: Verified
--
To view, visit https://gerrit.ovirt.org/71693
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I226653f4fc32b4af16470452f7bb238e6d5415ae
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk-ruby[master]: Add support for custom headers and query parameters
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Add support for custom headers and query parameters
......................................................................
Add support for custom headers and query parameters
Currently there is no way to send to the server custom headers or query
parameters. This patch adds support for that. For example, if the
caller, for whatever the reason, needs to send the 'My: myvalue' header
and the 'your=yourvalue' query parameter to the request to add a virtual
machine, it can be done as follows:
# Get the reference to the service that managse the collection
# of virtual machines:
vms_service = connection.system_service.vms_service
# Add the virtual machine, with a custom
vms_service.add(
OvirtSDK4::Vm.new,
headers: { my: 'myvalue' },
query: { your: 'yourvalue' }
)
Change-Id: I7f694bbff3889a62169eae894e2ba1071780237a
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java
M sdk/spec/spec_helper.rb
M sdk/spec/vm_service_spec.rb
M sdk/spec/vms_service_spec.rb
4 files changed, 191 insertions(+), 9 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f694bbff3889a62169eae894e2ba1071780237a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: webadmin: Fix label click on checkbox.
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: Fix label click on checkbox.
......................................................................
webadmin: Fix label click on checkbox.
- Fixed labels that weren't clickable in the cluster dialog.
Change-Id: If85dc251de018712dc4d0fe5bf7b7ba8ad96682b
Bug-Url: https://bugzilla.redhat.com/1402343
Bug-Url: https://bugzilla.redhat.com/1267259
Bug-Url: https://bugzilla.redhat.com/1414418
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelWidgetWithInfo.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseEntityModelCheckboxEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
7 files changed, 42 insertions(+), 60 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/71104
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If85dc251de018712dc4d0fe5bf7b7ba8ad96682b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: webadmin: Take tags/other search strings into account
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: Take tags/other search strings into account
......................................................................
webadmin: Take tags/other search strings into account
- Fixed issues where the user main tab wouldn't take other
searches that were part of the prefix into account which
would cause undefined behavior when a tag was selected and
you switched to the user main tab.
Change-Id: I48ac0fe7a8f0cda6446c55f8cc3019402c74649e
Bug-Url: https://bugzilla.redhat.com/1416830
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, but someone else must approve
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/72233
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I48ac0fe7a8f0cda6446c55f8cc3019402c74649e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: minor cleanup in ovf reader
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: minor cleanup in ovf reader
......................................................................
core: minor cleanup in ovf reader
Inline variable declarations.
Change-Id: I0ced7c62546b65f0cd7ef215bd22a04b84fef640
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
1 file changed, 4 insertions(+), 6 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/72280
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ced7c62546b65f0cd7ef215bd22a04b84fef640
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Add PostcopyMigrationFailed VM exit reason
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add PostcopyMigrationFailed VM exit reason
......................................................................
core: Add PostcopyMigrationFailed VM exit reason
Change-Id: I13c25ad704990aa5b5380fa27b5602089e1ffa25
Bug-Url: https://bugzilla.redhat.com/1422089
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmExitReason.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
Milan Zamazal: Verified
--
To view, visit https://gerrit.ovirt.org/72265
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13c25ad704990aa5b5380fa27b5602089e1ffa25
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-4.1]: ui: Added 4.2 to the list of NFS versions
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: ui: Added 4.2 to the list of NFS versions
......................................................................
ui: Added 4.2 to the list of NFS versions
This patch adds NFS version 4.2 to the list of NFS versions in the
Storage Domain creation dialog. This allows user to create Storage
Domain that is always mounted with nfsvers=4.2 option.
In particular, this allows user to guarantee that virt-sparsify will be
working on his Storage Domain, because virt-sparsify for its operation
requires version 4.2 of NFS protocol.
Change-Id: I5af47da488cff6219628c0ec29f84ddb8b211768
Bug-Url: https://bugzilla.redhat.com/1406398
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NfsVersion.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
5 files changed, 7 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/72276
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5af47da488cff6219628c0ec29f84ddb8b211768
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-4.1]: core: add VM snapshot ID to older glance template disks
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: add VM snapshot ID to older glance template disks
......................................................................
core: add VM snapshot ID to older glance template disks
An upgrade script to add a VM snapshot ID to disks of glance image
based template disks. This comes in addition to commit 4ddb7947a4
which fixes the issue for new templates in which disks of templates
made of repository images have no VM snapshot ID which causes an
error when attempting to import them from an export domain.
Change-Id: If17ef8a396bc54d6c5e4f3f4e8cfc54670bcfbd4
Bug-Url: https://bugzilla.redhat.com/1399603
Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_01_0760_add_vm_snapshot_id_to_glance_disks.sql
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Benny Zlotnik: Verified
Tal Nisan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72266
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If17ef8a396bc54d6c5e4f3f4e8cfc54670bcfbd4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months