Change in jenkins[master]: Modify cleanup_slave.sh not to remove docker DMs
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/80806 )
Change subject: Modify cleanup_slave.sh not to remove docker DMs
......................................................................
Modify cleanup_slave.sh not to remove docker DMs
This patch supposed to fix a bug where after removal
of all device mappings that loop devices, docker
fails to detect that it's device was removed.
Instead of removing all device mappings and loop devices,
we test if the device pool docker uses actually known by
devicemapper. If it was deleted, we need to restart docker
after removing /var/lib/docker.
Jira: https://ovirt-jira.atlassian.net/browse/OVIRT-1600
Change-Id: If72c360bd717d001cd24d9e9514ea83ef812936e
Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com>
---
M jobs/confs/shell-scripts/cleanup_slave.sh
1 file changed, 55 insertions(+), 3 deletions(-)
Approvals:
Barak Korren: Looks good to me, approved; Ready for merge
Daniel Belenky: Verified; Ready for review
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80806
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If72c360bd717d001cd24d9e9514ea83ef812936e
Gerrit-PatchSet: 6
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>
6 years, 8 months
Change in ovirt-engine[master]: webadmin: Correct label alignment in quota popups
by Code Review
>From Greg Sheremeta <gshereme(a)redhat.com>:
Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80983 )
Change subject: webadmin: Correct label alignment in quota popups
......................................................................
webadmin: Correct label alignment in quota popups
This patch corrects the spacing of the "Limit to" labels and
corresponding textboxes in the data center quota popups to
prevent wrapping of the text in the de_DE locale. It also
uppercases the first letter of the radio button label for
consistency.
-------------------
Screenshots:
Before:
Storage quota: http://imgur.com/a/MI36e
CPU/Mem quota: http://imgur.com/a/TDREO
After:
Storage quota: http://imgur.com/a/VCuJO
CPU/Mem quota: http://imgur.com/a/18A8I
Change-Id: Ic7254587347398604cfd5d5880ad5b659822a2cf
Signed-off-by: Phillip Bailey <phbailey(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/EditQuotaClusterPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/EditQuotaStoragePopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
3 files changed, 15 insertions(+), 7 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Phillip Bailey: Verified
--
To view, visit https://gerrit.ovirt.org/80983
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7254587347398604cfd5d5880ad5b659822a2cf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-log-collector[master]: inventory: remove vms_check_no_timezone_set.sql
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/81067 )
Change subject: inventory: remove vms_check_no_timezone_set.sql
......................................................................
inventory: remove vms_check_no_timezone_set.sql
This is generic sql and duplicate:
check_vms_windows_with_incorrect_timezone
check_vms_linux_and_others_with_incorrect_timezone
Change-Id: I0bb3f21056f34418c7fe5d18e6ea761d002f6c8c
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/Makefile.am
M src/inventory_report/produceReport/pre-upgrade-checks
M src/inventory_report/produceReport/produceReport.sh
D src/inventory_report/produceReport/sqls/vms_check_no_timezone_set.sql
4 files changed, 5 insertions(+), 41 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81067
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0bb3f21056f34418c7fe5d18e6ea761d002f6c8c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-log-collector[master]: inventory: Improve table display for windows os without time...
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/81066 )
Change subject: inventory: Improve table display for windows os without timezone
......................................................................
inventory: Improve table display for windows os without timezone
- Added headers
- Added entity_type='VM'
Change-Id: I879f02650f6dee220634a57b20fde34d2885c322
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/pre-upgrade-checks
M src/inventory_report/produceReport/sqls/vms_query_windows_vms_with_incorrect_timezone.sql
2 files changed, 38 insertions(+), 35 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81066
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I879f02650f6dee220634a57b20fde34d2885c322
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-log-collector[master]: inventory: Improve table display for linux os without timezone
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/81065 )
Change subject: inventory: Improve table display for linux os without timezone
......................................................................
inventory: Improve table display for linux os without timezone
- Added headers
- Added entity_type='VM'
Change-Id: Id6f4d47c0e2006b513d73dd630a6385aebc3505e
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/pre-upgrade-checks
M src/inventory_report/produceReport/sqls/vms_query_linux_and_others_vms_with_incorrect_timezone.sql
2 files changed, 49 insertions(+), 47 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81065
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6f4d47c0e2006b513d73dd630a6385aebc3505e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-log-collector[master]: inventory: HE - Detect if hosts suppose to be in local or gl...
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/81025 )
Change subject: inventory: HE - Detect if hosts suppose to be in local or global maint
......................................................................
inventory: HE - Detect if hosts suppose to be in local or global maint
If hypervisors are not up and global and local maintenance mode
are not set, share to users.
Change-Id: Ie8e5aa4df643b24aa5db1066bcb2b0873f71c9df
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/Makefile.am
M src/inventory_report/produceReport/pre-upgrade-checks
A src/inventory_report/produceReport/sqls/vds_statistics_query_hosted_engine_setup_with_hosts_non_up.sql
3 files changed, 85 insertions(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81025
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8e5aa4df643b24aa5db1066bcb2b0873f71c9df
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Germano Veit Michel <germano(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-log-collector[master]: inventory: add headers to sql checkmixedrhelversion
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/81063 )
Change subject: inventory: add headers to sql checkmixedrhelversion
......................................................................
inventory: add headers to sql checkmixedrhelversion
This improve users experience.
Change-Id: Ib5b352b7c4b5c4222b251a953feec34e6f3433a4
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/sqls/vdc_options_query_checkmixedrhelversion.sql
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81063
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5b352b7c4b5c4222b251a953feec34e6f3433a4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-log-collector[master]: inventory: Remove bookmarks_query_number_of_rows
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/81062 )
Change subject: inventory: Remove bookmarks_query_number_of_rows
......................................................................
inventory: Remove bookmarks_query_number_of_rows
It's not required, instead of doing two queries, let's use one
and check if it's only header provided, if only header do not display.
Change-Id: I9e295dc7a4acf6021e70d27ec23d1d505b17b3dd
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/Makefile.am
M src/inventory_report/produceReport/produceReport.sh
D src/inventory_report/produceReport/sqls/bookmarks_query_number_of_rows.sql
3 files changed, 3 insertions(+), 20 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81062
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e295dc7a4acf6021e70d27ec23d1d505b17b3dd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-log-collector[master]: inventory: use CAPS to sql commands
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/81061 )
Change subject: inventory: use CAPS to sql commands
......................................................................
inventory: use CAPS to sql commands
Replace non CAPS for TO STDOUT WITH CSV DELIMITER
Change-Id: I54db41e369bbbc9545f851244b05bc75a10c92ce
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/sqls/cluster_query_check_datacenter.sql
M src/inventory_report/produceReport/sqls/cluster_query_migration_policies.sql
M src/inventory_report/produceReport/sqls/cluster_query_minimum_3_6_compat_version.sql
M src/inventory_report/produceReport/sqls/cluster_query_show_all_clusters.sql
M src/inventory_report/produceReport/sqls/cluster_query_vms_per_cluster.sql
M src/inventory_report/produceReport/sqls/datacenter_query_minimum_3_6_compat_version.sql
M src/inventory_report/produceReport/sqls/luns_query_all_data.sql
M src/inventory_report/produceReport/sqls/network_query_cluster_with_non_ovirtmgmt_as_management_network.sql
M src/inventory_report/produceReport/sqls/providers_query_show_data.sql
M src/inventory_report/produceReport/sqls/storage_domains_lun_data.sql
M src/inventory_report/produceReport/sqls/storage_domains_nfs_path.sql
M src/inventory_report/produceReport/sqls/users_query_system_users.sql
M src/inventory_report/produceReport/sqls/vms_query_health.sql
13 files changed, 13 insertions(+), 13 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81061
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54db41e369bbbc9545f851244b05bc75a10c92ce
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in ovirt-log-collector[master]: inventory: improve sql query for virtio serial console
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/81060 )
Change subject: inventory: improve sql query for virtio serial console
......................................................................
inventory: improve sql query for virtio serial console
- Use RETURN QUERY as others sqls
- Added Header
- ORDER BY vm_static.vm_name
Change-Id: I0a4575c878d8be196b9e2c2fade09d2646b69924
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/pre-upgrade-checks
M src/inventory_report/produceReport/sqls/vms_with_cluster_lower_3_6_with_virtio_serial_console.sql
2 files changed, 29 insertions(+), 17 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81060
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a4575c878d8be196b9e2c2fade09d2646b69924
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months