Change in ovirt-engine[master]: webadmin: ProfileListModel redundant casts
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80803 )
Change subject: webadmin: ProfileListModel redundant casts
......................................................................
webadmin: ProfileListModel redundant casts
Change-Id: I6f51c8bf7428cd8775aa1dfee293e7855269b2e8
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/ProfileListModel.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/80803
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f51c8bf7428cd8775aa1dfee293e7855269b2e8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: core: Release mac pools only VMs with disks on removed SD.
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/80752 )
Change subject: core: Release mac pools only VMs with disks on removed SD.
......................................................................
core: Release mac pools only VMs with disks on removed SD.
The force remove of storage domain currently releases mac pools of VMs
which are related to the entire storage pool.
The fix is to release the mac pools only for VMs which have disks
which are reside the the removed storage domain.
Change-Id: Ic9bfb91ad7c1683111ad83e377217d8afe0c416c
Bug-Url: https://bugzilla.redhat.com/1482569
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DetachStorageDomainFromPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ForceRemoveStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java
3 files changed, 12 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/80752
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9bfb91ad7c1683111ad83e377217d8afe0c416c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-guest-agent[master]: build: remove reference to non-existing directory
by Code Review
>From Vinzenz Feenstra <vfeenstr(a)redhat.com>:
Vinzenz Feenstra has submitted this change and it was merged. ( https://gerrit.ovirt.org/80091 )
Change subject: build: remove reference to non-existing directory
......................................................................
build: remove reference to non-existing directory
A directory "re" is added to search paths for modules. But this
directory is actually located outside of the repository root.
Whatever that was, it is not relevant anymore.
Change-Id: Ic5c1d1d97a15703effe8d1b13935bfb50f082bea
Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com>
---
M ovirt-guest-agent/setup.py
1 file changed, 0 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Vinzenz Feenstra: Looks good to me, approved
Tomas Golembiovsky: Verified
--
To view, visit https://gerrit.ovirt.org/80091
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5c1d1d97a15703effe8d1b13935bfb50f082bea
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: restapi: Update to model 4.2.15
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged. ( https://gerrit.ovirt.org/80683 )
Change subject: restapi: Update to model 4.2.15
......................................................................
restapi: Update to model 4.2.15
The most relevant changes in this new version of the model are
the following:
New features:
- Update @since tags to reflect backport of LLDP to oVirt 4.1.5
- Add firewalType property to Cluster
- Add hasIllegalImages property to VM
Bug fixes:
- Fix live documentation for adding a new Cluster
Change-Id: I45be5db6ce2a105a4076d2d6c4546da6339bbe75
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Martin Peřina: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80683
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45be5db6ce2a105a4076d2d6c4546da6339bbe75
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-log-collector[master]: inventory: improve table headers for VMs
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80800 )
Change subject: inventory: improve table headers for VMs
......................................................................
inventory: improve table headers for VMs
- Replace VMs headers to Virtual Machine(s)
- Replace Count to Number of Virtual Machine(s)
Change-Id: I900b4bf96383e9bdc17c6ffb3d80762abbec12b0
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/produceReport.sh
M src/inventory_report/produceReport/sqls/cluster_query_vms_per_cluster.sql
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80800
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I900b4bf96383e9bdc17c6ffb3d80762abbec12b0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-log-collector[master]: inventory: Add sosreport name and sha256 for hypervisors
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80798 )
Change subject: inventory: Add sosreport name and sha256 for hypervisors
......................................................................
inventory: Add sosreport name and sha256 for hypervisors
Change-Id: I83d5b8ca9720736e7d70d0868205225aa92f36d3
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/produceReport.sh
M src/inventory_report/unpackHostsSosReports.sh
2 files changed, 11 insertions(+), 2 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80798
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I83d5b8ca9720736e7d70d0868205225aa92f36d3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: frontend: Add updated size validation to vnic profile names.
by Code Review
>From Alona Kaplan <alkaplan(a)redhat.com>:
Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80697 )
Change subject: frontend: Add updated size validation to vnic profile names.
......................................................................
frontend: Add updated size validation to vnic profile names.
Maximum allowed vnic profile name size is now 256 characters;
it is not completely unlimited. Re-add size validation
with the new appropriate size (256).
Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1477161
Change-Id: I7d773ecdb3918a46043df3ba3af26cdb705bec04
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
--
To view, visit https://gerrit.ovirt.org/80697
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d773ecdb3918a46043df3ba3af26cdb705bec04
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: backend: replace network name with vdsm name when needed
by Code Review
>From Alona Kaplan <alkaplan(a)redhat.com>:
Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80469 )
Change subject: backend: replace network name with vdsm name when needed
......................................................................
backend: replace network name with vdsm name when needed
In a scenario where a network with a long name is removed or detached
from a cluster, detaching the network (which is now unmanaged) from
hosts will be impossible as mapping network name to vdsm name is no
longer possible.
To remedy this, on network removal, replace network_name in
vds_interface from network name to vdsm name in each interface
where the removed network is attached to in the datacenter or cluster.
Change-Id: I93fca4940deae3bff497c85fcaf46e1a87f07c02
Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1478790
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkFromClusterInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoImpl.java
5 files changed, 36 insertions(+), 1 deletion(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
--
To view, visit https://gerrit.ovirt.org/80469
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93fca4940deae3bff497c85fcaf46e1a87f07c02
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: improve macpool table display
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80776 )
Change subject: inventory: improve macpool table display
......................................................................
inventory: improve macpool table display
Change-Id: I4911218d2b54ceddfa7d7b184498f559622a48dc
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/produceReport.sh
M src/inventory_report/produceReport/sqls/mac_pools_query_show_data_based_on_datacenter_and_cluster.sql
2 files changed, 2 insertions(+), 3 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80776
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4911218d2b54ceddfa7d7b184498f559622a48dc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Improve table layout for cluster with no DC
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80775 )
Change subject: inventory: Improve table layout for cluster with no DC
......................................................................
inventory: Improve table layout for cluster with no DC
Change-Id: Ieb0758a7a05470e16ba2b40553b8f4cce3ae3f5a
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/pre-upgrade-checks
M src/inventory_report/produceReport/sqls/cluster_query_check_datacenter.sql
2 files changed, 9 insertions(+), 3 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80775
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb0758a7a05470e16ba2b40553b8f4cce3ae3f5a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month