August 2017 - Engine-commits - oVirt List Archives

Change in jenkins[master]: Add parameters to system tests
by Code Review 17 Aug '17

17 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/80342 ) Change subject: Add parameters to system tests ...................................................................... Add parameters to system tests System tests jobs used system-tests as jobs name and ovirt-system-tests as hard coded project name. We want to have the ability to use different project name in different sites and, maybe, in the future to support other types of products' system tests pre jobs are not needed anymore. Removing them. Change-Id: I2af96244e5819e7b1ccd368f48e2180ca39f35c2 Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- M jobs/confs/projects/ovirt/system-tests.yaml M jobs/confs/shell-scripts/system_tests.collect_logs.sh M jobs/confs/yaml/builders/system_tests_builders.yaml M jobs/confs/yaml/publishers/system_tests_publishers.yaml M jobs/confs/yaml/templates/system_tests_templates.yaml 5 files changed, 20 insertions(+), 25 deletions(-) Approvals: Barak Korren: Looks good to me, approved; Ready for merge Gil Shinar: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2af96244e5819e7b1ccd368f48e2180ca39f35c2 Gerrit-PatchSet: 22 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Staging Jenkins Server

1 0

Change in jenkins[master]: Pass git user and email to scm macros
by Code Review 17 Aug '17

17 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/80397 ) Change subject: Pass git user and email to scm macros ...................................................................... Pass git user and email to scm macros The poll stage requires the commit command which requires username and email configuration Change-Id: I3236b35895c8b0e4d58f9812b646ba2ad1796fec Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- M jobs/confs/projects/defaults.yaml M jobs/confs/yaml/scms/gerrit.yaml M jobs/confs/yaml/scms/standard.yaml M jobs/confs/yaml/templates/standard-stage.yaml 4 files changed, 10 insertions(+), 0 deletions(-) Approvals: Barak Korren: Looks good to me, approved; Ready for merge Gil Shinar: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3236b35895c8b0e4d58f9812b646ba2ad1796fec Gerrit-PatchSet: 13 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Staging Jenkins Server

1 0

Change in ovirt-engine[master]: backend: Add updated size validation to vnic profile names.
by Code Review 17 Aug '17

17 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80694 ) Change subject: backend: Add updated size validation to vnic profile names. ...................................................................... backend: Add updated size validation to vnic profile names. Maximum allowed vnic profile name size is now 256 characters; it is not completely unlimited. Re-add size validation with the new appropriate size (256). Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1477161 Change-Id: I312e63f294a42ee0010a26eb62ce05c76ef00496 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VnicProfile.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I312e63f294a42ee0010a26eb62ce05c76ef00496 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: AbstractSubTabTableView type inference
by Code Review 17 Aug '17

17 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80744 ) Change subject: webadmin: AbstractSubTabTableView type inference ...................................................................... webadmin: AbstractSubTabTableView type inference Change-Id: I86aaffa833c815c2b1bd36ed0de2d3af7d90a35f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AbstractSubTabTableView.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80744 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86aaffa833c815c2b1bd36ed0de2d3af7d90a35f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.1]: centos: drop usage of $releasever for centos
by Code Review 17 Aug '17

17 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/80746 ) Change subject: centos: drop usage of $releasever for centos ...................................................................... centos: drop usage of $releasever for centos centos sigs are not providing variants of $releasever so people testing oVirt on RHEL see failures due to 7Server repo missing. Replaced $releasever with an explicit "7" avoiding such issue. Issue: https://ovirt-jira.atlassian.net/browse/OVIRT-1292 Change-Id: I9fcde9db583d44fea2ac0607cac653925b8451e1 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-el7-x86_64-deps.repo.in 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fcde9db583d44fea2ac0607cac653925b8451e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Petr Balogh <pbalogh(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: Require WildFly 11
by Code Review 17 Aug '17

17 Aug '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. ( https://gerrit.ovirt.org/80722 ) Change subject: packaging: Require WildFly 11 ...................................................................... packaging: Require WildFly 11 Change-Id: Ia3d754db7a1b0789721ec695ecd06a4bb2bd0cfe Bug-Url: https://bugzilla.redhat.com/1475459 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3d754db7a1b0789721ec695ecd06a4bb2bd0cfe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: add_image_ticket null check for filename
by Code Review 17 Aug '17

17 Aug '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. ( https://gerrit.ovirt.org/80735 ) Change subject: core: add_image_ticket null check for filename ...................................................................... core: add_image_ticket null check for filename JsonRpcVdsServer: add_image_ticket -> add 'filename' to ticket dict only if not null. Change-Id: Ifcddb29b00092c758a7d4ede2eefb6d22928d588 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80735 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcddb29b00092c758a7d4ede2eefb6d22928d588 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Add updated size validation to network names.
by Code Review 17 Aug '17

17 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80344 ) Change subject: backend: Add updated size validation to network names. ...................................................................... backend: Add updated size validation to network names. Maximum allowed network name size is now 256 characters; it is not completely unlimited. Re-add size validations for network names with the new appropriate size (256). Change-Id: Ic6e795d148cc2ac860c3932267ba88113af6695c Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1477161 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Network.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6e795d148cc2ac860c3932267ba88113af6695c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: dbscripts: Increase vds_interface's network_name ...
by Code Review 17 Aug '17

17 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80340 ) Change subject: packaging: dbscripts: Increase vds_interface's network_name col size. ...................................................................... packaging: dbscripts: Increase vds_interface's network_name col size. vds_interface holds the network name of the relevant network. With the recent change to network names where networks are no longer restricted to 15 ASCII characters, vds_interface's network_name must follow suit and be increased to 256 bytes. Change-Id: I09bf3ee1fe6f875885b911a34628ffc16b613225 Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1478717 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/04_02_0470_increase_vds_interface_network_name_size.sql 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80340 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09bf3ee1fe6f875885b911a34628ffc16b613225 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: dbscripts: Increase vnic_profile's name column to...
by Code Review 17 Aug '17

17 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80220 ) Change subject: packaging: dbscripts: Increase vnic_profile's name column to 256 bytes. ...................................................................... packaging: dbscripts: Increase vnic_profile's name column to 256 bytes. By default vnic profiles are named after its underlying network. With the recent change to network names where networks are no longer restricted to 15 ASCII characters, vnic profile names must follow suit. Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1477569 Change-Id: I73dcabb3fd9404dc2802121d402e2c79fd5c8a75 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/04_02_0460_increase_vnic_profile_name_size.sql 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80220 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73dcabb3fd9404dc2802121d402e2c79fd5c8a75 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0