August 2017 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: packaging: setup: Remove unneeded STAGE_BOOT priority
by Code Review 17 Aug '17

17 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79570 ) Change subject: packaging: setup: Remove unneeded STAGE_BOOT priority ...................................................................... packaging: setup: Remove unneeded STAGE_BOOT priority Change-Id: I262a88959199def4e9eed77db2f3ca483fee5d23 Related-To: https://bugzilla.redhat.com/1472325 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/plugins/gr-he-common/core/misc.py 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/79570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I262a88959199def4e9eed77db2f3ca483fee5d23 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: pass vdsm name over network name to vmInfo/libvirtv...
by Code Review 17 Aug '17

17 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80481 ) Change subject: backend: pass vdsm name over network name to vmInfo/libvirtvmxml ...................................................................... backend: pass vdsm name over network name to vmInfo/libvirtvmxml The actual interface's name libvirt needs to make use of is vdsm_name and not the network's name which is to be used by engine. Pass vdsm_name to vmInfo and libvirt vm's xml instead of network name. Change-Id: Ie53dcf8cc81da8cb83b42d215e753f40cf1b727a Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1478806 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java 2 files changed, 8 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie53dcf8cc81da8cb83b42d215e753f40cf1b727a Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: ovn: Minor text cleanup
by Code Review 17 Aug '17

17 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/80621 ) Change subject: packaging: setup: ovn: Minor text cleanup ...................................................................... packaging: setup: ovn: Minor text cleanup Change-Id: If156a6fc8e9ec11a171c3ea6a1d89ff54ed98170 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Marcin Mirecki: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/80621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If156a6fc8e9ec11a171c3ea6a1d89ff54ed98170 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: Add updated size validation to network names.
by Code Review 17 Aug '17

17 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80666 ) Change subject: frontend: Add updated size validation to network names. ...................................................................... frontend: Add updated size validation to network names. Maximum allowed network name size is now 256 characters; it is not completely unlimited. Re-add size validations for network names with the new appropriate size (256). Change-Id: Ia01ed8969910a3499d7b08169a798bf460ff07f6 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java 1 file changed, 18 insertions(+), 15 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia01ed8969910a3499d7b08169a798bf460ff07f6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Update business entitites definitions of network re...
by Code Review 17 Aug '17

17 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80349 ) Change subject: backend: Update business entitites definitions of network related sizes ...................................................................... backend: Update business entitites definitions of network related sizes Network name maximum size was increased to 256 characters and doesn't longer match bond name and network interface name. Dedicate new size definitions for both with their previous sizes. Change-Id: I80dde91f703d726fa579d33444684fbeef754cab Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateOrUpdateBond.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkInterface.java 3 files changed, 5 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80349 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80dde91f703d726fa579d33444684fbeef754cab Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: Remove unneeded STAGE_BOOT priorities
by Code Review 17 Aug '17

17 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79567 ) Change subject: packaging: setup: Remove unneeded STAGE_BOOT priorities ...................................................................... packaging: setup: Remove unneeded STAGE_BOOT priorities Requires otopi patch https://gerrit.ovirt.org/79566 Change-Id: Id8ed298a3073493db741ff36d666338746853876 Related-To: https://bugzilla.redhat.com/1472325 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/base/core/misc.py M packaging/setup/plugins/ovirt-engine-health/base/core/misc.py M packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/core/misc.py M packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/misc.py M packaging/setup/plugins/ovirt-engine-setup/base/core/misc.py 6 files changed, 0 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/79567 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8ed298a3073493db741ff36d666338746853876 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: build: drop useless version.py
by Code Review 17 Aug '17

17 Aug '17

>From Vinzenz Feenstra <vfeenstr(a)redhat.com>: Vinzenz Feenstra has submitted this change and it was merged. ( https://gerrit.ovirt.org/80108 ) Change subject: build: drop useless version.py ...................................................................... build: drop useless version.py The module version.py is hardly used and most of the content is not outdated anyway. There is no real reason to keep it. Change-Id: I98fd82a6d5f2f8832793b28cc12b247e36326628 Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com> --- M Makefile.am M ovirt-guest-agent/Makefile.am M ovirt-guest-agent/setup.py D ovirt-guest-agent/version.py 4 files changed, 1 insertion(+), 26 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/80108 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98fd82a6d5f2f8832793b28cc12b247e36326628 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: remove debian directory
by Code Review 17 Aug '17

17 Aug '17

>From Vinzenz Feenstra <vfeenstr(a)redhat.com>: Vinzenz Feenstra has submitted this change and it was merged. ( https://gerrit.ovirt.org/80098 ) Change subject: remove debian directory ...................................................................... remove debian directory Remove the directory with debian packaging. We don't use it anymore and it causes only confusion. Change-Id: I5a3f344ca33d130b4708a156ae1b1672602c732d Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com> --- M Makefile.am D debian/README.source D debian/changelog D debian/compat D debian/control D debian/copyright D debian/docs D debian/files D debian/ovirt-guest-agent.upstart D debian/postinst D debian/postrm D debian/preinst D debian/rules D debian/source/format M ovirt-guest-agent/Makefile.am 15 files changed, 0 insertions(+), 191 deletions(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Looks good to me, approved Tomas Golembiovsky: Verified -- To view, visit https://gerrit.ovirt.org/80098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a3f344ca33d130b4708a156ae1b1672602c732d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: linux: fix missing argument for lambda of list_nics
by Code Review 17 Aug '17

17 Aug '17

>From Vinzenz Feenstra <vfeenstr(a)redhat.com>: Vinzenz Feenstra has submitted this change and it was merged. ( https://gerrit.ovirt.org/80105 ) Change subject: linux: fix missing argument for lambda of list_nics ...................................................................... linux: fix missing argument for lambda of list_nics Commit a76da96 added posibility to ignore certain interfaces from list of available NICs. This change added a new argument to the function ethtool_list_nics() that handles listing when python-ethtool is available. It however did not add the argument to the lambda used when there is no python-ethtool available. Change-Id: I3235e9a95ad7accde1e7d88973dc3fe03c8c0d2b Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com> --- M ovirt-guest-agent/GuestAgentLinux2.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3235e9a95ad7accde1e7d88973dc3fe03c8c0d2b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: implement sass compression in ovirt brand
by Code Review 17 Aug '17

17 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80576 ) Change subject: webadmin: implement sass compression in ovirt brand ...................................................................... webadmin: implement sass compression in ovirt brand * Turn on sass compression in ovirt-brand * rename the *.css files to .scss, prefix them with '_'. This changes them to be sass partials, which are then imported into other main files. * Created webadmin.scss and welcome.scss, to do the imports and compilation for those respective applications into webadmin.css and welcome.css * Change ovirt-brand to now use webadmin.css and welcome.css, which are now the compiled output from sass. Change-Id: I5b3f576b9348c08d5324fc53adce1d51676393c6 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/brands/ovirt-brand/pom.xml M frontend/brands/ovirt-brand/src/main/resources/branding.properties R frontend/brands/ovirt-brand/src/main/sass/_branding_common.scss R frontend/brands/ovirt-brand/src/main/sass/_branding_webadmin.scss R frontend/brands/ovirt-brand/src/main/sass/_ovirt-patternfly-compat.scss R frontend/brands/ovirt-brand/src/main/sass/_ovirt.scss R frontend/brands/ovirt-brand/src/main/sass/_patternfly-ovirt-overrides.scss R frontend/brands/ovirt-brand/src/main/sass/_webadmin_legacy.scss R frontend/brands/ovirt-brand/src/main/sass/_welcome_base.scss A frontend/brands/ovirt-brand/src/main/sass/webadmin.scss A frontend/brands/ovirt-brand/src/main/sass/welcome.scss 11 files changed, 26 insertions(+), 12 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80576 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b3f576b9348c08d5324fc53adce1d51676393c6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0