August 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: vdsbroker: Add GetLldpVDSCommand
by Code Review 07 Aug '17

07 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79917 ) Change subject: vdsbroker: Add GetLldpVDSCommand ...................................................................... vdsbroker: Add GetLldpVDSCommand The GetLldpVDSCommand is added to get the LLDP information as business entities from vdsbroker. Change-Id: Ic1cea600587137fbec582af0e7b1043b27bc6968 Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetLldpVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetLldpVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 4 files changed, 97 insertions(+), 0 deletions(-) Approvals: Dominik Holler: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1cea600587137fbec582af0e7b1043b27bc6968 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: net: Add entities for LLDP
by Code Review 07 Aug '17

07 Aug '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79915 ) Change subject: net: Add entities for LLDP ...................................................................... net: Add entities for LLDP The Link Layer Discovery Protocol (LLDP) is a vendor-neutral networking protocol, used by network devices, especially switches, for advertising their identity, capabilities and management addresses on an IEEE 802 local area network (LAN). The added entities prepare oVirt hosts to gather information from their networking interfaces and let oVirt Engine use this information in a beneficial way. Change-Id: Ib15ce5ef41218877eb074cd56ee3ca4ada667f26 Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/LldpInfo.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Tlv.java 2 files changed, 204 insertions(+), 0 deletions(-) Approvals: Dominik Holler: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib15ce5ef41218877eb074cd56ee3ca4ada667f26 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix NoTrimmingWhitespacesValidation
by Code Review 07 Aug '17

07 Aug '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. ( https://gerrit.ovirt.org/79588 ) Change subject: webadmin: fix NoTrimmingWhitespacesValidation ...................................................................... webadmin: fix NoTrimmingWhitespacesValidation The regex did not take into account the possibility that there will be only one non-whitespace character. Change-Id: Iaecb80a81419b234d3062325eef66c975a6cf7ca Bug-Url: https://bugzilla.redhat.com/1472143 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/NoTrimmingWhitespacesValidation.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/79588 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaecb80a81419b234d3062325eef66c975a6cf7ca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: setup: Add Engine FQDN to the answerfile
by Code Review 07 Aug '17

07 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80001 ) Change subject: packaging: setup: Add Engine FQDN to the answerfile ...................................................................... packaging: setup: Add Engine FQDN to the answerfile Add the Engine FQDN to summary on any separate host setup Change-Id: I11ea88d2004e8ebc38cf55a026aa7e24422ca5da bug-Url: https://bugzilla.redhat.com/1465859 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Ido Rosenzwig: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80001 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11ea88d2004e8ebc38cf55a026aa7e24422ca5da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: setup: Add dockerc plugin deprecation warning
by Code Review 07 Aug '17

07 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80312 ) Change subject: packaging: setup: Add dockerc plugin deprecation warning ...................................................................... packaging: setup: Add dockerc plugin deprecation warning Change-Id: I0473ec24d3ac13155871691092955c4645554f9d Bug-Url: https://bugzilla.redhat.com/1473179 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/dockerc/config.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0473ec24d3ac13155871691092955c4645554f9d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix VmDevicesConverter managed devices sorting
by Code Review 06 Aug '17

06 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80221 ) Change subject: core: Fix VmDevicesConverter managed devices sorting ...................................................................... core: Fix VmDevicesConverter managed devices sorting The current comparator breaks Comparator.compare's contract by violating the total order requirement. If two [non] managed devices are compared, the first [second] one will always be returned, violating the requirement that sgn(compare(x, y)) == -sgn(compare(y, x)). This patch fixes the problem by using Java 8's built in Comparator.comparing method. Change-Id: Ifd7ec5f36e00f4a4cbe7da64ea01d892c546a0a7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/libvirt/VmDevicesConverter.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd7ec5f36e00f4a4cbe7da64ea01d892c546a0a7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VmDevicesConverter#parseDisks signature
by Code Review 06 Aug '17

06 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80222 ) Change subject: core: VmDevicesConverter#parseDisks signature ...................................................................... core: VmDevicesConverter#parseDisks signature Removed the unused vmId parameter. Change-Id: If2187fe8371835623cbd4706565411eef1a2390a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/libvirt/VmDevicesConverter.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2187fe8371835623cbd4706565411eef1a2390a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Remove the 'experimental' flow
by Code Review 06 Aug '17

06 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79310 ) Change subject: Remove the 'experimental' flow ...................................................................... Remove the 'experimental' flow This patch completely remove the 'experimental' flow by removing both the deploy and the test jobs. This patch moved the test job template to the templates directory to maintain the ability to create the 'experimental' flow in different environments. Change-Id: Ib2c31f97343d7ce2c160dd3f8db6eddd6b066094 Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1446 --- D jobs/confs/projects/ovirt/deploy_to_experimental.yaml D jobs/confs/projects/ovirt/test-experimental-latest-repo.yaml A jobs/confs/yaml/templates/test-ovirt-repo.yaml 3 files changed, 9 insertions(+), 28 deletions(-) Approvals: Staging Jenkins Server: Passed CI tests Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79310 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2c31f97343d7ce2c160dd3f8db6eddd6b066094 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Staging Jenkins Server

1 0

Change in ovirt-engine[master]: core: SchedulingManager#runInternalFilters signature
by Code Review 06 Aug '17

06 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79687 ) Change subject: core: SchedulingManager#runInternalFilters signature ...................................................................... core: SchedulingManager#runInternalFilters signature Remove the unused argument filterPositionMap from runInternalFilters' signature. Change-Id: I8b4baf7f0bacee30a788b72d2b17c80d88a8fc44 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79687 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b4baf7f0bacee30a788b72d2b17c80d88a8fc44 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SchedulingManager#runExternalFilters signature
by Code Review 06 Aug '17

06 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79688 ) Change subject: core: SchedulingManager#runExternalFilters signature ...................................................................... core: SchedulingManager#runExternalFilters signature Removed the unused parameter messages from runExternalFilters' signature. Change-Id: I716facdb9080fc5dadda9b2c0f78853f0b82b1f4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I716facdb9080fc5dadda9b2c0f78853f0b82b1f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0