Change in ovirt-engine[master]: core: SchedulingManger getOrDefault usage
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79689 )
Change subject: core: SchedulingManger getOrDefault usage
......................................................................
core: SchedulingManger getOrDefault usage
Use Map#getOrDefault to clean up the code instead of boiler-plate
checking if the key exists in the map.
Change-Id: I29d8a9a27539f48491f80b1861a34684cfc0d2d7
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/79689
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29d8a9a27539f48491f80b1861a34684cfc0d2d7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-engine[master]: core: SchedulingManger ArrayList#sort usage
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79690 )
Change subject: core: SchedulingManger ArrayList#sort usage
......................................................................
core: SchedulingManger ArrayList#sort usage
Use ArrayList's optimized sort method instead of the general purpose
Collections#sort method.
Change-Id: Ic471fa965d5483f870e6322c6dcfb943797e1ec3
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/79690
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic471fa965d5483f870e6322c6dcfb943797e1ec3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in jenkins[master]: re-factor: Add 'scmtype' parameter to STD-CI
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79823 )
Change subject: re-factor: Add 'scmtype' parameter to STD-CI
......................................................................
re-factor: Add 'scmtype' parameter to STD-CI
The parameter affects the choice of 'scm' and 'trigger' macros.
This will allow to add 'github' support to existing templates.
Parameter defaults to 'gerrit' ATM to maintain compatibility with
existing code.
Change-Id: I707a9bcaeb70ec3973bd410a61fcd0f23e1f583a
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1084
---
M jobs/confs/projects/defaults.yaml
M jobs/confs/staging-projects/defaults.yaml
A jobs/confs/yaml/scms/standard.yaml
M jobs/confs/yaml/templates/standard-stage.yaml
M jobs/confs/yaml/triggers/standard.yaml
5 files changed, 23 insertions(+), 14 deletions(-)
Approvals:
Staging Jenkins Server: Passed CI tests
Eyal Edri: Looks good to me
Barak Korren: Verified; Looks good to me, approved; Ready for merge
Daniel Belenky: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79823
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I707a9bcaeb70ec3973bd410a61fcd0f23e1f583a
Gerrit-PatchSet: 7
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Staging Jenkins Server
6 years, 9 months
Change in jenkins[master]: re-factor: Remove SCM YAML file in STD-CI
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79843 )
Change subject: re-factor: Remove SCM YAML file in STD-CI
......................................................................
re-factor: Remove SCM YAML file in STD-CI
These files require extra work from developers, do not provide too many
needed features and pose problems for future enhancements.
See details in the Jira ticket.
Also changed some defaults to make this work without change to most
existing project definitions.
Change-Id: Ic1a54cb3216b78cdc454c1fd18fb5da7a9aeb4a7
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1553
---
M jobs/confs/projects/defaults.yaml
M jobs/confs/projects/ovirt/system-tests.yaml
M jobs/confs/staging-projects/defaults.yaml
D jobs/confs/yaml/scms/cockpit-ovirt.yaml
D jobs/confs/yaml/scms/fabric-ovirt.yaml
D jobs/confs/yaml/scms/gerrit-admin.yaml
D jobs/confs/yaml/scms/imgbased.yaml
D jobs/confs/yaml/scms/infra-ansible.yaml
D jobs/confs/yaml/scms/infra-docs.yaml
M jobs/confs/yaml/scms/jenkins.yaml
D jobs/confs/yaml/scms/mom.yaml
D jobs/confs/yaml/scms/otopi.yaml
D jobs/confs/yaml/scms/ovirt-appliance-scm.yaml
D jobs/confs/yaml/scms/ovirt-containers.yaml
D jobs/confs/yaml/scms/ovirt-dwh.yaml
D jobs/confs/yaml/scms/ovirt-engine-api-explorer.yaml
D jobs/confs/yaml/scms/ovirt-engine-api-metamodel.yaml
D jobs/confs/yaml/scms/ovirt-engine-api-model.yaml
D jobs/confs/yaml/scms/ovirt-engine-cli.yaml
D jobs/confs/yaml/scms/ovirt-engine-dashboard.yaml
D jobs/confs/yaml/scms/ovirt-engine-extension-aaa-jdbc.yaml
D jobs/confs/yaml/scms/ovirt-engine-extension-aaa-ldap.yaml
D jobs/confs/yaml/scms/ovirt-engine-extension-aaa-misc.yaml
D jobs/confs/yaml/scms/ovirt-engine-extension-logger-log4j.yaml
D jobs/confs/yaml/scms/ovirt-engine-metrics.yaml
D jobs/confs/yaml/scms/ovirt-engine-nodejs-modules.yaml
D jobs/confs/yaml/scms/ovirt-engine-nodejs.yaml
D jobs/confs/yaml/scms/ovirt-engine-phantomjs.yaml
D jobs/confs/yaml/scms/ovirt-engine-yarn.yaml
D jobs/confs/yaml/scms/ovirt-guest-agent.yaml
D jobs/confs/yaml/scms/ovirt-host.yaml
D jobs/confs/yaml/scms/ovirt-hosted-engine-setup.yaml
D jobs/confs/yaml/scms/ovirt-image-uploader.yaml
D jobs/confs/yaml/scms/ovirt-imageio.yaml
D jobs/confs/yaml/scms/ovirt-iso-uploader.yaml
D jobs/confs/yaml/scms/ovirt-jboss-modules-maven-plugin.yaml
D jobs/confs/yaml/scms/ovirt-js-dependencies.yaml
D jobs/confs/yaml/scms/ovirt-live.yaml
D jobs/confs/yaml/scms/ovirt-node-ng-scms.yaml
D jobs/confs/yaml/scms/ovirt-optimizer.yaml
D jobs/confs/yaml/scms/ovirt-provider-ovn.yaml
D jobs/confs/yaml/scms/ovirt-release.yaml
D jobs/confs/yaml/scms/ovirt-scheduler-proxy.yaml
D jobs/confs/yaml/scms/ovirt-setup-lib.yaml
D jobs/confs/yaml/scms/ovirt-system-tests.yaml
D jobs/confs/yaml/scms/ovirt-vdsmfake.yaml
D jobs/confs/yaml/scms/pthreading.yaml
D jobs/confs/yaml/scms/repoman.yaml
D jobs/confs/yaml/scms/stage-stdci.yaml
D jobs/confs/yaml/scms/vdsm-jsonrpc-java.yaml
D jobs/confs/yaml/scms/vdsm.yaml
M jobs/confs/yaml/templates/jenkins_deploy_yamls_template.yaml
M jobs/confs/yaml/templates/standard-stage.yaml
M jobs/confs/yaml/templates/system_tests_templates.yaml
54 files changed, 21 insertions(+), 356 deletions(-)
Approvals:
Staging Jenkins Server: Passed CI tests
Eyal Edri: Looks good to me
Barak Korren: Verified; Looks good to me, approved; Ready for merge
Daniel Belenky: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79843
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1a54cb3216b78cdc454c1fd18fb5da7a9aeb4a7
Gerrit-PatchSet: 10
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Staging Jenkins Server
6 years, 9 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Block adding disks without storage_domain
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80139 )
Change subject: core: Block adding disks without storage_domain
......................................................................
core: Block adding disks without storage_domain
When creating a disk / disk attachment without specifying a storage
domain, an error should be raised and the operation should fail.
The old functionality looks for a storage domain of another disk on
that VM and sets the new disk's storage domain according to it.
Change-Id: I1241b5c88885de1958f1e0754eba9ba8519c0a97
Bug-Url: https://bugzilla.redhat.com/1476744
Signed-off-by: Shani Leviim <sleviim(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java
2 files changed, 3 insertions(+), 12 deletions(-)
Approvals:
Benny Zlotnik: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Shani Leviim: Verified
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/80139
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1241b5c88885de1958f1e0754eba9ba8519c0a97
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Shani Leviim <sleviim(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Add postgresql-server as requirement for analyzer
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80211 )
Change subject: inventory: Add postgresql-server as requirement for analyzer
......................................................................
inventory: Add postgresql-server as requirement for analyzer
Change-Id: Ifd4f7db18f3de2f1575988abcd0f5843c02e37c1
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M ovirt-log-collector.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80211
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd4f7db18f3de2f1575988abcd0f5843c02e37c1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: merge storage domain and disks section
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80210 )
Change subject: inventory: merge storage domain and disks section
......................................................................
inventory: merge storage domain and disks section
Change-Id: I2fb829ed86fdf2b36ef1c8e073c4125f90c5df14
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/Makefile.am
M src/inventory_report/produceReport/produceReport.sh
M src/inventory_report/produceReport/sqls/storage_domains_query_data.sql
D src/inventory_report/produceReport/sqls/storage_domains_query_number_of_disks.sql
4 files changed, 3 insertions(+), 15 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80210
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fb829ed86fdf2b36ef1c8e073c4125f90c5df14
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Add external providers
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80209 )
Change subject: inventory: Add external providers
......................................................................
inventory: Add external providers
Change-Id: Ib2afe7a87549dae4f7f6e369bf1811bc82252931
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/Makefile.am
M src/inventory_report/produceReport/produceReport.sh
A src/inventory_report/produceReport/sqls/providers_query_show_data.sql
3 files changed, 48 insertions(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80209
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2afe7a87549dae4f7f6e369bf1811bc82252931
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: add engine fqdn in the header of inventory
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80208 )
Change subject: inventory: add engine fqdn in the header of inventory
......................................................................
inventory: add engine fqdn in the header of inventory
Change-Id: I8321c1885be03fd993a7f0f6c7cdbbe3e4cb1780
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/produceReport.sh
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80208
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8321c1885be03fd993a7f0f6c7cdbbe3e4cb1780
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-log-collector[master]: inventory: Add postgresql-server as requirement for analyzer
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80204 )
Change subject: inventory: Add postgresql-server as requirement for analyzer
......................................................................
inventory: Add postgresql-server as requirement for analyzer
Change-Id: Ifd4f7db18f3de2f1575988abcd0f5843c02e37c1
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M ovirt-log-collector.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/80204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd4f7db18f3de2f1575988abcd0f5843c02e37c1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months