- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Rename GetAll stored procedure name for DiskVmElement
by tnisan＠redhat.com 10 Jul '16

10 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Rename GetAll stored procedure name for DiskVmElement ...................................................................... core: Rename GetAll stored procedure name for DiskVmElement Rename GetAllFromDiskVmElement() to use the plural form GetAllFromDiskVmElements() as per DefaultReadDao standards Change-Id: Ic6cfcd7bff2081708d6dec82dda719b762c348b4 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M packaging/dbscripts/disk_vm_element_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60438 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6cfcd7bff2081708d6dec82dda719b762c348b4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add DiskVmElementDaoTest
by tnisan＠redhat.com 10 Jul '16

10 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Add DiskVmElementDaoTest ...................................................................... core: Add DiskVmElementDaoTest Change-Id: Ibc506efb9dd270dfcbc473419ba0e47e53071513 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskVmElementDaoTest.java 1 file changed, 72 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc506efb9dd270dfcbc473419ba0e47e53071513 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Added jenkins report job
by eedri＠redhat.com 10 Jul '16

10 Jul '16

Eyal Edri has submitted this change and it was merged. Change subject: Added jenkins report job ...................................................................... Added jenkins report job Like in D/S, I have added a job with groovy script that sends a report about all unstable jobs Change-Id: I9b9236dbdae3eb9a2f9cf519210f27a11739aa74 Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- A jobs/confs/groovy-scripts/system_report.groovy A jobs/confs/yaml/system_jobs.yaml 2 files changed, 129 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Looks good to me; Ready for merge Gil Shinar: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b9236dbdae3eb9a2f9cf519210f27a11739aa74 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove unaccessible memory during upgrade
by ahadas＠redhat.com 10 Jul '16

10 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: remove unaccessible memory during upgrade ...................................................................... core: remove unaccessible memory during upgrade This patch fixes an issue discovered in the upgrade process where the upgrade fails while trying to convert memory volumes on a storage domain that does not exist in the system to disk images. So before doing the conversion, such memory volumes are first being removed. They are unusable anyway. Change-Id: Iead5deab3c572f6bbc02af1f56c41ffdfdf0fc82 Bug-Url: https://bugzilla.redhat.com/1353219 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/dbscripts/upgrade/04_00_0140_convert_memory_snapshots_to_disks.sql 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iead5deab3c572f6bbc02af1f56c41ffdfdf0fc82 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Removing VmPoolUserCommandBase class
by ahadas＠redhat.com 10 Jul '16

10 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Removing VmPoolUserCommandBase class ...................................................................... core: Removing VmPoolUserCommandBase class Merging VmPoolUserCommandBase into AttachUserToVmFromPoolAndRunCommand: * VmPoolUserCommandBase removed; * initPoolUser() method moved into AttachUserToVmFromPoolAndRunCommand; * VmPoolUserParameters renamed to AttachUserToVmFromPoolAndRunParameters; * VmPoolSimpleUserCommandBase renamed to VmPoolUserCommandBase; * VmPoolSimpleUserParameters renamed to VmPoolUserParameters. Change-Id: I76e689324b9eda80e614e77ae5b9e02d74b15eda Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachUserFromVmFromPoolCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolSimpleUserCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolUserCommandBase.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachUserToVmFromPoolAndRunParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DetachUserFromVmFromPoolParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmPoolSimpleUserParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmPoolUserParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/PoolItemBehavior.java 11 files changed, 119 insertions(+), 133 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60442 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76e689324b9eda80e614e77ae5b9e02d74b15eda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Unify similar methods in VdsBrokerObjectsBuilder
by tnisan＠redhat.com 10 Jul '16

10 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Unify similar methods in VdsBrokerObjectsBuilder ...................................................................... core: Unify similar methods in VdsBrokerObjectsBuilder The methods extractIntegerList and extracStringtList (sic) are doing exactly the same aside for the fact that one returns null when elements are not found and the second returns an empty list. Both methods were unified to a single method Change-Id: Iedfd72038d28e92b1fd078a8d5536c8334f70733 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 11 insertions(+), 27 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58928 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedfd72038d28e92b1fd078a8d5536c8334f70733 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use Java streaming API in VdsBrokerObjectsBuilder
by tnisan＠redhat.com 10 Jul '16

10 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Use Java streaming API in VdsBrokerObjectsBuilder ...................................................................... core: Use Java streaming API in VdsBrokerObjectsBuilder Change-Id: I6c756b7bfae4c76759ba7feb79f13d8eb7ede007 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 29 insertions(+), 45 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58927 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c756b7bfae4c76759ba7feb79f13d8eb7ede007 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VmPoolSimpleUserCommandBase cleanup
by ahadas＠redhat.com 10 Jul '16

10 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: VmPoolSimpleUserCommandBase cleanup ...................................................................... core: VmPoolSimpleUserCommandBase cleanup Removing redundant code from VmPoolSimpleUserCommandBase. Change-Id: I3104ca7357f1fb6149db7d3fbeebb158b85cebf9 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolSimpleUserCommandBase.java 1 file changed, 5 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60339 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3104ca7357f1fb6149db7d3fbeebb158b85cebf9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Cleanup of AddVmToPoolCommand
by ahadas＠redhat.com 10 Jul '16

10 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Cleanup of AddVmToPoolCommand ...................................................................... core: Cleanup of AddVmToPoolCommand Removing unnecessary method overrides from AddVmToPoolCommand. Change-Id: Ib47573960bdd7e4187194c1de1bfe4763ea655eb Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmToPoolCommand.java 1 file changed, 1 insertion(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60334 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib47573960bdd7e4187194c1de1bfe4763ea655eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: use clusterId if dcId isn't available in ImportValid...
by tnisan＠redhat.com 10 Jul '16

10 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: use clusterId if dcId isn't available in ImportValidator ...................................................................... engine: use clusterId if dcId isn't available in ImportValidator Change-Id: I5d2426da7249c14611b4d9ee70f32c7896dcbb3b Bug-Url: https://bugzilla.redhat.com/1351145 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportParameters.java 2 files changed, 19 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/60344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d2426da7249c14611b4d9ee70f32c7896dcbb3b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>

1 0