- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: core: remove inaccessible memory during upgrade
by tnisan＠redhat.com 11 Jul '16

11 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: remove inaccessible memory during upgrade ...................................................................... core: remove inaccessible memory during upgrade This patch fixes an issue discovered in the upgrade process where the upgrade fails while trying to convert memory volumes on a storage domain that does not exist in the system to disk images. So before doing the conversion, such memory volumes are first being removed. They are unusable anyway. Change-Id: Iead5deab3c572f6bbc02af1f56c41ffdfdf0fc82 Bug-Url: https://bugzilla.redhat.com/1353219 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/dbscripts/upgrade/04_00_0140_convert_memory_snapshots_to_disks.sql 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iead5deab3c572f6bbc02af1f56c41ffdfdf0fc82 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Use type name as the tag for method parameters
by omachace＠redhat.com 11 Jul '16

11 Jul '16

Ondra Machacek has submitted this change and it was merged. Change subject: Use type name as the tag for method parameters ...................................................................... Use type name as the tag for method parameters Currently the name of the XML tag used to represent the input parameters of methods like "add" is the name of the parameter as described in the model. For example, for the operation to add a disk attachment the name of the parameter is "attachment", so the XML document generated and sent by the SDK is something like this: <attachment> ... </attachment> But the server doesn't expect this, it expects the name the XML tag corresponding to the type of the parameter, in this case this case "DiskAttachment", so the server expects the following: <disk_attachment> ... </disk_attachment> It would be more correct to use the name of the parameter, as described in the model, but it isn't factible to introduce such change in the server side at this point, so we need to change the SDK to generate what the server expects. That is what this patch does. In the future, we will probably change the server so that it ignores the root tag of the documents, then this patch can be reverted. Change-Id: I18284685f5eefc981fd6769ac7e1ca998d586a81 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60462 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18284685f5eefc981fd6769ac7e1ca998d586a81 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Translations of OriginType enum added
by tnisan＠redhat.com 11 Jul '16

11 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Translations of OriginType enum added ...................................................................... webadmin: Translations of OriginType enum added Explicite translations of OriginType.MANAGED_HOSTED_ENGINE and OriginType.KVM Change-Id: I87afbfcb31408925ed55d32d2ee6124cb6488e58 Bug-Url: https://bugzilla.redhat.com/1351477 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87afbfcb31408925ed55d32d2ee6124cb6488e58 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Add RPM spec file for Fedora 24
by omachace＠redhat.com 11 Jul '16

11 Jul '16

Ondra Machacek has submitted this change and it was merged. Change subject: Add RPM spec file for Fedora 24 ...................................................................... Add RPM spec file for Fedora 24 This patch adds a RPM spec file for Fedora 24. Change-Id: I8c2562c55886506a0023e78038065b78d8290320 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 8d63281d3bc98e14351949f84f4097e45181e5cd) --- A packaging/spec.fc24.in 1 file changed, 47 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60501 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c2562c55886506a0023e78038065b78d8290320 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Add RPM spec file for Fedora 24
by omachace＠redhat.com 11 Jul '16

11 Jul '16

Ondra Machacek has submitted this change and it was merged. Change subject: Add RPM spec file for Fedora 24 ...................................................................... Add RPM spec file for Fedora 24 This patch adds a RPM spec file for Fedora 24. Change-Id: I8c2562c55886506a0023e78038065b78d8290320 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A packaging/spec.fc24.in 1 file changed, 47 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c2562c55886506a0023e78038065b78d8290320 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Engine: Cancel Unnecessary Inheritance (codefix)
by oliel＠redhat.com 11 Jul '16

11 Jul '16

Ori Liel has submitted this change and it was merged. Change subject: Engine: Cancel Unnecessary Inheritance (codefix) ...................................................................... Engine: Cancel Unnecessary Inheritance (codefix) Currently VdsNotRespondingTreatmentCommand unnecessarily inherits RestartVdsCommand. This patch removes this unnecessary inheritance. Change-Id: Ie2803fd2ef835800941627892cb2414a4a578ea5 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/RestartVdsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/RestartVdsReturnValue.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java 3 files changed, 53 insertions(+), 25 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2803fd2ef835800941627892cb2414a4a578ea5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Cluster update triggers VM update only if necessary
by ahadas＠redhat.com 11 Jul '16

11 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Cluster update triggers VM update only if necessary ...................................................................... core: Cluster update triggers VM update only if necessary There was a problem when user tried to edit Cluster while there was a migrating VM in the Cluster. The root cause was collision of VM locks of MigrateVmCommand and UpdateVmCommand called by UpdateClusterCommand. This patch doesn't solve the problem entirely. It only lowers the probability its occurrence by triggering UpdateVmCommand only if cluster compatibility level was changed. Change-Id: Ieccac1f08847681d5f326b9c54a99364720cfdb0 Bug-Url: https://bugzilla.redhat.com/1349526 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Marek Libra: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieccac1f08847681d5f326b9c54a99364720cfdb0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Introduce GlusterUtil#volumeAsMap
by amureini＠redhat.com 11 Jul '16

11 Jul '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Introduce GlusterUtil#volumeAsMap ...................................................................... core: Introduce GlusterUtil#volumeAsMap Intro a helper method to represent a GlusterVolumeEntity as a Map instead of creating an anonymous subtype of HashMap<String, String>, which clutters up the classloader for no good reason. Change-Id: I791c191687c90435680663da03860fc454acad1e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I791c191687c90435680663da03860fc454acad1e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GlusterUtil type inference
by amureini＠redhat.com 11 Jul '16

11 Jul '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GlusterUtil type inference ...................................................................... core: GlusterUtil type inference Change-Id: Ie3a23ad269561d36bb0f29e1c2e35d6edc7ba7e9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3a23ad269561d36bb0f29e1c2e35d6edc7ba7e9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Translations of OriginType enum added
by mbetak＠redhat.com 11 Jul '16

11 Jul '16

Martin Betak has submitted this change and it was merged. Change subject: webadmin: Translations of OriginType enum added ...................................................................... webadmin: Translations of OriginType enum added Explicite translations of OriginType.MANAGED_HOSTED_ENGINE and OriginType.KVM Change-Id: I87afbfcb31408925ed55d32d2ee6124cb6488e58 Bug-Url: https://bugzilla.redhat.com/1351477 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87afbfcb31408925ed55d32d2ee6124cb6488e58 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0