- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Update to model 4.1.4
by tnisan＠redhat.com 05 Jul '16

05 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Update to model 4.1.4 ...................................................................... restapi: Update to model 4.1.4 The relevant changes in this version of the model are the following: * Removed the `disks` locator from the virtual machine service, as it has been replaced by `diskAttachments`. * Added missing links to all types. Change-Id: I68fe6cbd31d6deeb9352255a837c996d6102e82f Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/util/LinkHelperTest.java M pom.xml 4 files changed, 3 insertions(+), 19 deletions(-) Approvals: Tal Nisan: Passed CI tests Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68fe6cbd31d6deeb9352255a837c996d6102e82f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: fix UI exceptions in volumes tab
by tnisan＠redhat.com 05 Jul '16

05 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix UI exceptions in volumes tab ...................................................................... webadmin: fix UI exceptions in volumes tab This patch fixes the UI exceptions in following places 1. Exceptions are flooded in the UI, with user hower over the the empty Activities column in Gluster Volumes tab and Bricks Subtab. There is a NPE in VolumeActivityCompositeCell. getContainerElement() method. Fixed this issue by showing the composite cell always. When there is not activity in the volume then we will add a table with empty row. 2. There is an exception in UI, when there is no suitable cluster for gep rep slave. We should not try to set the selection when the list itself is empty. Change-Id: If1fcfb584dd250ec7550df98eeb4dfe7c442fc5a Bug-Url: https://bugzilla.redhat.com/1303878 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> (cherry picked from commit dde3b1190ac518980e9ec12815899da5e845f65f) --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepCreateModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeActivityCompositeCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeActivitySeperatorCell.java 5 files changed, 24 insertions(+), 29 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/60085 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1fcfb584dd250ec7550df98eeb4dfe7c442fc5a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Add support for generating random doubles
by juan.hernandez＠redhat.com 05 Jul '16

05 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add support for generating random doubles ...................................................................... restapi: Add support for generating random doubles Our testing framework generates random data for types, but it doesn't support the "double" type. This patch fixes that limitation. Change-Id: I34599c55871bfbf0063af52a7232486ca9d3f4f2 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/MappingTestHelper.java 1 file changed, 35 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60191 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34599c55871bfbf0063af52a7232486ca9d3f4f2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Populate links of disk attachments
by juan.hernandez＠redhat.com 05 Jul '16

05 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Populate links of disk attachments ...................................................................... restapi: Populate links of disk attachments Currently the disk attachments don't have links because the reference to the parent virtual machine isn't populated. This patch fixes that issue. Change-Id: I5dabae64ad5fbf48a8f085cad4d302974cd79df7 Bug-Url: https://bugzilla.redhat.com/1352657 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskAttachmentMapper.java 2 files changed, 22 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60161 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5dabae64ad5fbf48a8f085cad4d302974cd79df7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GlusterBrickValidatorTest type inference
by amureini＠redhat.com 05 Jul '16

05 Jul '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GlusterBrickValidatorTest type inference ...................................................................... core: GlusterBrickValidatorTest type inference Change-Id: I8a70de80a68560f999b9f9b4bf6c2bec33c57982 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/GlusterBrickValidatorTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/60173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a70de80a68560f999b9f9b4bf6c2bec33c57982 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GlusterBrickValidatorTest whitespaces
by amureini＠redhat.com 05 Jul '16

05 Jul '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GlusterBrickValidatorTest whitespaces ...................................................................... core: GlusterBrickValidatorTest whitespaces Removed redundant empty lines at the end of methods. This empty lines just bloat the code and do nothing to improve the code's readability. Change-Id: I946a797d014dd40b3a6af206fdb770f436737e02 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/GlusterBrickValidatorTest.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/60175 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I946a797d014dd40b3a6af206fdb770f436737e02 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GlusterBrickValidatorTest assertions
by amureini＠redhat.com 05 Jul '16

05 Jul '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GlusterBrickValidatorTest assertions ...................................................................... core: GlusterBrickValidatorTest assertions Modernize the assertions in this test class using the assertThat syntax with the custom matchers from org.ovirt.engine.core.bll.validator.ValidationResultMatchers. This lends towards making the code more readable and the failure messages clearer. Change-Id: I957166c0514ad1a33d804fd69259c2e22c4277e7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/GlusterBrickValidatorTest.java 1 file changed, 27 insertions(+), 30 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/60174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I957166c0514ad1a33d804fd69259c2e22c4277e7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Adding pretty name to OS version format
by emesika＠redhat.com 05 Jul '16

05 Jul '16

Eli Mesika has submitted this change and it was merged. Change subject: core: Adding pretty name to OS version format ...................................................................... core: Adding pretty name to OS version format This patch adds pretty_name to vds_dynamic table and to the data access layer. This field is filled by the VDSM and sent to the engine's VdsBroker which persist it to the database. The pretty name is a friendly representation of the OS release/version and is displayed as a separate field in the UI Host->General->Software sub tab and is also available from the API when getting the host information. Change-Id: I0b1cc2fa4f9e351eae1b855670b3ffe505a2c618 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1346782 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDaoImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralSoftwareView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_01_0120_add_vds_dynamic_pretty_name.sql M packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql M packaging/dbscripts/vds_sp.sql 15 files changed, 66 insertions(+), 7 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b1cc2fa4f9e351eae1b855670b3ffe505a2c618 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[cli_3.6]: cli: Prepare for next release
by juan.hernandez＠redhat.com 05 Jul '16

05 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Prepare for next release ...................................................................... cli: Prepare for next release In preparation for the next release this patch increases the version number and sets the RPM release number to 0.1. Change-Id: Ib12dafc5174acdcf0b9d3858cdc62c342a91af62 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60187 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib12dafc5174acdcf0b9d3858cdc62c342a91af62 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[cli_3.6]: cli: Release 3.6.8.0
by juan.hernandez＠redhat.com 05 Jul '16

05 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Release 3.6.8.0 ...................................................................... cli: Release 3.6.8.0 Change-Id: Id922a74c6896e68d92a9e519a07b90edb20c06ea Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 6 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id922a74c6896e68d92a9e519a07b90edb20c06ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0