- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: fix missing keys
by sabose＠redhat.com 04 Jul '16

04 Jul '16

Sahina Bose has submitted this change and it was merged. Change subject: userportal: fix missing keys ...................................................................... userportal: fix missing keys Fix build errors due to missing keys Change-Id: I046d2237127ac72d4c446453c2b5f338db246cf1 Bug-Url: https://bugzilla.redhat.com/1255590 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Sahina Bose: Verified -- To view, visit https://gerrit.ovirt.org/60127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I046d2237127ac72d4c446453c2b5f338db246cf1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Take VM lock before assigning a pooled VM to user
by tnisan＠redhat.com 04 Jul '16

04 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Take VM lock before assigning a pooled VM to user ...................................................................... core: Take VM lock before assigning a pooled VM to user In AttachUserToVmFromPoolAndRunCommand, take an exclusive lock on the VM before setting user's ownership on it. This prevents other commands to act on this VM before it is run as the result of AttachUserToVmFromPoolAndRunCommand. On another side, if the VM is already locked by some other command (e.g. RunVmCommand), AttachUserToVmFromPoolAndRunCommand will not be able to lock it and will be forced to take another VM from the pool. Change-Id: Id2290f7b229041b989011f2acd4bf96af51357f9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1350403 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java 1 file changed, 103 insertions(+), 39 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified -- To view, visit https://gerrit.ovirt.org/60119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2290f7b229041b989011f2acd4bf96af51357f9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Add parenthesis to sql remove query
by tnisan＠redhat.com 04 Jul '16

04 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Add parenthesis to sql remove query ...................................................................... core: Add parenthesis to sql remove query Once we remove old unreigstered disks of a storage domain the query should use parenthesis. Change-Id: I968d5a59039038089e9690a2e5f7c18f03195159 Bug-Url: https://bugzilla.redhat.com/1302780 Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com> --- M packaging/dbscripts/unregistered_disks_sp.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60125 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I968d5a59039038089e9690a2e5f7c18f03195159 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Added SwitchType property to Cluster.
by juan.hernandez＠redhat.com 04 Jul '16

04 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Added SwitchType property to Cluster. ...................................................................... restapi: Added SwitchType property to Cluster. Change-Id: Iac82b6637a6f998bc9d56507a0b5c9fc6bb83d6f Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/SwitchTypeMapper.java 2 files changed, 38 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56199 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac82b6637a6f998bc9d56507a0b5c9fc6bb83d6f Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix HE disk unassigned status
by rgolan＠redhat.com 04 Jul '16

04 Jul '16

Roy Golan has submitted this change and it was merged. Change subject: core: fix HE disk unassigned status ...................................................................... core: fix HE disk unassigned status Hosted engine disk status is unassigned although it is working correctly. fix : on hosted engine import VM - set the disk status to OK upgrade script : move all hosted engine disk images from unassigned status to OK when the VM is plugged. Change-Id: I0386843a7e23e89425c9bf5be075c1344c159eaf Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1339660 Signed-off-by: yquinn <yquinn(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostedEngineImporter.java A packaging/dbscripts/upgrade/04_01_0110_change_disk_status_to_ok.sql 2 files changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/59643 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0386843a7e23e89425c9bf5be075c1344c159eaf Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: packaging: setup: Do not write db password to answerfile if ...
by Shirly Radco 04 Jul '16

04 Jul '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: Do not write db password to answerfile if provisioning ...................................................................... packaging: setup: Do not write db password to answerfile if provisioning Change-Id: I24691c6a845a85bcdc54c00d27fcad5d27cfc555 Bug-Url: https://bugzilla.redhat.com/1332892 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/dwh/constants.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/58916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24691c6a845a85bcdc54c00d27fcad5d27cfc555 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: extract EntityDao out of DbFacade
by masayag＠redhat.com 03 Jul '16

03 Jul '16

Moti Asayag has submitted this change and it was merged. Change subject: core: extract EntityDao out of DbFacade ...................................................................... core: extract EntityDao out of DbFacade Change-Id: I40356cab8da9ea54b903e6b1e0df9314299d1b6c Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PermissionsCommandBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EntityDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EntityDaoImpl.java D backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeDaoTest.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EntityDaoImplTest.java M backend/manager/modules/dal/src/test/resources/test-beans.xml 8 files changed, 298 insertions(+), 226 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/59687 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40356cab8da9ea54b903e6b1e0df9314299d1b6c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: exctact OsInfoDao out of DbFacade
by masayag＠redhat.com 03 Jul '16

03 Jul '16

Moti Asayag has submitted this change and it was merged. Change subject: core: exctact OsInfoDao out of DbFacade ...................................................................... core: exctact OsInfoDao out of DbFacade Exctact OsInfoDao out of DbFacade and add a test for that. Change-Id: Id05345deeeea1159f77ecb936dbc1a37bf18d448 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/CustomMapSqlParameterSource.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/dwh/OsInfoDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/dwh/OsInfoDaoImpl.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/dwh/OsInfoDaoImplTest.java M backend/manager/modules/dal/src/test/resources/test-beans.xml 7 files changed, 171 insertions(+), 30 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/59686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id05345deeeea1159f77ecb936dbc1a37bf18d448 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Warn for running VMs when cluster level change
by ahadas＠redhat.com 03 Jul '16

03 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: Warn for running VMs when cluster level change ...................................................................... webadmin: Warn for running VMs when cluster level change When changing cluster level of a cluster with running VMs, a warning is shown stating requirement to reboot all these VMs once the cluster level is changed. All running/paused non-[Hosted Engine|External] VMs are marked with the NextRun configuration mark to denote the requirement. The HE VM is handled in other path. Prior this fix, the cluster level change was not allowed when there were running VMs. This fix solves issue with hosted engine VM running at the time of cluster level change. Change-Id: I8628d6794248076599087bd22aa3aca44fde69e2 Bug-Url: https://bugzilla.redhat.com/1348907 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 14 files changed, 54 insertions(+), 50 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8628d6794248076599087bd22aa3aca44fde69e2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove redundant fields from DbFacade
by masayag＠redhat.com 03 Jul '16

03 Jul '16

Moti Asayag has submitted this change and it was merged. Change subject: core: remove redundant fields from DbFacade ...................................................................... core: remove redundant fields from DbFacade The removed fields are: * dbFacadeLocator * onStartConnectionTimeout * connectionCheckInterval Change-Id: I470b33a6d9a19144977eed5b3bb154569be7a124 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/test/resources/test-beans.xml 2 files changed, 2 insertions(+), 12 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/59524 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I470b33a6d9a19144977eed5b3bb154569be7a124 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0