- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0.1]: core: Add parenthesis to sql remove query
by tnisan＠redhat.com 04 Jul '16

04 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Add parenthesis to sql remove query ...................................................................... core: Add parenthesis to sql remove query Once we remove old unreigstered disks of a storage domain the query should use parenthesis. Change-Id: I968d5a59039038089e9690a2e5f7c18f03195159 Bug-Url: https://bugzilla.redhat.com/1302780 Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com> --- M packaging/dbscripts/unregistered_disks_sp.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I968d5a59039038089e9690a2e5f7c18f03195159 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.1]: core: Pass storage pool ID to disk images on storage validation
by tnisan＠redhat.com 04 Jul '16

04 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Pass storage pool ID to disk images on storage validation ...................................................................... core: Pass storage pool ID to disk images on storage validation Commit 2c6791 introduced a refactoring of whether images exist on storage check, however it used the storage pool ID taken from the images where in the case of import the image storage pool ID contains the original storage pool the images resided on which may not be the storage pool we import the image to. The storage pool ID was restored from the original behavior and is now taken from the parameters of the commands. Change-Id: I505a70ccb142030d5db140c9da7b03eab939f646 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1352422 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidator.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60140 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I505a70ccb142030d5db140c9da7b03eab939f646 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in restore stateless vm
by ahadas＠redhat.com 04 Jul '16

04 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in restore stateless vm ...................................................................... core: cleanup in restore stateless vm Extract the code that detaches disks that are not part of the stateless snapshot to another method and the instantiation of the parameters for the DetachDiskFromVm to a separate method as well. Change-Id: I3fd4b2d3ace2d15071d50897f221b9990b8e1d67 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java 1 file changed, 31 insertions(+), 17 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59472 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fd4b2d3ace2d15071d50897f221b9990b8e1d67 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Pass storage pool ID to disk images on storage validation
by tnisan＠redhat.com 04 Jul '16

04 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Pass storage pool ID to disk images on storage validation ...................................................................... core: Pass storage pool ID to disk images on storage validation Commit 2c6791 introduced a refactoring of whether images exist on storage check, however it used the storage pool ID taken from the images where in the case of import the image storage pool ID contains the original storage pool the images resided on which may not be the storage pool we import the image to. The storage pool ID was restored from the original behavior and is now taken from the parameters of the commands. Change-Id: I505a70ccb142030d5db140c9da7b03eab939f646 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1352422 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidator.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60137 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I505a70ccb142030d5db140c9da7b03eab939f646 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: userportal: fix missing keys
by tnisan＠redhat.com 04 Jul '16

04 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: userportal: fix missing keys ...................................................................... userportal: fix missing keys Fix build errors due to missing keys Change-Id: I046d2237127ac72d4c446453c2b5f338db246cf1 Bug-Url: https://bugzilla.redhat.com/1255590 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Sahina Bose: Verified -- To view, visit https://gerrit.ovirt.org/60130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I046d2237127ac72d4c446453c2b5f338db246cf1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Pass storage pool ID to disk images on storage validation
by tnisan＠redhat.com 04 Jul '16

04 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Pass storage pool ID to disk images on storage validation ...................................................................... core: Pass storage pool ID to disk images on storage validation Commit 2c6791 introduced a refactoring of whether images exist on storage check, however it used the storage pool ID taken from the images where in the case of import the image storage pool ID contains the original storage pool the images resided on which may not be the storage pool we import the image to. The storage pool ID was restored from the original behavior and is now taken from the parameters of the commands. Change-Id: I505a70ccb142030d5db140c9da7b03eab939f646 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1352422 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidator.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Liron Aravot: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/60131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I505a70ccb142030d5db140c9da7b03eab939f646 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix JavaDoc in DiskImagesValidator::diskImagesOnStorage
by tnisan＠redhat.com 04 Jul '16

04 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix JavaDoc in DiskImagesValidator::diskImagesOnStorage ...................................................................... core: Fix JavaDoc in DiskImagesValidator::diskImagesOnStorage Change-Id: I2a3671732af029b91d2d0710933914b178724487 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidator.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a3671732af029b91d2d0710933914b178724487 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: vdsbroker: Do not send ksmMerge var to MOM on 3.5 host
by tnisan＠redhat.com 04 Jul '16

04 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: vdsbroker: Do not send ksmMerge var to MOM on 3.5 host ...................................................................... vdsbroker: Do not send ksmMerge var to MOM on 3.5 host The ksmMergeAcrossNodes variable was introduced in MOM that is only released as part of oVirt 3.6 and later. Sending it to older MOM causes issues with policy evaluation. Change-Id: I45108487662bc4a1803174f35104288ef198f72d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1339126 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetMOMPolicyParametersVDSCommand.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45108487662bc4a1803174f35104288ef198f72d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Warn for running VMs when cluster level change
by tnisan＠redhat.com 04 Jul '16

04 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Warn for running VMs when cluster level change ...................................................................... webadmin: Warn for running VMs when cluster level change When changing cluster level of a cluster with running VMs, a warning is shown stating requirement to reboot all these VMs once the cluster level is changed. All running/paused non-[Hosted Engine|External] VMs are marked with the NextRun configuration mark to denote the requirement. The HE VM is handled in other path. Prior this fix, the cluster level change was not allowed when there were running VMs. This fix solves issue with hosted engine VM running at the time of cluster level change. Change-Id: I8628d6794248076599087bd22aa3aca44fde69e2 Bug-Url: https://bugzilla.redhat.com/1348907 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 14 files changed, 56 insertions(+), 50 deletions(-) Approvals: Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8628d6794248076599087bd22aa3aca44fde69e2 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: validate CPU topology in UpdateVMCommand
by ahadas＠redhat.com 04 Jul '16

04 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: validate CPU topology in UpdateVMCommand ...................................................................... core: validate CPU topology in UpdateVMCommand Update of running VM's CPU count fails when adding more CPUs than available on the host. Change-Id: Ideb4db8c3f4f53fc08e305da1026459c5da073a5 Bug-Url: https://bugzilla.redhat.com/1303450 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 28 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59618 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ideb4db8c3f4f53fc08e305da1026459c5da073a5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0