- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: MacPool per Cluster; update db so that cluster referen...
by alkaplan＠redhat.com 30 May '16

30 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: MacPool per Cluster; update db so that cluster references pool ...................................................................... core: MacPool per Cluster; update db so that cluster references pool • added new column to cluster table • migrated data from StoragePool table — since each cluster has exactly one datacenter, it's straighforward to move pool reference from DC to cluster. • updated adding / modifying / querying of cluster so that mac_pool_id is added / modified / returned respectively. • added query to get pool by cluster id. Bug-Url: https://bugzilla.redhat.com/994283 Change-Id: Id01a33276e3227d7e8bb4b1c8eabbc3af1cafe07 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Cluster.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNicDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNicDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ClusterDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/clusters_sp.sql M packaging/dbscripts/mac_pools_sp.sql M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/04_00_0720_add_mac_pool_id_to_vds_group.sql 11 files changed, 134 insertions(+), 16 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/50755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id01a33276e3227d7e8bb4b1c8eabbc3af1cafe07 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix template import flow
by tnisan＠redhat.com 30 May '16

30 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix template import flow ...................................................................... core: Fix template import flow Change-Id: I2882f30db2d19e2768e71e429a382259b7dd24bd Bug-Url: https://bugzilla.redhat.com/1339686 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58248 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2882f30db2d19e2768e71e429a382259b7dd24bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: fixed typo in migration policy name
by tnisan＠redhat.com 30 May '16

30 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: fixed typo in migration policy name ...................................................................... core: fixed typo in migration policy name replaced 'not may not' to 'may not' Change-Id: Ib49e6e29548507bdc57cd2637f7a30b0a3e1b715 Bug-Url: https://bugzilla.redhat.com/1338843 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58033 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib49e6e29548507bdc57cd2637f7a30b0a3e1b715 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Adapted set_MODIFIED hook to check the branch-milestone
by eedri＠redhat.com 30 May '16

30 May '16

Eyal Edri has submitted this change and it was merged. Change subject: Adapted set_MODIFIED hook to check the branch-milestone ...................................................................... Adapted set_MODIFIED hook to check the branch-milestone Change-Id: I092e22a632aab93bda8c47b1f32df8166867d916 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M hooks/custom_hooks/change-merged.set_MODIFIED M hooks/lib/gerrit.sh M hooks/lib/tools.sh 3 files changed, 115 insertions(+), 20 deletions(-) Approvals: Eyal Edri: Looks good to me, approved Jenkins CI: Passed CI tests David Caro: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I092e22a632aab93bda8c47b1f32df8166867d916 Gerrit-PatchSet: 7 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix build failure
by masayag＠redhat.com 30 May '16

30 May '16

Moti Asayag has submitted this change and it was merged. Change subject: core: Fix build failure ...................................................................... core: Fix build failure Fixes build failure in GWT part, which was caused by patch I535bdfeba41b03c86520408e72abfa914fe3e1be. Change-Id: Ibfceb8b1e27555bdcf249d927c0f0ff74963956d Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58242 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfceb8b1e27555bdcf249d927c0f0ff74963956d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Enforce Clone for template import without base
by tjelinek＠redhat.com 30 May '16

30 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Enforce Clone for template import without base ...................................................................... webadmin: Enforce Clone for template import without base Import of a template without existing base template has to be performed by cloning. Enforced on front-end. Change-Id: I1d1168daaab129a37dc8b31945214fc38a1624cd Bug-Url: https://bugzilla.redhat.com/1328725 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportEntityData.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 4 files changed, 27 insertions(+), 5 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/58181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d1168daaab129a37dc8b31945214fc38a1624cd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: mask fencing alerts when disabled in cluster
by mperina＠redhat.com 30 May '16

30 May '16

Martin Peřina has submitted this change and it was merged. Change subject: core: mask fencing alerts when disabled in cluster ...................................................................... core: mask fencing alerts when disabled in cluster This patch masks the following when fencing is disabled in the cluster level: 1) Exclamation icon when host power management is not configured 2) Alert appearing in the alert tab when power management is not configured for a host 3) The popup form warning the user that power management was not configured when adding a new host In order to do that the VDS entity was expanded to include the fencing_enabled flag from the cluster settings. This flag was added only to the VDS view and is still taken from the cluster properties` Change-Id: I500ae184ade108ddbe1c10eaf3bc5b51e4a5c9ce Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1145240 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/HostStatusCell.java M packaging/dbscripts/create_views.sql 8 files changed, 54 insertions(+), 23 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I500ae184ade108ddbe1c10eaf3bc5b51e4a5c9ce Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: host-deploy: Support deploying Hosted Engine components
by rgolan＠redhat.com 29 May '16

29 May '16

Roy Golan has submitted this change and it was merged. Change subject: host-deploy: Support deploying Hosted Engine components ...................................................................... host-deploy: Support deploying Hosted Engine components Till today a hosts with hosted engine components were added manually by script on the hosts themselves. This patch will enable to install and configure the relevant components by passing all the relevant information from the engine. The prerequisite for that is to have the hosted engine VM imported into the engine. Otherwise we can't gather all the info for the installation. So now a user can select to Deploy/Remove hosted engine agent or leave with no change(see Action) In order to deploy an additional Hosted Engine host we need to provide the configuration that was used by the 1st host and just assign it with a differnt unique host_id. For that we download the configuration from a special disk on the special domain and extract the configuration from it. This behaviour is composed under the HostedEngineConfigFetcher.java utility. Wiki: http://www.ovirt.org/develop/release-management/features/hosted-engine-add-… Change-Id: I535bdfeba41b03c86520408e72abfa914fe3e1be Bug-Url: https://bugzilla.redhat.com/1167262 Signed-off-by: Roy Golan <rgolan(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployHostedEngineUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineConfigFetcher.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/UpdateHostValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineConfigFetcherTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/HostValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/UpdateHostValidatorTest.java A backend/manager/modules/bll/src/test/resources/hosted-engine-config.tar A backend/manager/modules/bll/src/test/resources/hosted-engine.conf A backend/manager/modules/bll/src/test/resources/not-a-valid-hosted-engine-config-tar.tar M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/hostdeploy/InstallVdsParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostedEngineDeployConfiguration.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties 20 files changed, 771 insertions(+), 158 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I535bdfeba41b03c86520408e72abfa914fe3e1be Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: fixing 4.0 publisher to push to 4.0 and not master
by eedri＠redhat.com 29 May '16

29 May '16

Eyal Edri has submitted this change and it was merged. Change subject: fixing 4.0 publisher to push to 4.0 and not master ...................................................................... fixing 4.0 publisher to push to 4.0 and not master Change-Id: I1fe7adaad2d6ea3324c12cb3c550fb0de084daed Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Eyal Edri: Ready for merge Barak Korren: Verified; Looks good to me; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fe7adaad2d6ea3324c12cb3c550fb0de084daed Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.7]: webadmin: Fix of custom properties
by tnisan＠redhat.com 29 May '16

29 May '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix of custom properties ...................................................................... webadmin: Fix of custom properties This patch fixes two problems: * When user (not admin@internal) with VmCreator role tried to create new VM from snapshot (clone) it failed with "User is not authorized to perform this action." * When admin@internal tried to create new VM from snapshot (clone) and changed some custom properties in "Clone VM from Snapshot" dialog the new VM was anyway created without any custom properties. The cause was confusion between abandoned UnitVmModel#customProperties and UnitVmModel#customPropertySheet during model -> business entity serialization. #customPropertySheet is serialized in CoreUnitToVmBaseBuilder Change-Id: I78292af0754bfec8938fe63ea44e71a108684d4e Bug-Url: https://bugzilla.redhat.com/1338943 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78292af0754bfec8938fe63ea44e71a108684d4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.7 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0