- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.7]: frontend: Import VM dialog - architecture
by tnisan＠redhat.com 29 May '16

29 May '16

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Import VM dialog - architecture ...................................................................... frontend: Import VM dialog - architecture * The split table of the dialog shows VMs with architecture: "Name (arch)". * The dialog prevents from continuing to the next page and shows error dialog if the selection * contains VM with multiple architectures (because they can't be imported in one Cluster) * contains VM with architecture for which there is no corresponding Cluster in selected Data Center Change-Id: Ife22ca52a9ba8308f5fce2d52318d182382b2337 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1294451 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java 4 files changed, 104 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58134 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife22ca52a9ba8308f5fce2d52318d182382b2337 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.7 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.7]: engine: Set the vfsType glusterfs when importing HE domain
by tnisan＠redhat.com 29 May '16

29 May '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Set the vfsType glusterfs when importing HE domain ...................................................................... engine: Set the vfsType glusterfs when importing HE domain In HE flow, when importing a gluster domain we must set explicitly the domain type otherwise the mount will fail. This problem discovered when non HE hosts where connecting to that domain. HE hosts have the right mount options in a configuration file (they are connecting before there is an engine live) Change-Id: Ic2383047d5033818ae2c2227e9fd6e756db10eaa Bug-Url: https://bugzilla.redhat.com/1317699 Signed-off-by: Roy Golan <rgolan(a)redhat.com> (cherry picked from commit ed8f4ac73cfaf849982e60b456284b5e88b45e47) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportHostedEngineStorageDomainCommand.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57929 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2383047d5033818ae2c2227e9fd6e756db10eaa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.7 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: notifier: mail logger fixes
by mperina＠redhat.com 27 May '16

27 May '16

Martin Peřina has submitted this change and it was merged. Change subject: core: notifier: mail logger fixes ...................................................................... core: notifier: mail logger fixes Change-Id: I57881e45949fbc3bc4fa7a82ea5bbb5cd0d4ab70 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57636 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57881e45949fbc3bc4fa7a82ea5bbb5cd0d4ab70 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: notifier: add successfull mail sent message
by mperina＠redhat.com 27 May '16

27 May '16

Martin Peřina has submitted this change and it was merged. Change subject: core: notifier: add successfull mail sent message ...................................................................... core: notifier: add successfull mail sent message Change-Id: I5e5311befaa6e27435b4e91bab1059b272dac48b Bug-Url: https://bugzilla.redhat.com/1092907 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57622 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e5311befaa6e27435b4e91bab1059b272dac48b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Map PM iLO3 and iLO4 to their native agents
by mperina＠redhat.com 27 May '16

27 May '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Map PM iLO3 and iLO4 to their native agents ...................................................................... core: Map PM iLO3 and iLO4 to their native agents IPMI is currently implicitly used when working with iLO3/4 fence devices. This was done from historical reasons because fence-agents package did not had specific agents for iLO3/4 But that was changed and now we can use iLO3/4 native drivers which are recommended. Also, lanplus=1 is set by default for the native drivers and there is no need to set it implicitly anymore. Patch was tested with iLO4 agent and works as expected. I will try to find a way to validate it on iLO3 as well and also on PPC machines. Change-Id: I6f5b5799d5f394f194a26edd6ab54172ef4c2205 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1126753 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57739 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f5b5799d5f394f194a26edd6ab54172ef4c2205 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Forbid cluster version change if a VM is active
by piotr.kliczewski＠gmail.com 27 May '16

27 May '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Forbid cluster version change if a VM is active ...................................................................... webadmin: Forbid cluster version change if a VM is active Cluster version change is not allowed when there is an active VM in the cluster. All VMs have to be restarted to allow reconfiguration after cluster version change. Check is performed on: - UI: ClusterModel.validate() - UpdateClusterCommand.validate() Change-Id: I5784d357879b7aa0e49041c13e76f57812cfb1e1 Bug-Url: https://bugzilla.redhat.com/1336527 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/ClusterVersionChangeValidation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 66 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/58125 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5784d357879b7aa0e49041c13e76f57812cfb1e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[refs/meta/config]: Added same permissions for 4.* as in 3.5/6.*
by dcaro＠redhat.com 27 May '16

27 May '16

David Caro has submitted this change and it was merged. Change subject: Added same permissions for 4.* as in 3.5/6.* ...................................................................... Added same permissions for 4.* as in 3.5/6.* Change-Id: I0ee023a8abff3791ae45d0d9bf95f2972c21ea58 --- M project.config 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Barak Korren: Looks good to me, but someone else must approve Gil Shinar: Verified David Caro: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/58021 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ee023a8abff3791ae45d0d9bf95f2972c21ea58 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: refs/meta/config Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: display: Fix display type enum order
by msivak＠redhat.com 27 May '16

27 May '16

Martin Sivák has submitted this change and it was merged. Change subject: display: Fix display type enum order ...................................................................... display: Fix display type enum order Java enums start with ordinal 0. Synchronize the agent enum map with hosted-engine. Change-Id: I6b55d71d0e46060359c7293ef78bfb49259c2844 Related-To: https://bugzilla.redhat.com/1326810 Related-To: https://bugzilla.redhat.com/1328921 Bug-Url: https://bugzilla.redhat.com/1339305 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py M ovirt_hosted_engine_ha/lib/ovf/ovf_test.xml 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Roman Mohr: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58176 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b55d71d0e46060359c7293ef78bfb49259c2844 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: display: Fix display type enum order
by msivak＠redhat.com 27 May '16

27 May '16

Martin Sivák has submitted this change and it was merged. Change subject: display: Fix display type enum order ...................................................................... display: Fix display type enum order Java enums start with ordinal 0. Synchronize the agent enum map with hosted-engine. Change-Id: I6b55d71d0e46060359c7293ef78bfb49259c2844 Related-To: https://bugzilla.redhat.com/1326810 Related-To: https://bugzilla.redhat.com/1328921 Bug-Url: https://bugzilla.redhat.com/1339305 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py M ovirt_hosted_engine_ha/lib/ovf/ovf_test.xml M ovirt_hosted_engine_ha/lib/ovf/ovf_test_max_vcpu.xml 3 files changed, 6 insertions(+), 5 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Roman Mohr: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58171 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b55d71d0e46060359c7293ef78bfb49259c2844 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Update provider popup
by awels＠redhat.com 27 May '16

27 May '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Update provider popup ...................................................................... webadmin: Update provider popup - Updated provider popup to be patternfly based. Change-Id: I5cbdc1227e2766e831e5df77415ef94a4b375fc1 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/VmwarePropertiesWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/VmwarePropertiesWidget.ui.xml 3 files changed, 78 insertions(+), 64 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cbdc1227e2766e831e5df77415ef94a4b375fc1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0