- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: cleanup in migrate command
by ahadas＠redhat.com 29 May '16

29 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in migrate command ...................................................................... core: cleanup in migrate command Minor cleanup in MigrateVDSCommand: 1. Use VmDynamic instead of VM since all migration related data that needs to be updated resides in VmDynamic. 2. Remove unused VmDao (VmDynamicDao was unused before) 3. Styling issues Change-Id: Ic76b418f0d71c4a59a9af401110830c4566a282d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java 1 file changed, 14 insertions(+), 16 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/58089 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic76b418f0d71c4a59a9af401110830c4566a282d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Avoid an infinite loop when untar an entry
by rgolan＠redhat.com 29 May '16

29 May '16

Roy Golan has submitted this change and it was merged. Change subject: core: Avoid an infinite loop when untar an entry ...................................................................... core: Avoid an infinite loop when untar an entry Avoid going into infinite loop in case there is an error during an entry extraction from a tar archive. For example if the tar contains a corrupted or simply an empty file, this will trigger the infinite loop. The fix will just skip to the next entry and will add empty files into the archive (we reflect the tar entries and not ignoring them) Change-Id: I64a8d019cb5c13df19ee21eecb2ab81b42a9b3cc Bug-Url: https://bugzilla.redhat.com/1167262 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/TarInMemoryExport.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/archivers/tar/TarInMemoryExportTest.java A backend/manager/modules/utils/src/test/resources/mixed-content.tar A backend/manager/modules/utils/src/test/resources/non-empty.tar A backend/manager/modules/utils/src/test/resources/tar-with-empty-file.tar 6 files changed, 83 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64a8d019cb5c13df19ee21eecb2ab81b42a9b3cc Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: VdsCommandsHelper - avoid relying on injections
by laravot＠redhat.com 29 May '16

29 May '16

Liron Aravot has submitted this change and it was merged. Change subject: VdsCommandsHelper - avoid relying on injections ...................................................................... VdsCommandsHelper - avoid relying on injections Change-Id: Ib38c138e143935e54611dbcfeb3a04c1a907166e Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/utils/VdsCommandsHelper.java 1 file changed, 9 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57652 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib38c138e143935e54611dbcfeb3a04c1a907166e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AllocateImageGroupVolumeCommand - moved to entity spec...
by laravot＠redhat.com 29 May '16

29 May '16

Liron Aravot has submitted this change and it was merged. Change subject: core: AllocateImageGroupVolumeCommand - moved to entity specific package ...................................................................... core: AllocateImageGroupVolumeCommand - moved to entity specific package moving AllocateImageGroupVolumeCommand to org.ovirt.engine.core.bll.storage.disk.image instead of the general bll package. Change-Id: I518c2f7a07dd3f60b121b70464d287cbddff455f Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AllocateImageGroupVolumeCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57651 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I518c2f7a07dd3f60b121b70464d287cbddff455f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CreateVolumeVDSCommandParameters - ctor params order
by laravot＠redhat.com 29 May '16

29 May '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CreateVolumeVDSCommandParameters - ctor params order ...................................................................... core: CreateVolumeVDSCommandParameters - ctor params order changed the ctor params order so it'll be more trivial. Change-Id: I65844406105934e4be4af305c66f67db82a04c8d Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateVolumeVDSCommandParameters.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65844406105934e4be4af305c66f67db82a04c8d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: StorageJobCallback - poll on ExecutionFailed
by laravot＠redhat.com 29 May '16

29 May '16

Liron Aravot has submitted this change and it was merged. Change subject: StorageJobCallback - poll on ExecutionFailed ...................................................................... StorageJobCallback - poll on ExecutionFailed StorageJobCallback is updated to reflect that its doPolling() should be executed when the command status is ExecutionFailed. Change-Id: I335e3bc5cae72e0f1d00f38b68dcc83ae68dd97b Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57653 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I335e3bc5cae72e0f1d00f38b68dcc83ae68dd97b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: BaseImagesCommand - adjust to dc without spm
by laravot＠redhat.com 29 May '16

29 May '16

Liron Aravot has submitted this change and it was merged. Change subject: core: BaseImagesCommand - adjust to dc without spm ...................................................................... core: BaseImagesCommand - adjust to dc without spm Use GetVolumeInfoVDSCommand for dc without SPM instead of GetImageInfo which is a SPM command. Change-Id: I64965ac398d4a189f190a98e1846c0c418bf739f Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVolumeInfoVDSCommandParameters.java 2 files changed, 25 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/44785 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64965ac398d4a189f190a98e1846c0c418bf739f Gerrit-PatchSet: 29 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageHandlingCommandBaseTest type inference
by amureini＠redhat.com 29 May '16

29 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageHandlingCommandBaseTest type inference ...................................................................... core: StorageHandlingCommandBaseTest type inference Change-Id: Id31e1235337659d994878bf9002ce61d82538978 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/58214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id31e1235337659d994878bf9002ce61d82538978 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix StorageHandlingCommandBaseTest's typo
by amureini＠redhat.com 29 May '16

29 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix StorageHandlingCommandBaseTest's typo ...................................................................... core: Fix StorageHandlingCommandBaseTest's typo Change-Id: Ic7f1cd8463a5a772e05f484b31f88668741242f3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/58215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7f1cd8463a5a772e05f484b31f88668741242f3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: CommandBase - endAction() lock release
by tnisan＠redhat.com 29 May '16

29 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: CommandBase - endAction() lock release ...................................................................... core: CommandBase - endAction() lock release When ending command action the commands locks are freed on endActionInTransactionScope() which is wrong because the transaction should be committed before the lock is released. additionally, currently there is a duplicate call which is unneeded. Change-Id: Ia1405b6010cfebc5cdbe4ac8c87822ea6fc0fd72 Signed-off-by: Liron Aravot <laravot(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1339308 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1405b6010cfebc5cdbe4ac8c87822ea6fc0fd72 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0